[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038653#comment-17038653
]
Kihwal Lee commented on HDFS-11156:
---
Reverted from only 2.10 for now. I also cherry-picked HDFS-12459.
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038590#comment-17038590
]
Kihwal Lee commented on HDFS-11156:
---
Contrary to the Fix Version (3.0.0-alpha2) of this jira, the
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414866#comment-16414866
]
Weiwei Yang commented on HDFS-11156:
Thanks [~andrew.wang], I just created HDFS-13351 to track this
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414187#comment-16414187
]
Andrew Wang commented on HDFS-11156:
Sure, let's revert. I probably just missed it while pushing all
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413288#comment-16413288
]
Weiwei Yang commented on HDFS-11156:
Thanks [~shahrs87] for the quick response. [~andrew.wang], what's
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413277#comment-16413277
]
Rushabh S Shah commented on HDFS-11156:
---
My opinion would be revert this patch from branch-2.
We can
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413275#comment-16413275
]
Weiwei Yang commented on HDFS-11156:
Hi [~ywskycn]
Correct. [~andrew.wang] did the revert, tracked by
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411720#comment-16411720
]
Wei Yan commented on HDFS-11156:
[~andrew.wang] [~cheersyang] this patch should be reverted from branch-2,
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167237#comment-16167237
]
Weiwei Yang commented on HDFS-11156:
Hi [~andrew.wang], thank you, I have created HDFS-12459 to track
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167211#comment-16167211
]
Weiwei Yang commented on HDFS-11156:
Thanks [~shahrs87], [~daryn] and [~andrew.wang],
bq. Remove dfs
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167053#comment-16167053
]
Hudson commented on HDFS-11156:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12876 (See
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167045#comment-16167045
]
Rushabh S Shah commented on HDFS-11156:
---
bq. What was the need for this jira ?
Reading back all the
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167040#comment-16167040
]
Andrew Wang commented on HDFS-11156:
Reverted HDFS-6874 and HDFS-11156, using HDFS-12457 to track the
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167010#comment-16167010
]
Andrew Wang commented on HDFS-11156:
I'm going to revert this for now in the absence of agreement or a
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166690#comment-16166690
]
Rushabh S Shah commented on HDFS-11156:
---
In addition to what [~daryn] said, we already had
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166457#comment-16166457
]
Daryn Sharp commented on HDFS-11156:
Actually, why is the new webhdfs NN method even necessary? Why
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166451#comment-16166451
]
Daryn Sharp commented on HDFS-11156:
-1. Let's file another jira to fix immediately or revert this
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166424#comment-16166424
]
Rushabh S Shah commented on HDFS-11156:
---
bq. Current approach was trying to maintain compatibility
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165687#comment-16165687
]
Weiwei Yang commented on HDFS-11156:
Hi [~shahrs87]
Thanks for sharing your concern, I think you are
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165387#comment-16165387
]
Rushabh S Shah commented on HDFS-11156:
---
I have one concern in this patch.
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799519#comment-15799519
]
Hadoop QA commented on HDFS-11156:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797163#comment-15797163
]
Weiwei Yang commented on HDFS-11156:
Sure [~andrew.wang], I just uploaded the patch for branch-2. The
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795913#comment-15795913
]
Andrew Wang commented on HDFS-11156:
Sorry about that, I've reverted the branch-2 patch. [~cheersyang]
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795897#comment-15795897
]
Daryn Sharp commented on HDFS-11156:
This broke branch-2 due to inner class accessing a non-final.
>
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795771#comment-15795771
]
Hudson commented on HDFS-11156:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11063 (See
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795644#comment-15795644
]
Andrew Wang commented on HDFS-11156:
Sorry for the delay, I was on vacation. +1 LGTM, thanks for the
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760382#comment-15760382
]
Weiwei Yang commented on HDFS-11156:
Hello [~andrew.wang]
When you get a chance, can you help to
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753431#comment-15753431
]
Hadoop QA commented on HDFS-11156:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752601#comment-15752601
]
Andrew Wang commented on HDFS-11156:
Thanks for the explanation, sounds good. A little nit though:
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743813#comment-15743813
]
Weiwei Yang commented on HDFS-11156:
Hello [~andrew.wang]
Please help to review v14 patch when you
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15740890#comment-15740890
]
Hadoop QA commented on HDFS-11156:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15739483#comment-15739483
]
Hadoop QA commented on HDFS-11156:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15739324#comment-15739324
]
Weiwei Yang commented on HDFS-11156:
Hello [~andrew.wang]
Thanks for the comments, here
bq. We don't
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736831#comment-15736831
]
Andrew Wang commented on HDFS-11156:
Thanks for the rev [~cheersyang], looks good overall, some small
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734432#comment-15734432
]
Weiwei Yang commented on HDFS-11156:
Hi [~andrew.wang]
Please let me know if you have any more
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734395#comment-15734395
]
Hadoop QA commented on HDFS-11156:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731624#comment-15731624
]
Hadoop QA commented on HDFS-11156:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731295#comment-15731295
]
Hadoop QA commented on HDFS-11156:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730425#comment-15730425
]
Weiwei Yang commented on HDFS-11156:
Ah nice catch [~andrew.wang]. I got your point, let me make the
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730336#comment-15730336
]
Andrew Wang commented on HDFS-11156:
Hi [~cheersyang], if you look at the [example for
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730274#comment-15730274
]
Weiwei Yang commented on HDFS-11156:
The checkstyle issue in v8 patch is not a concern, like I
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729495#comment-15729495
]
Hadoop QA commented on HDFS-11156:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729061#comment-15729061
]
Hadoop QA commented on HDFS-11156:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728894#comment-15728894
]
Weiwei Yang commented on HDFS-11156:
Hello [~andrew.wang]
Thanks for your comments. I just uploaded
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727245#comment-15727245
]
Andrew Wang commented on HDFS-11156:
Looks pretty good, thanks for revving. A few comments:
* Is it
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725889#comment-15725889
]
Weiwei Yang commented on HDFS-11156:
Uploaded v7 patch, it includes
# V6 patch in this ticket
# The
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724671#comment-15724671
]
Hudson commented on HDFS-11156:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10946 (See
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724654#comment-15724654
]
Weiwei Yang commented on HDFS-11156:
Sure, thanks a lot.
> Add new op GETFILEBLOCKLOCATIONS to
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724650#comment-15724650
]
Mingliang Liu commented on HDFS-11156:
--
Sorry I missed the point of not changing the
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724646#comment-15724646
]
Andrew Wang commented on HDFS-11156:
Great, thanks [~cheersyang]. I'm going to revert this in the
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724634#comment-15724634
]
Weiwei Yang commented on HDFS-11156:
Hi [~andrew.wang]
You are right. I missed that. Thanks!
A
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724552#comment-15724552
]
Andrew Wang commented on HDFS-11156:
Hi [~cheersyang] I think you misunderstand: the new version of
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724468#comment-15724468
]
Weiwei Yang commented on HDFS-11156:
Hi [~andrew.wang]
In that case client can still call
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1572#comment-1572
]
Andrew Wang commented on HDFS-11156:
To expand on my previous comment, the new client will try to call
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724091#comment-15724091
]
Weiwei Yang commented on HDFS-11156:
Hello [~andrew.wang]
Thank you for raising up your concern. I
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723936#comment-15723936
]
Andrew Wang commented on HDFS-11156:
Sorry I didn't get a chance to review this earlier, but I have a
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717152#comment-15717152
]
Weiwei Yang commented on HDFS-11156:
Thanks [~liuml07] :)
> Add new op GETFILEBLOCKLOCATIONS to
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716066#comment-15716066
]
Hudson commented on HDFS-11156:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10930 (See
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715850#comment-15715850
]
Hadoop QA commented on HDFS-11156:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715559#comment-15715559
]
Weiwei Yang commented on HDFS-11156:
Uploaded v6 patch to address a minor change on the comments for
[
https://issues.apache.org/jira/browse/HDFS-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713719#comment-15713719
]
Weiwei Yang commented on HDFS-11156:
Hello [~liuml07]
Thanks, actually I created HDFS-11166 along
61 matches
Mail list logo
