[ 
https://issues.apache.org/jira/browse/HDFS-11364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840200#comment-15840200
 ] 

Xiao Chen commented on HDFS-11364:
----------------------------------

Added test looks good, +1. Linked HADOOP-12776 as a dependency.
Will commit shortly.

> Verify Audit log entries for setfacl/getfacl commands over FS shell
> -------------------------------------------------------------------
>
>                 Key: HDFS-11364
>                 URL: https://issues.apache.org/jira/browse/HDFS-11364
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs, test
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>         Attachments: HDFS-11364.01.patch
>
>
> The general phenomena has been to Audit log all successful commands and the 
> ones resulting in AccessControlException. For ACLs, we do have a unit test 
> covering the AccessControlException/Failure cases. Would be better if we can 
> have a unit test covering the successful ACL APIs and ACL commands over FS 
> shell as well.
> Additionally, FS Shell getfacl command has a performance improvement 
> (HADOOP-12776) where by the shell would skip the call to getAclStatus if the 
> permission bits in getFileInfo() doesn't have ACL bit set. Good to have Audit 
> log test covering this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to