[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157942#comment-16157942
]
Manoj Govindassamy commented on HDFS-12357:
---
hdfs-default.xml is missing the right config param
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157706#comment-16157706
]
Hudson commented on HDFS-12357:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12811 (See
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157353#comment-16157353
]
Yongjun Zhang commented on HDFS-12357:
--
Many thanks to [~asuresh], [~chris.douglas], [~daryn],
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156654#comment-16156654
]
Hadoop QA commented on HDFS-12357:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156615#comment-16156615
]
Manoj Govindassamy commented on HDFS-12357:
---
Thanks for the patch revision [~yzhangal]. LGTM,
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156498#comment-16156498
]
Yongjun Zhang commented on HDFS-12357:
--
Thanks [~manojg] for the review.
Uploaded rev7 to address
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155925#comment-16155925
]
Manoj Govindassamy commented on HDFS-12357:
---
Thanks for working on the patch revision
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155802#comment-16155802
]
Hadoop QA commented on HDFS-12357:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154736#comment-16154736
]
Yongjun Zhang commented on HDFS-12357:
--
Thanks for the review [~manojg], good catches.
I uploaded
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154605#comment-16154605
]
Manoj Govindassamy commented on HDFS-12357:
---
Thanks for working on this [~yzhangal]. Thanks
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154520#comment-16154520
]
Yongjun Zhang commented on HDFS-12357:
--
Many thanks [~chris.douglas] for the offline discussions!
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154337#comment-16154337
]
Chris Douglas commented on HDFS-12357:
--
Had offline discussions with [~yzhangal]. We tried a version
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151587#comment-16151587
]
Chris Douglas commented on HDFS-12357:
--
bq. if we can avoid duplicate of components, it would be
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151577#comment-16151577
]
Hadoop QA commented on HDFS-12357:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151547#comment-16151547
]
Hadoop QA commented on HDFS-12357:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151448#comment-16151448
]
Yongjun Zhang commented on HDFS-12357:
--
HI [~manojg],
{quote}
Having
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151396#comment-16151396
]
Hadoop QA commented on HDFS-12357:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151362#comment-16151362
]
Yongjun Zhang commented on HDFS-12357:
--
HI [~chris.douglas],
I uploaded rev005 to avoid the
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151361#comment-16151361
]
Hadoop QA commented on HDFS-12357:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151345#comment-16151345
]
Yongjun Zhang commented on HDFS-12357:
--
Hi [~chris.douglas],
With v004, the only concern is now
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151344#comment-16151344
]
Manoj Govindassamy commented on HDFS-12357:
---
Thanks for the patch [~chris.douglas]. Having
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151325#comment-16151325
]
Yongjun Zhang commented on HDFS-12357:
--
Ah, I overlooked the code here you added in the new class
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151315#comment-16151315
]
Yongjun Zhang commented on HDFS-12357:
--
HI [~chris.douglas],
Would you please revisit my comment
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151306#comment-16151306
]
Yongjun Zhang commented on HDFS-12357:
--
Hm, I saw that you do this
{code}
@Override
public
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151304#comment-16151304
]
Chris Douglas commented on HDFS-12357:
--
The inner provider is not invoked.
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151290#comment-16151290
]
Yongjun Zhang commented on HDFS-12357:
--
{quote}
As in the v001 version, this is avoided.
{quote}
Not
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151280#comment-16151280
]
Chris Douglas commented on HDFS-12357:
--
v002 assumed that enforcement should always delegate to the
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151272#comment-16151272
]
Yongjun Zhang commented on HDFS-12357:
--
Hi [~chris.douglas],
In patch rev1, I passed null to
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151246#comment-16151246
]
Chris Douglas commented on HDFS-12357:
--
I wasn't sure if
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151239#comment-16151239
]
Chris Douglas commented on HDFS-12357:
--
bq. 1. the wrapper need to create two provider objects, one
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151189#comment-16151189
]
Yongjun Zhang commented on HDFS-12357:
--
HI [~chris.douglas],
Sorry I did not see your latest comment
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151121#comment-16151121
]
Hadoop QA commented on HDFS-12357:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151047#comment-16151047
]
Yongjun Zhang commented on HDFS-12357:
--
Thanks [~chris.douglas] and [~manojg].
Sorry for a lengthy
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150921#comment-16150921
]
Manoj Govindassamy commented on HDFS-12357:
---
Thanks for working on this [~yzhangal]. Thanks
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150890#comment-16150890
]
Chris Douglas commented on HDFS-12357:
--
bq. we can implement the same logic in the provider. However,
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150819#comment-16150819
]
Yongjun Zhang commented on HDFS-12357:
--
HI [~chris.douglas],
Thanks a lot for your comment.
Some
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149947#comment-16149947
]
Chris Douglas commented on HDFS-12357:
--
Sorry to be dense, but why can't this live in the external
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149912#comment-16149912
]
Yongjun Zhang commented on HDFS-12357:
--
Hi [~atm], [~daryn] [~manojg], any comments/thoughts on my
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148139#comment-16148139
]
Yongjun Zhang commented on HDFS-12357:
--
Thanks you all for the review and comments!
[~atm]: good
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148062#comment-16148062
]
Manoj Govindassamy commented on HDFS-12357:
---
[~yzhangal],
Here is one other jira on the
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147258#comment-16147258
]
Daryn Sharp commented on HDFS-12357:
Should this perhaps be implemented in the external attribute
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146393#comment-16146393
]
Aaron T. Myers commented on HDFS-12357:
---
Took a quick look at the patch, not thorough. One thing
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143514#comment-16143514
]
Hadoop QA commented on HDFS-12357:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143421#comment-16143421
]
Yongjun Zhang commented on HDFS-12357:
--
Hi [~asuresh], [~chris.douglas], [~daryn], [~manojg] and
44 matches
Mail list logo
