[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344535#comment-16344535
]
Weiwei Yang commented on HDFS-12528:
Hi [~xiaochen], +1 to the latest patch, thanks for getting it
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344511#comment-16344511
]
Xiao Chen commented on HDFS-12528:
--
precommit failures are unrelated to the change. [~cheersyang] /
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344202#comment-16344202
]
genericqa commented on HDFS-12528:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343987#comment-16343987
]
Xiao Chen commented on HDFS-12528:
--
[~GeLiXin], thanks for detailed review. Sure, patch 5 a local var for
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343285#comment-16343285
]
LiXin Ge commented on HDFS-12528:
-
Nice work, +1 non-binding. Only a trivial proposal which is not
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343214#comment-16343214
]
genericqa commented on HDFS-12528:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343107#comment-16343107
]
genericqa commented on HDFS-12528:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343012#comment-16343012
]
Xiao Chen commented on HDFS-12528:
--
Thanks [~jzhuge] reviewing!
{quote}will we ever need to set
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343005#comment-16343005
]
John Zhuge commented on HDFS-12528:
---
[~xiaochen], thanks for the great work! Patch 03 LGTM. Just a minor
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342983#comment-16342983
]
Weiwei Yang commented on HDFS-12528:
Hi [~xiaochen], thanks for the update. LGTM, pending on jenkins.
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342939#comment-16342939
]
Xiao Chen commented on HDFS-12528:
--
Thanks for the clarification [~cheersyang]. I indeed misunderstood -
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342160#comment-16342160
]
Weiwei Yang commented on HDFS-12528:
Hi [~xiaochen]
Sure we need those errors, I think you might
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342013#comment-16342013
]
Xiao Chen commented on HDFS-12528:
--
Thanks for the review and comments.
Even though it's not disabled, I
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341942#comment-16341942
]
LiXin Ge commented on HDFS-12528:
-
Hi [~cheersyang], thanks for your suggestion.
{quote}
if
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341897#comment-16341897
]
Weiwei Yang commented on HDFS-12528:
Hi [~xiaochen]
I still have some nits on the logging, giving if
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341834#comment-16341834
]
genericqa commented on HDFS-12528:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341608#comment-16341608
]
Xiao Chen commented on HDFS-12528:
--
Thanks [~cheersyang].
Attaching [^HDFS-12528.02.patch] to add the
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340722#comment-16340722
]
Weiwei Yang commented on HDFS-12528:
Hi [~xiaochen], [~GeLiXin]
My side I think #1 is enough, but
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340558#comment-16340558
]
Xiao Chen commented on HDFS-12528:
--
Thanks for looking at this [~GeLiXin] and offering to work on it.
I
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340427#comment-16340427
]
genericqa commented on HDFS-12528:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340385#comment-16340385
]
LiXin Ge commented on HDFS-12528:
-
BTW, [~xiaochen] in case if you don't have enough time to do #3, I'm
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340358#comment-16340358
]
LiXin Ge commented on HDFS-12528:
-
IMO, how about to do both #1 and #3? #1 make sure that user can avoid
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336895#comment-16336895
]
Xiao Chen commented on HDFS-12528:
--
Attaching a patch to do just #1, with enhanced unit tests from John
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301870#comment-16301870
]
Xiao Chen commented on HDFS-12528:
--
Looked at this again with the helpful unit test from John.
IMO we
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300947#comment-16300947
]
Xiao Chen commented on HDFS-12528:
--
No problem, I'll take a crack soon. Thanks John!
> Short-circuit
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299614#comment-16299614
]
John Zhuge commented on HDFS-12528:
---
Unfortunately I won't have time for a while. Unassign myself.
>
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299600#comment-16299600
]
Xiao Chen commented on HDFS-12528:
--
Sorry, stupid me. I guess I didn't mvn clean when rebuilding with the
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299589#comment-16299589
]
John Zhuge commented on HDFS-12528:
---
Yes, that would shorten the path greatly.
> Short-circuit reads
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299537#comment-16299537
]
Xiao Chen commented on HDFS-12528:
--
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299531#comment-16299531
]
John Zhuge commented on HDFS-12528:
---
[~xiaochen] Puzzled. The hadoop-hdfs/pom.xml changes in
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299515#comment-16299515
]
Xiao Chen commented on HDFS-12528:
--
Thanks all for the discussions, and [~jzhuge] for a test patch.
Hi
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272279#comment-16272279
]
Weiwei Yang commented on HDFS-12528:
bq. What's the risk if we don't disable the SCR at all when we
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272240#comment-16272240
]
Gang Xie commented on HDFS-12528:
-
What's the risk if we don't disable the SCR at all when we get any
[
https://issues.apache.org/jira/browse/HDFS-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270285#comment-16270285
]
Gang Xie commented on HDFS-12528:
-
create a patch for case when block is invalid by balancer, which also
34 matches
Mail list logo
