[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341622#comment-16341622 ] Hudson commented on HDFS-13054: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13568 (See

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-24 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338825#comment-16338825 ] genericqa commented on HDFS-13054: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-24 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338677#comment-16338677 ] Arpit Agarwal commented on HDFS-13054: -- Kicked off a new precommit build, given the large number of

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-24 Thread Nanda kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337638#comment-16337638 ] Nanda kumar commented on HDFS-13054: Test failures are not related to this patch. Checkstyle issue is

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-23 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336585#comment-16336585 ] genericqa commented on HDFS-13054: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-23 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336582#comment-16336582 ] genericqa commented on HDFS-13054: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-23 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336557#comment-16336557 ] genericqa commented on HDFS-13054: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-23 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336350#comment-16336350 ] Arpit Agarwal commented on HDFS-13054: -- Thanks [~nandakumar131]. +1 pending Jenkins run. > Handling

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-23 Thread Nanda kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336347#comment-16336347 ] Nanda kumar commented on HDFS-13054: Thanks for the suggestion, yeah it is good to have Assert if the

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-23 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336335#comment-16336335 ] Arpit Agarwal commented on HDFS-13054: -- One more suggestion, you can add a fail(...) call immediately

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-23 Thread Nanda kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336331#comment-16336331 ] Nanda kumar commented on HDFS-13054: Thanks for the review [~arpitagarwal], fixed the same in patch

[jira] [Commented] (HDFS-13054) Handling PathIsNotEmptyDirectoryException in DFSClient delete call

2018-01-23 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336327#comment-16336327 ] Arpit Agarwal commented on HDFS-13054: -- Thanks for this improvement [~nandakumar131]. Minor comment