[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381092#comment-16381092
]
Hudson commented on HDFS-13102:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13741 (See
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381068#comment-16381068
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
+1 the 009 patch looks good.
For the checkstyle
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381063#comment-16381063
]
genericqa commented on HDFS-13102:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380814#comment-16380814
]
Shashikant Banerjee commented on HDFS-13102:
Thanks [~szetszwo], for the review . Patch v9
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380794#comment-16380794
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
The 008 patch looks good.
-
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380254#comment-16380254
]
genericqa commented on HDFS-13102:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380049#comment-16380049
]
Shashikant Banerjee commented on HDFS-13102:
Thanks [~szetszwo], for the review. patch v8
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379500#comment-16379500
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
- Pass skipInterval and maxSkipLevels in the
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379457#comment-16379457
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
- In getMinListForRange, we can clean up the
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379415#comment-16379415
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
- The ListItr class can be moved as an anonymous
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379404#comment-16379404
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
- In addFirst and addLast, pass nodeLevel to new
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379394#comment-16379394
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
Thanks for the update. Some comments on the 007
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378688#comment-16378688
]
genericqa commented on HDFS-13102:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378453#comment-16378453
]
Shashikant Banerjee commented on HDFS-13102:
Thanks [~szetszwo], for the review. Patch v7
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377813#comment-16377813
]
genericqa commented on HDFS-13102:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377551#comment-16377551
]
Shashikant Banerjee commented on HDFS-13102:
Thanks [~szetszwo], for the review. Patch v6
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376630#comment-16376630
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
[~shashikant], thanks for updating the patch
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375206#comment-16375206
]
genericqa commented on HDFS-13102:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375145#comment-16375145
]
genericqa commented on HDFS-13102:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375087#comment-16375087
]
Shashikant Banerjee commented on HDFS-13102:
Removed the earlier v5 patch as it was stale.
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374987#comment-16374987
]
Shashikant Banerjee commented on HDFS-13102:
Thanks [~szetszwo], for the review. As per our
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372331#comment-16372331
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
> We need the INodeDirectory Reference for 3
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372327#comment-16372327
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
Suppose the skip interval is 3
{noformat}
s0
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372323#comment-16372323
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
Hi [~shashikant], I believe your idea on adding
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371629#comment-16371629
]
genericqa commented on HDFS-13102:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371456#comment-16371456
]
Shashikant Banerjee commented on HDFS-13102:
Thanks [~szetszwo], for the review comments.
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370396#comment-16370396
]
Shashikant Banerjee commented on HDFS-13102:
I am holding on to other patches until this gets
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370391#comment-16370391
]
Shashikant Banerjee commented on HDFS-13102:
Thanks Nicholas for the Review.
There are some
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370378#comment-16370378
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
Some more comments:
- There seems a bug in
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370365#comment-16370365
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
> Removes will be handled as a part HDFS-13171
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370330#comment-16370330
]
Shashikant Banerjee commented on HDFS-13102:
Thanks [~szetszwo], for the review comments.
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370199#comment-16370199
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
Thanks [~shashikant] for working on this. Some
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369631#comment-16369631
]
genericqa commented on HDFS-13102:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369585#comment-16369585
]
Shashikant Banerjee commented on HDFS-13102:
Thanks [~szetszwo] for the review comments. Patch
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369253#comment-16369253
]
Tsz Wo Nicholas Sze commented on HDFS-13102:
{code}
private List skipDiffList;
{code}
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366905#comment-16366905
]
genericqa commented on HDFS-13102:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366228#comment-16366228
]
Shashikant Banerjee commented on HDFS-13102:
Patch v2 implements the DiffList interface
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354860#comment-16354860
]
genericqa commented on HDFS-13102:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350793#comment-16350793
]
Shashikant Banerjee commented on HDFS-13102:
Patch v1 implements a SnapshotSkipList for
39 matches
Mail list logo
