[jira] [Commented] (HDFS-13194) CachePool permissions incorrectly checked

2018-02-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379691#comment-16379691 ] Hudson commented on HDFS-13194: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13733 (See

[jira] [Commented] (HDFS-13194) CachePool permissions incorrectly checked

2018-02-27 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378461#comment-16378461 ] Yiqun Lin commented on HDFS-13194: -- Thanks for the updating the patch, [~jiangjianfei]. LGTM, +1. Will

[jira] [Commented] (HDFS-13194) CachePool permissions incorrectly checked

2018-02-27 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378314#comment-16378314 ] genericqa commented on HDFS-13194: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13194) CachePool permissions incorrectly checked

2018-02-26 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378148#comment-16378148 ] genericqa commented on HDFS-13194: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13194) CachePool permissions incorrectly checked

2018-02-26 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378135#comment-16378135 ] Yiqun Lin commented on HDFS-13194: -- Thanks for providing the patch. Almost looks good, but the test case

[jira] [Commented] (HDFS-13194) CachePool permissions incorrectly checked

2018-02-26 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377994#comment-16377994 ] Yiqun Lin commented on HDFS-13194: -- [~jiangjianfei], you have already done the fix for this, it's okay to

[jira] [Commented] (HDFS-13194) CachePool permissions incorrectly checked

2018-02-26 Thread Jianfei Jiang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377991#comment-16377991 ] Jianfei Jiang commented on HDFS-13194: -- Sorry [~linyiqun], I missed your comment and add a patch,

[jira] [Commented] (HDFS-13194) CachePool permissions incorrectly checked

2018-02-26 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377986#comment-16377986 ] Yiqun Lin commented on HDFS-13194: -- Thanks for the comments, [~hexiaoqiao] and [~jiangjianfei]. I will

[jira] [Commented] (HDFS-13194) CachePool permissions incorrectly checked

2018-02-26 Thread Jianfei Jiang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376935#comment-16376935 ] Jianfei Jiang commented on HDFS-13194: -- Disgree with [~hexiaoqiao], the fix still return without

[jira] [Commented] (HDFS-13194) CachePool permissions incorrectly checked

2018-02-26 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376839#comment-16376839 ] He Xiaoqiao commented on HDFS-13194: +1, maybe the following demonstrates approach is more POSIX-like