[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396452#comment-16396452
]
Yiqun Lin commented on HDFS-13226:
--
+1, committing this...
> RBF: We should throw the fa
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395439#comment-16395439
]
Íñigo Goiri commented on HDFS-13226:
[^HDFS-13226.009.patch] LGTM.
+1 waiting for [~li
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394978#comment-16394978
]
genericqa commented on HDFS-13226:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394832#comment-16394832
]
maobaolong commented on HDFS-13226:
---
[~elgoiri] Indeed, thank you for telling me. PTAL.
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394731#comment-16394731
]
Íñigo Goiri commented on HDFS-13226:
For [^HDFS-13226.008.patch], the checkstyle is r
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394602#comment-16394602
]
genericqa commented on HDFS-13226:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394547#comment-16394547
]
maobaolong commented on HDFS-13226:
---
[~linyiqun] I've recover the `this` to the error me
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393989#comment-16393989
]
genericqa commented on HDFS-13226:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393902#comment-16393902
]
Yiqun Lin commented on HDFS-13226:
--
Thanks [~maobaolong] for updating the patch. Almost l
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393800#comment-16393800
]
maobaolong commented on HDFS-13226:
---
[~elgoiri] Yeah, it is easy to do, and i have updat
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393242#comment-16393242
]
Íñigo Goiri commented on HDFS-13226:
I like the constants approach.
Maybe doing the sa
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392898#comment-16392898
]
maobaolong commented on HDFS-13226:
---
[~linyiqun] [~elgoiri] Thank you for your suggestio
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392896#comment-16392896
]
genericqa commented on HDFS-13226:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392308#comment-16392308
]
Yiqun Lin commented on HDFS-13226:
--
[~maobaolong], thanks for updating the patch. Besides
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391604#comment-16391604
]
Íñigo Goiri commented on HDFS-13226:
I like the new unit test in [^HDFS-13226.005.pat
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391591#comment-16391591
]
genericqa commented on HDFS-13226:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391352#comment-16391352
]
maobaolong commented on HDFS-13226:
---
[~linyiqun] I've upload a new patch just now, not s
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390737#comment-16390737
]
genericqa commented on HDFS-13226:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390697#comment-16390697
]
maobaolong commented on HDFS-13226:
---
My next patch will base on v003, let me complete t
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390628#comment-16390628
]
Yiqun Lin commented on HDFS-13226:
--
{quote}and the end user really want to realize what m
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390619#comment-16390619
]
maobaolong commented on HDFS-13226:
---
[~linyiqun] So, what about v003 patch, it fit the H
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390615#comment-16390615
]
Yiqun Lin commented on HDFS-13226:
--
Just looking into the v004 patch. I don't think it's
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390595#comment-16390595
]
Íñigo Goiri commented on HDFS-13226:
I'd be OK switching to using {void}, we intenrall
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390570#comment-16390570
]
maobaolong commented on HDFS-13226:
---
[~elgoiri] I think we should check the exception fo
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390566#comment-16390566
]
Íñigo Goiri commented on HDFS-13226:
In [^HDFS-13226.004.patch], for the unit test, sh
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390567#comment-16390567
]
maobaolong commented on HDFS-13226:
---
As the Router has not been used widely, we maybe ca
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390543#comment-16390543
]
Íñigo Goiri commented on HDFS-13226:
Let's keep the return to boolean for now; just fo
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390537#comment-16390537
]
maobaolong commented on HDFS-13226:
---
[~elgoiri] Yeah, i think throw the IllegalArgumentE
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389822#comment-16389822
]
Íñigo Goiri commented on HDFS-13226:
Thanks [~maobaolong] for [^HDFS-13226.002.patch]
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389674#comment-16389674
]
genericqa commented on HDFS-13226:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389436#comment-16389436
]
maobaolong commented on HDFS-13226:
---
[~linyiqun] Would you like to take another look?
>
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388932#comment-16388932
]
Íñigo Goiri commented on HDFS-13226:
Thanks [~maobaolong] for the examples; that makes
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388924#comment-16388924
]
maobaolong commented on HDFS-13226:
---
{code:java}
public boolean validate() {
boolea
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387305#comment-16387305
]
Yiqun Lin commented on HDFS-13226:
--
Hi [~maobaolong],
{quote}If we change the log error t
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387242#comment-16387242
]
maobaolong commented on HDFS-13226:
---
[~elgoiri] If we change the log error to throw IOEx
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386368#comment-16386368
]
Íñigo Goiri commented on HDFS-13226:
I think this is a valid check.
I would add a unit
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386054#comment-16386054
]
genericqa commented on HDFS-13226:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385915#comment-16385915
]
maobaolong commented on HDFS-13226:
---
[~elgoiri] Do you think this is a bug? Please take
38 matches
Mail list logo
