[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543558#comment-17543558
]
fanshilun commented on HDFS-13245:
--
I think this jira can be closed, and related functions have been
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871946#comment-16871946
]
Hadoop QA commented on HDFS-13245:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669008#comment-16669008
]
Íñigo Goiri commented on HDFS-13245:
Can we rebase this to HDFS-13891?
> RBF: State store DBMS
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608532#comment-16608532
]
Hadoop QA commented on HDFS-13245:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478719#comment-16478719
]
Yiran Wu commented on HDFS-13245:
-
Hi, [~giovanni.fumarola] . Thanks for code review.
The h2database used
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477732#comment-16477732
]
Giovanni Matteo Fumarola commented on HDFS-13245:
-
Thanks [~yiran] for the patch.
One
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477381#comment-16477381
]
genericqa commented on HDFS-13245:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477214#comment-16477214
]
Yiran Wu commented on HDFS-13245:
-
Thinks [~jasonfu9966] for comments.
I fixed it and already submitted
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476197#comment-16476197
]
Jason Fu commented on HDFS-13245:
-
I've found a typo:
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471705#comment-16471705
]
genericqa commented on HDFS-13245:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468918#comment-16468918
]
Yiran Wu commented on HDFS-13245:
-
Thanks [~linyiqun] for review.
{quote}For the setting
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468533#comment-16468533
]
Yiqun Lin commented on HDFS-13245:
--
Thanks [~yiran] for updating the patch. Some comments from me:
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467385#comment-16467385
]
genericqa commented on HDFS-13245:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465149#comment-16465149
]
genericqa commented on HDFS-13245:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464707#comment-16464707
]
genericqa commented on HDFS-13245:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464200#comment-16464200
]
genericqa commented on HDFS-13245:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463693#comment-16463693
]
genericqa commented on HDFS-13245:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462372#comment-16462372
]
Yiran Wu commented on HDFS-13245:
-
Thinks [~elgoiri] and [~linyiqun] .
I already add a new patch.
>
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462251#comment-16462251
]
genericqa commented on HDFS-13245:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461863#comment-16461863
]
Yiqun Lin commented on HDFS-13245:
--
{quote}
Let's add TestStateStoreDisabledNameserviceStore in a
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461334#comment-16461334
]
Íñigo Goiri commented on HDFS-13245:
Let's add TestStateStoreDisabledNameserviceStore in a separate
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460792#comment-16460792
]
Yiqun Lin commented on HDFS-13245:
--
Some review comments from me:
* I see
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459726#comment-16459726
]
Yiran Wu commented on HDFS-13245:
-
Thanks [~elgoiri] review this code and some suggestions. I already
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459693#comment-16459693
]
genericqa commented on HDFS-13245:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459582#comment-16459582
]
genericqa commented on HDFS-13245:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457303#comment-16457303
]
Íñigo Goiri commented on HDFS-13245:
Thanks for adding the unit tests in [^HDFS-13245.004.patch].
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457289#comment-16457289
]
maobaolong commented on HDFS-13245:
---
[~yiran] Thank you for this great work. It look good overall, I
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456728#comment-16456728
]
genericqa commented on HDFS-13245:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456487#comment-16456487
]
Yiran Wu commented on HDFS-13245:
-
Add new patch.
> RBF: State store DBMS implementation
>
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453511#comment-16453511
]
Yiran Wu commented on HDFS-13245:
-
Ok, I will add it . :D cc: [~linyiqun]
> RBF: State store DBMS
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453436#comment-16453436
]
genericqa commented on HDFS-13245:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453392#comment-16453392
]
Yiqun Lin commented on HDFS-13245:
--
hI [~yiran], haven't taken a deep look, but one comment: It will be
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453353#comment-16453353
]
Yiran Wu commented on HDFS-13245:
-
Thanks to [~elgoiri] and [~maobaolong] suggestions。
I am writing this
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452959#comment-16452959
]
genericqa commented on HDFS-13245:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452780#comment-16452780
]
Íñigo Goiri commented on HDFS-13245:
Is there any plugin or framework that we can use to at least
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452658#comment-16452658
]
Yiran Wu commented on HDFS-13245:
-
Add new patch. move the sql scripts to the RBF module folder.
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450288#comment-16450288
]
Íñigo Goiri commented on HDFS-13245:
[~giovanni.fumarola], any feedback on how to test this?
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449899#comment-16449899
]
maobaolong commented on HDFS-13245:
---
[~yiran] Maybe you can test your logic in mock way, as this is unit
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449703#comment-16449703
]
Yiran Wu commented on HDFS-13245:
-
I already test h2, look like it does't to work. cause is h2 parser has
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449467#comment-16449467
]
Yiran Wu commented on HDFS-13245:
-
Thanks [~elgoiri] for review this code.
I want to use h2 write unit
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445964#comment-16445964
]
Íñigo Goiri commented on HDFS-13245:
A couple comments:
* Should the sql scripts go into the RBF
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445655#comment-16445655
]
maobaolong commented on HDFS-13245:
---
This patch seems good overall, i will take a look when i have time.
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437425#comment-16437425
]
genericqa commented on HDFS-13245:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436233#comment-16436233
]
Giovanni Matteo Fumarola commented on HDFS-13245:
-
[~elgoiri], I will review it.
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435810#comment-16435810
]
Íñigo Goiri commented on HDFS-13245:
[~giovanni.fumarola], do you mind taking a look to this patch?
>
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435376#comment-16435376
]
genericqa commented on HDFS-13245:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435054#comment-16435054
]
Yiran Wu commented on HDFS-13245:
-
Add patch, implement DB as a backend. Pls review it.
> RBF: State
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434245#comment-16434245
]
Íñigo Goiri commented on HDFS-13245:
Thanks [~yiran] for taking this.
Try to align as much as possible
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433630#comment-16433630
]
maobaolong commented on HDFS-13245:
---
[~yiran] Look forward your patch.
> RBF: State store DBMS
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433629#comment-16433629
]
maobaolong commented on HDFS-13245:
---
[~yiran] Look forward your patch.
> RBF: State store DBMS
[
https://issues.apache.org/jira/browse/HDFS-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1644#comment-1644
]
Yiran Wu commented on HDFS-13245:
-
I am implementing this, support state store uses Database as a backend.
51 matches
Mail list logo
