[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500319#comment-16500319
]
Hudson commented on HDFS-13281:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14349 (See
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482956#comment-16482956
]
Rushabh S Shah commented on HDFS-13281:
---
Ran all of failed tests but only couple of them failed on
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479500#comment-16479500
]
genericqa commented on HDFS-13281:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479452#comment-16479452
]
Rushabh S Shah commented on HDFS-13281:
---
bq. WFM, +1 on patch 4.
Thank you [~xiaochen], [~daryn].
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479449#comment-16479449
]
Xiao Chen commented on HDFS-13281:
--
WFM, +1 on patch 4.
> Namenode#createFile should be /.reserved/raw/
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479189#comment-16479189
]
Rushabh S Shah commented on HDFS-13281:
---
bq. How about we end the debate by just creating the file
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479136#comment-16479136
]
Daryn Sharp commented on HDFS-13281:
{quote}The argument is the test should verify the encrypted bytes
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478525#comment-16478525
]
Xiao Chen commented on HDFS-13281:
--
I understand the no edek part. The argument is the test should verify
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478284#comment-16478284
]
Rushabh S Shah commented on HDFS-13281:
---
bq. As far as this unit test is concerned, we should still
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478269#comment-16478269
]
Xiao Chen commented on HDFS-13281:
--
Aha, my memory faded with this
I was thinking about [this
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478257#comment-16478257
]
Rushabh S Shah commented on HDFS-13281:
---
Thanks [~xiaochen] for reviewing the latest patch.
bq. So
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478206#comment-16478206
]
Xiao Chen commented on HDFS-13281:
--
Thanks [~shahrs87] for continuing on this.
{code}
os =
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476037#comment-16476037
]
Rushabh S Shah commented on HDFS-13281:
---
Test failures on the recent run.
{noformat}
[INFO]
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475176#comment-16475176
]
genericqa commented on HDFS-13281:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437268#comment-16437268
]
Rushabh S Shah commented on HDFS-13281:
---
{quote}do we have plan to get this patch in shortly?
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437122#comment-16437122
]
Junping Du commented on HDFS-13281:
---
Hi [~shahrs87] and [~xiaochen], do we have plan to get this patch
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421160#comment-16421160
]
Xiao Chen commented on HDFS-13281:
--
Thanks Rushabh.
bq. Is there anything you expect me to change in the
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420796#comment-16420796
]
genericqa commented on HDFS-13281:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420583#comment-16420583
]
genericqa commented on HDFS-13281:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420553#comment-16420553
]
Rushabh S Shah commented on HDFS-13281:
---
{quote}Could you write a design doc elaborating all these,
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419827#comment-16419827
]
Xiao Chen commented on HDFS-13281:
--
Fair enough for webhdfs. Please add necessary links. I'd think this
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419803#comment-16419803
]
Rushabh S Shah commented on HDFS-13281:
---
{quote}I think at the minimum we should setxattr
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419441#comment-16419441
]
Xiao Chen commented on HDFS-13281:
--
{quote}
{quote}in which case there will be no step #3
{quote}
Didn't
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419287#comment-16419287
]
genericqa commented on HDFS-13281:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419067#comment-16419067
]
Rushabh S Shah commented on HDFS-13281:
---
{quote}
Because reading /.reserved/raw is supposed to be
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419057#comment-16419057
]
Rushabh S Shah commented on HDFS-13281:
---
Thanks [~xiaochen] for the comment.
bq. so this patch only
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418441#comment-16418441
]
Xiao Chen commented on HDFS-13281:
--
Makes sense, so this patch only applies if step #1 does a
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418094#comment-16418094
]
Rushabh S Shah commented on HDFS-13281:
---
bq. How does HDFS-12597 use it?
The use case is:
1.
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416212#comment-16416212
]
Xiao Chen commented on HDFS-13281:
--
Still don't understand the use cases, please help me understand.
I
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416007#comment-16416007
]
Rushabh S Shah commented on HDFS-13281:
---
This will be used in HDFS-12597 but it is not directly
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414757#comment-16414757
]
Xiao Chen commented on HDFS-13281:
--
Thanks for working on this [~shahrs87].
Could you provide some
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410358#comment-16410358
]
Rushabh S Shah commented on HDFS-13281:
---
[~xiaochen]: can you please help me review this patch ?
>
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404978#comment-16404978
]
Rushabh S Shah commented on HDFS-13281:
---
All the above test failures are unrelated to my patch.
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400858#comment-16400858
]
genericqa commented on HDFS-13281:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400562#comment-16400562
]
Rushabh S Shah commented on HDFS-13281:
---
Added a check to skip creating \{{FileEncryptionInfo}} if
35 matches
Mail list logo
