[jira] [Commented] (HDFS-13287) TestINodeFile#testGetBlockType results in NPE when run alone
[ https://issues.apache.org/jira/browse/HDFS-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802447#comment-17802447 ] Shilun Fan commented on HDFS-13287: --- Bulk update: moved all 3.4.0 non-blocker issues, please move back if it is a blocker. > TestINodeFile#testGetBlockType results in NPE when run alone > > > Key: HDFS-13287 > URL: https://issues.apache.org/jira/browse/HDFS-13287 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Virajith Jalaparti >Assignee: Virajith Jalaparti >Priority: Minor > Attachments: HDFS-13287.01.patch > > > When TestINodeFile#testGetBlockType is run by itself, it results in the > following error: > {code:java} > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.218 > s <<< FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestINodeFile > [ERROR] > testGetBlockType(org.apache.hadoop.hdfs.server.namenode.TestINodeFile) Time > elapsed: 0.023 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getPolicyInfoByID(ErasureCodingPolicyManager.java:220) > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getByID(ErasureCodingPolicyManager.java:208) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile$HeaderFormat.getBlockLayoutRedundancy(INodeFile.java:207) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile.(INodeFile.java:266) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.createStripedINodeFile(TestINodeFile.java:112) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.testGetBlockType(TestINodeFile.java:299) > > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13287) TestINodeFile#testGetBlockType results in NPE when run alone
[ https://issues.apache.org/jira/browse/HDFS-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867613#comment-16867613 ] Hudson commented on HDFS-13287: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16788 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/16788/]) Revert "HDFS-13287. TestINodeFile#testGetBlockType results in NPE when (weichiu: rev d3ac516665b551ff0f9b55b668e2c9fca9a3fde1) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java > TestINodeFile#testGetBlockType results in NPE when run alone > > > Key: HDFS-13287 > URL: https://issues.apache.org/jira/browse/HDFS-13287 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Virajith Jalaparti >Assignee: Virajith Jalaparti >Priority: Minor > Fix For: 3.3.0, 3.2.1, 3.1.3 > > Attachments: HDFS-13287.01.patch > > > When TestINodeFile#testGetBlockType is run by itself, it results in the > following error: > {code:java} > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.218 > s <<< FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestINodeFile > [ERROR] > testGetBlockType(org.apache.hadoop.hdfs.server.namenode.TestINodeFile) Time > elapsed: 0.023 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getPolicyInfoByID(ErasureCodingPolicyManager.java:220) > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getByID(ErasureCodingPolicyManager.java:208) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile$HeaderFormat.getBlockLayoutRedundancy(INodeFile.java:207) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile.(INodeFile.java:266) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.createStripedINodeFile(TestINodeFile.java:112) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.testGetBlockType(TestINodeFile.java:299) > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13287) TestINodeFile#testGetBlockType results in NPE when run alone
[ https://issues.apache.org/jira/browse/HDFS-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867436#comment-16867436 ] Akira Ajisaka commented on HDFS-13287: -- After this commit, compile error occurred. Hi [~jojochuang], would you fix it? {noformat} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project hadoop-hdfs: Compilation failure [ERROR] /(snip)/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java:[299,50] unreported exception java.io.IOException; must be caught or declared to be thrown {noformat} > TestINodeFile#testGetBlockType results in NPE when run alone > > > Key: HDFS-13287 > URL: https://issues.apache.org/jira/browse/HDFS-13287 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Virajith Jalaparti >Assignee: Virajith Jalaparti >Priority: Minor > Fix For: 3.3.0, 3.2.1, 3.1.3 > > Attachments: HDFS-13287.01.patch > > > When TestINodeFile#testGetBlockType is run by itself, it results in the > following error: > {code:java} > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.218 > s <<< FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestINodeFile > [ERROR] > testGetBlockType(org.apache.hadoop.hdfs.server.namenode.TestINodeFile) Time > elapsed: 0.023 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getPolicyInfoByID(ErasureCodingPolicyManager.java:220) > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getByID(ErasureCodingPolicyManager.java:208) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile$HeaderFormat.getBlockLayoutRedundancy(INodeFile.java:207) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile.(INodeFile.java:266) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.createStripedINodeFile(TestINodeFile.java:112) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.testGetBlockType(TestINodeFile.java:299) > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13287) TestINodeFile#testGetBlockType results in NPE when run alone
[ https://issues.apache.org/jira/browse/HDFS-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867225#comment-16867225 ] Wei-Chiu Chuang commented on HDFS-13287: +1 the patch still applies. Will commit it > TestINodeFile#testGetBlockType results in NPE when run alone > > > Key: HDFS-13287 > URL: https://issues.apache.org/jira/browse/HDFS-13287 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Virajith Jalaparti >Assignee: Virajith Jalaparti >Priority: Minor > Attachments: HDFS-13287.01.patch > > > When TestINodeFile#testGetBlockType is run by itself, it results in the > following error: > {code:java} > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.218 > s <<< FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestINodeFile > [ERROR] > testGetBlockType(org.apache.hadoop.hdfs.server.namenode.TestINodeFile) Time > elapsed: 0.023 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getPolicyInfoByID(ErasureCodingPolicyManager.java:220) > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getByID(ErasureCodingPolicyManager.java:208) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile$HeaderFormat.getBlockLayoutRedundancy(INodeFile.java:207) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile.(INodeFile.java:266) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.createStripedINodeFile(TestINodeFile.java:112) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.testGetBlockType(TestINodeFile.java:299) > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13287) TestINodeFile#testGetBlockType results in NPE when run alone
[ https://issues.apache.org/jira/browse/HDFS-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867226#comment-16867226 ] Hudson commented on HDFS-13287: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16786 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/16786/]) HDFS-13287. TestINodeFile#testGetBlockType results in NPE when run (weichiu: rev a1c3868c4f027adcb814b30d842e60d1f94326ea) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java > TestINodeFile#testGetBlockType results in NPE when run alone > > > Key: HDFS-13287 > URL: https://issues.apache.org/jira/browse/HDFS-13287 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Virajith Jalaparti >Assignee: Virajith Jalaparti >Priority: Minor > Attachments: HDFS-13287.01.patch > > > When TestINodeFile#testGetBlockType is run by itself, it results in the > following error: > {code:java} > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.218 > s <<< FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestINodeFile > [ERROR] > testGetBlockType(org.apache.hadoop.hdfs.server.namenode.TestINodeFile) Time > elapsed: 0.023 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getPolicyInfoByID(ErasureCodingPolicyManager.java:220) > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getByID(ErasureCodingPolicyManager.java:208) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile$HeaderFormat.getBlockLayoutRedundancy(INodeFile.java:207) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile.(INodeFile.java:266) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.createStripedINodeFile(TestINodeFile.java:112) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.testGetBlockType(TestINodeFile.java:299) > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13287) TestINodeFile#testGetBlockType results in NPE when run alone
[ https://issues.apache.org/jira/browse/HDFS-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401643#comment-16401643 ] Ewan Higgs commented on HDFS-13287: --- Tested. LGTM. Could also do this in a {{@Before}} function like so any future function is covered: {quote}{color:#808000}@Before {color}{color:#80}public void {color}setup() { ErasureCodingPolicyManager.getInstance().init({color:#80}new {color}Configuration()); } {quote} > TestINodeFile#testGetBlockType results in NPE when run alone > > > Key: HDFS-13287 > URL: https://issues.apache.org/jira/browse/HDFS-13287 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Virajith Jalaparti >Assignee: Virajith Jalaparti >Priority: Minor > Attachments: HDFS-13287.01.patch > > > When TestINodeFile#testGetBlockType is run by itself, it results in the > following error: > {code:java} > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.218 > s <<< FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestINodeFile > [ERROR] > testGetBlockType(org.apache.hadoop.hdfs.server.namenode.TestINodeFile) Time > elapsed: 0.023 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getPolicyInfoByID(ErasureCodingPolicyManager.java:220) > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getByID(ErasureCodingPolicyManager.java:208) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile$HeaderFormat.getBlockLayoutRedundancy(INodeFile.java:207) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile.(INodeFile.java:266) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.createStripedINodeFile(TestINodeFile.java:112) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.testGetBlockType(TestINodeFile.java:299) > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13287) TestINodeFile#testGetBlockType results in NPE when run alone
[ https://issues.apache.org/jira/browse/HDFS-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399807#comment-16399807 ] genericqa commented on HDFS-13287: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m 4s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 51s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 2s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 8s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 4s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 10s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 79m 15s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 24s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}133m 7s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks | | | hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d4cc50f | | JIRA Issue | HDFS-13287 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12914605/HDFS-13287.01.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 299298489e7e 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / e840b4a | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23495/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/23495/testReport/ | | Max. process+thread count | 3405 (vs. ulimit of 1) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-
[jira] [Commented] (HDFS-13287) TestINodeFile#testGetBlockType results in NPE when run alone
[ https://issues.apache.org/jira/browse/HDFS-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399655#comment-16399655 ] Virajith Jalaparti commented on HDFS-13287: --- The error results because {{ErasureCodingPolicyManager#getInstance}} is called (creates a new instance of {{ErasureCodingPolicyManager}}) without a call to {{ErasureCodingPolicyManager#init}} afterwards. The NPE doesn't occur when {{TestINodeFile}} is run as a whole as one of the other tests initializes {{ErasureCodingPolicyManager.instance}}. Attached patch ( [^HDFS-13287.01.patch]) fixes this issue. [~andrew.wang], [~ehiggs], can you take a look at this? > TestINodeFile#testGetBlockType results in NPE when run alone > > > Key: HDFS-13287 > URL: https://issues.apache.org/jira/browse/HDFS-13287 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Virajith Jalaparti >Assignee: Virajith Jalaparti >Priority: Minor > Attachments: HDFS-13287.01.patch > > > When TestINodeFile#testGetBlockType is run by itself, it results in the > following error: > {code:java} > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.218 > s <<< FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestINodeFile > [ERROR] > testGetBlockType(org.apache.hadoop.hdfs.server.namenode.TestINodeFile) Time > elapsed: 0.023 s <<< ERROR! > java.lang.NullPointerException > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getPolicyInfoByID(ErasureCodingPolicyManager.java:220) > at > org.apache.hadoop.hdfs.server.namenode.ErasureCodingPolicyManager.getByID(ErasureCodingPolicyManager.java:208) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile$HeaderFormat.getBlockLayoutRedundancy(INodeFile.java:207) > at > org.apache.hadoop.hdfs.server.namenode.INodeFile.(INodeFile.java:266) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.createStripedINodeFile(TestINodeFile.java:112) > at > org.apache.hadoop.hdfs.server.namenode.TestINodeFile.testGetBlockType(TestINodeFile.java:299) > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org