[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448781#comment-16448781
]
Íñigo Goiri commented on HDFS-13408:
Thanks [~chris.douglas] for the review and the commit!
Let's
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448680#comment-16448680
]
Hudson commented on HDFS-13408:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14048 (See
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446737#comment-16446737
]
Xiao Liang commented on HDFS-13408:
---
+1 on [^HDFS-13408.004.patch].
> MiniDFSCluster to support being
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446582#comment-16446582
]
Íñigo Goiri commented on HDFS-13408:
The failed unit tests are unrelated.
+1 on
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446574#comment-16446574
]
genericqa commented on HDFS-13408:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446478#comment-16446478
]
Íñigo Goiri commented on HDFS-13408:
+1 on [^HDFS-13408.004.patch].
Let's see if the unit tests pass.
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446457#comment-16446457
]
Chris Douglas commented on HDFS-13408:
--
For completeness, added v004 which considers a {{null}} base
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446454#comment-16446454
]
Chris Douglas commented on HDFS-13408:
--
bq. there should be file read/write conflicts between test
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445972#comment-16445972
]
Íñigo Goiri commented on HDFS-13408:
The Yetus run for [^HDFS-13408.002.patch] seems good; the unit
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445615#comment-16445615
]
Xiao Liang commented on HDFS-13408:
---
Thank you [~giovanni.fumarola] for the suggestion, and thank you
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445400#comment-16445400
]
genericqa commented on HDFS-13408:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445134#comment-16445134
]
Íñigo Goiri commented on HDFS-13408:
[~surmountian], can you take a look at the failed unit tests?
>
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445064#comment-16445064
]
genericqa commented on HDFS-13408:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444988#comment-16444988
]
Íñigo Goiri commented on HDFS-13408:
bq. Should I change it back?
As long as branch-2.9 supports it,
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444963#comment-16444963
]
Chris Douglas commented on HDFS-13408:
--
bq. we are changing to logger here; is it fine to do it here
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444946#comment-16444946
]
Íñigo Goiri commented on HDFS-13408:
Thanks [~chris.douglas], I think that [^HDFS-13408.001.patch] is
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444921#comment-16444921
]
Chris Douglas commented on HDFS-13408:
--
Sorry for the delay. Would the failing tests also fail to run
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440124#comment-16440124
]
Giovanni Matteo Fumarola commented on HDFS-13408:
-
Thanks [~surmountian] for the patch.
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429182#comment-16429182
]
Íñigo Goiri commented on HDFS-13408:
The Yetus run for [^HDFS-13408.000.patch] was clean.
This change
[
https://issues.apache.org/jira/browse/HDFS-13408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429157#comment-16429157
]
genericqa commented on HDFS-13408:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
20 matches
Mail list logo
