[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188607#comment-17188607
]
Íñigo Goiri commented on HDFS-13443:
As discussed in parallel, adding a subcluster (a NameNode) to a
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187783#comment-17187783
]
GANG LIAO commented on HDFS-13443:
--
If the system decides to repartition part of the mount table as the
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871578#comment-16871578
]
Hudson commented on HDFS-13443:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16813 (See
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724327#comment-16724327
]
Íñigo Goiri commented on HDFS-13443:
TestNamenodeCapacityReport seems unrelated.
+1 on
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723884#comment-16723884
]
Surendra Singh Lilhore commented on HDFS-13443:
---
+1 for the patch
{quote}As
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723781#comment-16723781
]
Yiqun Lin commented on HDFS-13443:
--
LGTM +1. Thanks [~arshad.mohammad]!
{quote}
I feel default value
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722972#comment-16722972
]
Hadoop QA commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722861#comment-16722861
]
Mohammad Arshad commented on HDFS-13443:
Thanks [~linyiqun] for the reviews. Handled the comment
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722655#comment-16722655
]
Yiqun Lin commented on HDFS-13443:
--
[~arshad.mohammad], actually I'm not mean we have to remove the
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720971#comment-16720971
]
Yiqun Lin commented on HDFS-13443:
--
{quote}After expireAfterWrite time cache entries are marked removed
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720937#comment-16720937
]
Mohammad Arshad commented on HDFS-13443:
{quote}This will be done inside LoadingCache since we
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720910#comment-16720910
]
Yiqun Lin commented on HDFS-13443:
--
Thanks [~arshad.mohammad] for updating the patch! Almost looks good
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718919#comment-16718919
]
Hadoop QA commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718683#comment-16718683
]
Mohammad Arshad commented on HDFS-13443:
added patch for trunk and branch HDFS-13891
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718519#comment-16718519
]
Mohammad Arshad commented on HDFS-13443:
{quote}The refresh API will only makes sense in the
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714298#comment-16714298
]
Surendra Singh Lilhore commented on HDFS-13443:
---
{quote}I'm not sure I would consider this
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713146#comment-16713146
]
Íñigo Goiri commented on HDFS-13443:
{quote}
I feel default value for this property should be true
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712698#comment-16712698
]
Yiqun Lin commented on HDFS-13443:
--
Revisiting this JIRA, I am thinking one thing: The refresh API will
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712571#comment-16712571
]
Surendra Singh Lilhore commented on HDFS-13443:
---
Thanks [~arshad.mohammad] for the patch.
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712445#comment-16712445
]
Hadoop QA commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712340#comment-16712340
]
Mohammad Arshad commented on HDFS-13443:
Handled above two comments.
Thanks [~elgoiri] for the
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711794#comment-16711794
]
Íñigo Goiri commented on HDFS-13443:
Thanks [~arshad.mohammad] for tackling my comments.
Two minor
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711327#comment-16711327
]
Hadoop QA commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1670#comment-1670
]
Mohammad Arshad commented on HDFS-13443:
* Extracted router.getSubclusterResolver() instanceof
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710428#comment-16710428
]
Íñigo Goiri commented on HDFS-13443:
[^HDFS-13443-014.patch] looks prety much it.
*
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709857#comment-16709857
]
Hadoop QA commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709680#comment-16709680
]
Mohammad Arshad commented on HDFS-13443:
Fixed review comments.
> RBF: Update mount table cache
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707747#comment-16707747
]
Íñigo Goiri commented on HDFS-13443:
Thanks [~arshad.mohammad] for [^HDFS-13443-013.patch].
*
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707067#comment-16707067
]
Hadoop QA commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706851#comment-16706851
]
Mohammad Arshad commented on HDFS-13443:
As i am using default state store, zkAddress is
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705088#comment-16705088
]
Íñigo Goiri commented on HDFS-13443:
After going through [^HDFS-13443-012.patch], I've noticed that
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704832#comment-16704832
]
Hadoop QA commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704633#comment-16704633
]
Mohammad Arshad commented on HDFS-13443:
patch rebased.
> RBF: Update mount table cache
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703499#comment-16703499
]
Íñigo Goiri commented on HDFS-13443:
I would like to get this one in before HDFS-14079 so we can get
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697043#comment-16697043
]
Hadoop QA commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669007#comment-16669007
]
Íñigo Goiri commented on HDFS-13443:
Can you rebase this?
> RBF: Update mount table cache
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608500#comment-16608500
]
Hadoop QA commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484322#comment-16484322
]
genericqa commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473405#comment-16473405
]
genericqa commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473353#comment-16473353
]
Mohammad Arshad commented on HDFS-13443:
Thanks [~linyiqun] and [~vinayrpet] for reviews.
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471826#comment-16471826
]
Vinayakumar B commented on HDFS-13443:
--
Hi [~arshad.mohammad], thanks for much required patch. Please
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471642#comment-16471642
]
Yiqun Lin commented on HDFS-13443:
--
Thanks [~arshad.mohammad] for updating the patch.
Almost looks good
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471266#comment-16471266
]
genericqa commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470905#comment-16470905
]
Mohammad Arshad commented on HDFS-13443:
Re-based the patch.
> RBF: Update mount table cache
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470340#comment-16470340
]
genericqa commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470097#comment-16470097
]
Mohammad Arshad commented on HDFS-13443:
Thanks [~linyiqun] for your review. Addressed all the
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463660#comment-16463660
]
Yiqun Lin commented on HDFS-13443:
--
Some review comments from me (reviewed based on v007 patch):
Majors:
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463307#comment-16463307
]
Yiqun Lin commented on HDFS-13443:
--
Will give a try for review today, :).
> RBF: Update mount table
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462888#comment-16462888
]
Íñigo Goiri commented on HDFS-13443:
[^HDFS-13443.007.patch] LGTM and the failed unit tests are
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461959#comment-16461959
]
genericqa commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461843#comment-16461843
]
Mohammad Arshad commented on HDFS-13443:
Thanks [~elgoiri] for the reviews. Fixed all above
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461357#comment-16461357
]
Íñigo Goiri commented on HDFS-13443:
Other than the check style issues this looks good.
The unit tests
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460955#comment-16460955
]
genericqa commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460723#comment-16460723
]
Mohammad Arshad commented on HDFS-13443:
Addressed all the comments, except above two comments,
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454512#comment-16454512
]
Mohammad Arshad commented on HDFS-13443:
bq. I think we need some metric to make sure we run the
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452757#comment-16452757
]
Íñigo Goiri commented on HDFS-13443:
[~arshad.mohammad], thanks for [^HDFS-13443.005.patch]; te new
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451664#comment-16451664
]
genericqa commented on HDFS-13443:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451611#comment-16451611
]
Mohammad Arshad commented on HDFS-13443:
Addressed all the comments, submitted new patch
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451371#comment-16451371
]
genericqa commented on HDFS-13443:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450412#comment-16450412
]
Íñigo Goiri commented on HDFS-13443:
Thanks for [^HDFS-13443.004.patch]. Following up.
Regarding #1,
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449967#comment-16449967
]
Mohammad Arshad commented on HDFS-13443:
Thanks [~elgoiri] for your review comments.
# Regarding
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448477#comment-16448477
]
Íñigo Goiri commented on HDFS-13443:
Thanks [~arshad.mohammad] for [^HDFS-13443.003.patch].
A couple
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448253#comment-16448253
]
genericqa commented on HDFS-13443:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448020#comment-16448020
]
genericqa commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447822#comment-16447822
]
genericqa commented on HDFS-13443:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447820#comment-16447820
]
Mohammad Arshad commented on HDFS-13443:
bq. Aren't we having a cascading effect that will never
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447805#comment-16447805
]
Mohammad Arshad commented on HDFS-13443:
Addressed all the comments, submitting new patch
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441217#comment-16441217
]
Íñigo Goiri commented on HDFS-13443:
Thanks [~arshad.mohammad], do you mind adding a trunk patch too?
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440853#comment-16440853
]
Mohammad Arshad commented on HDFS-13443:
Submitting new patch HDFS-13443-branch-2.002.patch for
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440370#comment-16440370
]
Mohammad Arshad commented on HDFS-13443:
I submitted the patch.
> RBF: Update mount table cache
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439673#comment-16439673
]
Íñigo Goiri commented on HDFS-13443:
[~arshad.mohammad], this would only be then for the local Router,
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439209#comment-16439209
]
Mohammad Arshad commented on HDFS-13443:
All those issues are completely different from this
[
https://issues.apache.org/jira/browse/HDFS-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437465#comment-16437465
]
Íñigo Goiri commented on HDFS-13443:
Thanks [~arshad.mohammad] for reporting.
The ones related might
73 matches
Mail list logo