[
https://issues.apache.org/jira/browse/HDFS-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450274#comment-16450274
]
Íñigo Goiri commented on HDFS-13490:
Thank you [~linyiqun] for the review and the commit.
> RBF: Fix
[
https://issues.apache.org/jira/browse/HDFS-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449236#comment-16449236
]
Hudson commented on HDFS-13490:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14054 (See
[
https://issues.apache.org/jira/browse/HDFS-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449225#comment-16449225
]
Yiqun Lin commented on HDFS-13490:
--
LGTM, +1. Committing this.
> RBF: Fix setSafeMode in the Router
>
[
https://issues.apache.org/jira/browse/HDFS-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448515#comment-16448515
]
genericqa commented on HDFS-13490:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448376#comment-16448376
]
Íñigo Goiri commented on HDFS-13490:
I tried to put it into TestRouterRpc but then we need to create
[
https://issues.apache.org/jira/browse/HDFS-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447511#comment-16447511
]
Yiqun Lin commented on HDFS-13490:
--
Patch looks good to me overrall. One comment: Can we move the test in
[
https://issues.apache.org/jira/browse/HDFS-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446601#comment-16446601
]
genericqa commented on HDFS-13490:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446577#comment-16446577
]
Íñigo Goiri commented on HDFS-13490:
We might be able to put the unit test in some other test that
