[jira] [Commented] (HDFS-13530) NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
[ https://issues.apache.org/jira/browse/HDFS-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867712#comment-16867712 ] Ayush Saxena commented on HDFS-13530: - HDFS-13816 seems to have fixed it? > NameNode: Fix NullPointerException when getQuotaUsageInt() invoked > -- > > Key: HDFS-13530 > URL: https://issues.apache.org/jira/browse/HDFS-13530 > Project: Hadoop HDFS > Issue Type: Bug > Components: federation, namenode >Reporter: liuhongtong >Assignee: liuhongtong >Priority: Major > Attachments: HDFS-13530.001.patch > > > If the directory is nonexistent, getQuotaUsage rpc call will run into > NullPointerException throwed by > FSDirStatAndListingOp.getQuotaUsageInt() . > I think FSDirStatAndListingOp.getQuotaUsageInt() should throw > FileNotFoundException when the directory is nonexistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13530) NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
[
https://issues.apache.org/jira/browse/HDFS-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867233#comment-16867233
]
Hadoop QA commented on HDFS-13530:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HDFS-13530 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-13530 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12922208/HDFS-13530.001.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/27000/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
> --
>
> Key: HDFS-13530
> URL: https://issues.apache.org/jira/browse/HDFS-13530
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: federation, namenode
>Reporter: liuhongtong
>Assignee: liuhongtong
>Priority: Major
> Attachments: HDFS-13530.001.patch
>
>
> If the directory is nonexistent, getQuotaUsage rpc call will run into
> NullPointerException throwed by
> FSDirStatAndListingOp.getQuotaUsageInt() .
> I think FSDirStatAndListingOp.getQuotaUsageInt() should throw
> FileNotFoundException when the directory is nonexistent.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13530) NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
[ https://issues.apache.org/jira/browse/HDFS-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867231#comment-16867231 ] Wei-Chiu Chuang commented on HDFS-13530: The patch stalled for over a year, but it still applies cleanly. A test would be great but the fix itself is good. How about we commit the fix and file another jira to add a test? > NameNode: Fix NullPointerException when getQuotaUsageInt() invoked > -- > > Key: HDFS-13530 > URL: https://issues.apache.org/jira/browse/HDFS-13530 > Project: Hadoop HDFS > Issue Type: Bug > Components: federation, namenode >Reporter: liuhongtong >Assignee: liuhongtong >Priority: Major > Attachments: HDFS-13530.001.patch > > > If the directory is nonexistent, getQuotaUsage rpc call will run into > NullPointerException throwed by > FSDirStatAndListingOp.getQuotaUsageInt() . > I think FSDirStatAndListingOp.getQuotaUsageInt() should throw > FileNotFoundException when the directory is nonexistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13530) NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
[ https://issues.apache.org/jira/browse/HDFS-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469654#comment-16469654 ] Xiaoyu Yao commented on HDFS-13530: --- Thanks [~liuhongtong] for working on this. The fix LGTM. Agree with [~ajayydv] that we should add a unit test for this. > NameNode: Fix NullPointerException when getQuotaUsageInt() invoked > -- > > Key: HDFS-13530 > URL: https://issues.apache.org/jira/browse/HDFS-13530 > Project: Hadoop HDFS > Issue Type: Bug > Components: federation, namenode >Reporter: liuhongtong >Priority: Major > Attachments: HDFS-13530.001.patch > > > If the directory is nonexistent, getQuotaUsage rpc call will run into > NullPointerException throwed by > FSDirStatAndListingOp.getQuotaUsageInt() . > I think FSDirStatAndListingOp.getQuotaUsageInt() should throw > FileNotFoundException when the directory is nonexistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13530) NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
[ https://issues.apache.org/jira/browse/HDFS-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466267#comment-16466267 ] Ajay Kumar commented on HDFS-13530: --- [~liuhongtong] thanks for filing the jira and submitting the patch. mind adding a test case? > NameNode: Fix NullPointerException when getQuotaUsageInt() invoked > -- > > Key: HDFS-13530 > URL: https://issues.apache.org/jira/browse/HDFS-13530 > Project: Hadoop HDFS > Issue Type: Bug > Components: federation, namenode >Reporter: liuhongtong >Priority: Major > Attachments: HDFS-13530.001.patch > > > If the directory is nonexistent, getQuotaUsage rpc call will run into > NullPointerException throwed by > FSDirStatAndListingOp.getQuotaUsageInt() . > I think FSDirStatAndListingOp.getQuotaUsageInt() should throw > FileNotFoundException when the directory is nonexistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13530) NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
[
https://issues.apache.org/jira/browse/HDFS-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465516#comment-16465516
]
liuhongtong commented on HDFS-13530:
{code:java}
[ERROR] TestWebHdfsTimeouts.testTwoStepWriteConnectTimeout:245 expected timeout
[ERROR] TestWebHdfsTimeouts.testTwoStepWriteConnectTimeout:245 expected timeout
[ERROR] Errors: [ERROR]
TestDataNodeVolumeFailureReporting.testVolFailureStatsPreservedOnNNRestart:283
? Timeout [INFO] [ERROR] Tests run: 5557, Failures: 10, Errors: 1, Skipped: 21
{code}
I'm innocent, and this unit test failure is irrelevant with the modified code.
> NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
> --
>
> Key: HDFS-13530
> URL: https://issues.apache.org/jira/browse/HDFS-13530
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: federation, namenode
>Reporter: liuhongtong
>Priority: Major
> Attachments: HDFS-13530.001.patch
>
>
> If the directory is nonexistent, getQuotaUsage rpc call will run into
> NullPointerException throwed by
> FSDirStatAndListingOp.getQuotaUsageInt() .
> I think FSDirStatAndListingOp.getQuotaUsageInt() should throw
> FileNotFoundException when the directory is nonexistent.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13530) NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
[
https://issues.apache.org/jira/browse/HDFS-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465463#comment-16465463
]
genericqa commented on HDFS-13530:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
56s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 7s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 43s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 1 new + 18 unchanged - 0 fixed = 19 total (was 18) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 17s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}107m 35s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}163m 47s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA |
| | hadoop.hdfs.web.TestWebHdfsTimeouts |
| | hadoop.hdfs.server.namenode.TestReencryptionWithKMS |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDFS-13530 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12922208/HDFS-13530.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux f7f0f41af893 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20
11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / e9159db |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
[jira] [Commented] (HDFS-13530) NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
[ https://issues.apache.org/jira/browse/HDFS-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465409#comment-16465409 ] maobaolong commented on HDFS-13530: --- [~liuhongtong] Thank you, this really worth to fix as soon as possible. BTW, you can assign this ticket to yourself. > NameNode: Fix NullPointerException when getQuotaUsageInt() invoked > -- > > Key: HDFS-13530 > URL: https://issues.apache.org/jira/browse/HDFS-13530 > Project: Hadoop HDFS > Issue Type: Bug > Components: federation, namenode >Reporter: liuhongtong >Priority: Major > Attachments: HDFS-13530.001.patch > > > If the directory is nonexistent, getQuotaUsage rpc call will run into > NullPointerException throwed by > FSDirStatAndListingOp.getQuotaUsageInt() . > I think FSDirStatAndListingOp.getQuotaUsageInt() should throw > FileNotFoundException when the directory is nonexistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
