[jira] [Commented] (HDFS-13577) RBF: Failed mount point operations, returns wrong exit code.
[ https://issues.apache.org/jira/browse/HDFS-13577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886280#comment-16886280 ] Íñigo Goiri commented on HDFS-13577: Thanks [~ayushtkn] for reviving this. I closed the JIRA as it is covered by HDFS-13815. > RBF: Failed mount point operations, returns wrong exit code. > > > Key: HDFS-13577 > URL: https://issues.apache.org/jira/browse/HDFS-13577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Y. SREENIVASULU REDDY >Assignee: Dibyendu Karmakar >Priority: Major > Labels: RBF > > If client is performed add mount point with some special character, mount > point add is failed. > And prints the message like > {noformat} > 18/05/17 09:58:34 DEBUG ipc.ProtobufRpcEngine: Call: addMountTableEntry took > 19ms Cannot add mount point /testSpecialCharMountPointCreation/test/ > {noformat} > In the above case it should return the exist code is non zero value. > {code:java|title=RouterAdmin.java|borderStyle=solid} > Exception debugException = null; > exitCode = 0; > try { > if ("-add".equals(cmd)) { > if (addMount(argv, i)) { > System.out.println("Successfully added mount point " + argv[i]); > } > {code} > we should handle this kind of cases also. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13577) RBF: Failed mount point operations, returns wrong exit code.
[ https://issues.apache.org/jira/browse/HDFS-13577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886154#comment-16886154 ] Ayush Saxena commented on HDFS-13577: - This seems fixed :: {code:java} if (!added) { System.err.println("Cannot add mount point " + mount); } return added; {code} The said message shall be printed when added is false, and same false is returned. Then :: {code:java} if (addMount(argv, i)) { System.out.println("Successfully added mount point " + argv[i]); } else { exitCode = -1; } {code} Here addMount(argv,i) receives response as False, Moves to else, sets exit code to -1. Verified, Seems not an issue now. Can resolve this now!!! > RBF: Failed mount point operations, returns wrong exit code. > > > Key: HDFS-13577 > URL: https://issues.apache.org/jira/browse/HDFS-13577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Y. SREENIVASULU REDDY >Assignee: Dibyendu Karmakar >Priority: Major > Labels: RBF > > If client is performed add mount point with some special character, mount > point add is failed. > And prints the message like > {noformat} > 18/05/17 09:58:34 DEBUG ipc.ProtobufRpcEngine: Call: addMountTableEntry took > 19ms Cannot add mount point /testSpecialCharMountPointCreation/test/ > {noformat} > In the above case it should return the exist code is non zero value. > {code:java|title=RouterAdmin.java|borderStyle=solid} > Exception debugException = null; > exitCode = 0; > try { > if ("-add".equals(cmd)) { > if (addMount(argv, i)) { > System.out.println("Successfully added mount point " + argv[i]); > } > {code} > we should handle this kind of cases also. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13577) RBF: Failed mount point operations, returns wrong exit code.
[ https://issues.apache.org/jira/browse/HDFS-13577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608496#comment-16608496 ] Brahma Reddy Battula commented on HDFS-13577: - HDFS-13815 is addressed this issue, can you guys cross check once..? > RBF: Failed mount point operations, returns wrong exit code. > > > Key: HDFS-13577 > URL: https://issues.apache.org/jira/browse/HDFS-13577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Y. SREENIVASULU REDDY >Assignee: Dibyendu Karmakar >Priority: Major > Labels: RBF > > If client is performed add mount point with some special character, mount > point add is failed. > And prints the message like > {noformat} > 18/05/17 09:58:34 DEBUG ipc.ProtobufRpcEngine: Call: addMountTableEntry took > 19ms Cannot add mount point /testSpecialCharMountPointCreation/test/ > {noformat} > In the above case it should return the exist code is non zero value. > {code:java|title=RouterAdmin.java|borderStyle=solid} > Exception debugException = null; > exitCode = 0; > try { > if ("-add".equals(cmd)) { > if (addMount(argv, i)) { > System.out.println("Successfully added mount point " + argv[i]); > } > {code} > we should handle this kind of cases also. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13577) RBF: Failed mount point operations, returns wrong exit code.
[ https://issues.apache.org/jira/browse/HDFS-13577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487594#comment-16487594 ] Íñigo Goiri commented on HDFS-13577: I think we should add a sanitize for the input either in the CLI side or the server. I don't have a preference but I'd like to be consistent with the rest of HDFS; is there any sanitation for inputs there? > RBF: Failed mount point operations, returns wrong exit code. > > > Key: HDFS-13577 > URL: https://issues.apache.org/jira/browse/HDFS-13577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Y. SREENIVASULU REDDY >Assignee: Dibyendu Karmakar >Priority: Major > Labels: RBF > > If client is performed add mount point with some special character, mount > point add is failed. > And prints the message like > {noformat} > 18/05/17 09:58:34 DEBUG ipc.ProtobufRpcEngine: Call: addMountTableEntry took > 19ms Cannot add mount point /testSpecialCharMountPointCreation/test/ > {noformat} > In the above case it should return the exist code is non zero value. > {code:java|title=RouterAdmin.java|borderStyle=solid} > Exception debugException = null; > exitCode = 0; > try { > if ("-add".equals(cmd)) { > if (addMount(argv, i)) { > System.out.println("Successfully added mount point " + argv[i]); > } > {code} > we should handle this kind of cases also. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13577) RBF: Failed mount point operations, returns wrong exit code.
[ https://issues.apache.org/jira/browse/HDFS-13577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481832#comment-16481832 ] Dibyendu Karmakar commented on HDFS-13577: -- [~sreenivasulureddy] Thanks for reporting the issue. While adding mount point with special character (e.g. char created by "(char)1" in java), at StateStoreZookeeperImpl# writeNode() zkManager.create(znode) is throwing exception {noformat} java.lang.IllegalArgumentException: Invalid path string "/hdfs-federation/MountTable/0SLASH0test-addmounttable" caused by invalid charater @53{noformat} in this case AddMountTableEntryResponse status is returned as "false". At RouterAdmin#run() if any exception occurs then only we are returning exitCode = -1. We can either check if the mount path is valid and throw IllegalArgumentException or If response status is false we can return exitCode = -1. [~elgoiri] any suggestion? > RBF: Failed mount point operations, returns wrong exit code. > > > Key: HDFS-13577 > URL: https://issues.apache.org/jira/browse/HDFS-13577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Y. SREENIVASULU REDDY >Priority: Major > Labels: RBF > > If client is performed add mount point with some special character, mount > point add is failed. > And prints the message like > {noformat} > 18/05/17 09:58:34 DEBUG ipc.ProtobufRpcEngine: Call: addMountTableEntry took > 19ms Cannot add mount point /testSpecialCharMountPointCreation/test/ > {noformat} > In the above case it should return the exist code is non zero value. > {code:java|title=RouterAdmin.java|borderStyle=solid} > Exception debugException = null; > exitCode = 0; > try { > if ("-add".equals(cmd)) { > if (addMount(argv, i)) { > System.out.println("Successfully added mount point " + argv[i]); > } > {code} > we should handle this kind of cases also. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org