[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492968#comment-16492968
]
Hudson commented on HDFS-13591:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14304 (See
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492924#comment-16492924
]
genericqa commented on HDFS-13591:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492958#comment-16492958
]
Íñigo Goiri commented on HDFS-13591:
Handling the \n\r combinations in these cases is hard to get.
I
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492877#comment-16492877
]
Anbang Hu commented on HDFS-13591:
--
Thanks [~elgoiri] for the review and suggestion. New patch
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492861#comment-16492861
]
Anbang Hu commented on HDFS-13591:
--
bao.toString() will contain "\r\r\n" on Windows. Not sure it's a
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492872#comment-16492872
]
Íñigo Goiri commented on HDFS-13591:
I mean something like this:
{code}
assertTrue("Error message
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492846#comment-16492846
]
Íñigo Goiri commented on HDFS-13591:
I would include {{bao.toString()}} on the message.
>
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491930#comment-16491930
]
genericqa commented on HDFS-13591:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491897#comment-16491897
]
Anbang Hu commented on HDFS-13591:
--
I misunderstood your point [~lukmajercak]. "contains" is indeed a
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491895#comment-16491895
]
Íñigo Goiri commented on HDFS-13591:
The message for assertEquals is usually easier to manage than
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491850#comment-16491850
]
Anbang Hu commented on HDFS-13591:
--
[~lukmajercak] doing .startsWith/contains might just be cleaner than
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481399#comment-16481399
]
Íñigo Goiri commented on HDFS-13591:
This is similar to what [~giovanni.fumarola] found in YARN-8327.
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481359#comment-16481359
]
Lukas Majercak commented on HDFS-13591:
---
Should we do .startsWith/contains ?
>
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480860#comment-16480860
]
Íñigo Goiri commented on HDFS-13591:
I'm not sure this is the right fix, hardcoding \r\r\n seems like
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480423#comment-16480423
]
genericqa commented on HDFS-13591:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480222#comment-16480222
]
Anbang Hu commented on HDFS-13591:
--
According to
*
16 matches
Mail list logo
