[jira] [Commented] (HDFS-13611) Unsafe use of Text as a ConcurrentHashMap key in PBHelperClient

2018-05-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489426#comment-16489426 ] Hudson commented on HDFS-13611: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14283 (See

[jira] [Commented] (HDFS-13611) Unsafe use of Text as a ConcurrentHashMap key in PBHelperClient

2018-05-23 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488397#comment-16488397 ] Xiao Chen commented on HDFS-13611: -- Good catch and thanks for the review Todd! > Unsafe use of Text as a

[jira] [Commented] (HDFS-13611) Unsafe use of Text as a ConcurrentHashMap key in PBHelperClient

2018-05-23 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487967#comment-16487967 ] genericqa commented on HDFS-13611: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13611) Unsafe use of Text as a ConcurrentHashMap key in PBHelperClient

2018-05-23 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487867#comment-16487867 ] Todd Lipcon commented on HDFS-13611: +1, looks good. While we're at it, we could reduce one extra

[jira] [Commented] (HDFS-13611) Unsafe use of Text as a ConcurrentHashMap key in PBHelperClient

2018-05-23 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487864#comment-16487864 ] Andrew Wang commented on HDFS-13611: Even simpler patch attached, if we make a copy of the Text for

[jira] [Commented] (HDFS-13611) Unsafe use of Text as a ConcurrentHashMap key in PBHelperClient

2018-05-23 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487849#comment-16487849 ] Andrew Wang commented on HDFS-13611: Simple patch attached, getFixedByteString(Text) wasn't even