[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499916#comment-16499916
]
Yiqun Lin commented on HDFS-13637:
--
Yeah, good catch and fix, :).
> RBF: Router fails when threadIndex
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498753#comment-16498753
]
Hudson commented on HDFS-13637:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14341 (See
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498731#comment-16498731
]
Íñigo Goiri commented on HDFS-13637:
As this is a pretty critical bugfix, I'm going ahead and
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498584#comment-16498584
]
CR Hota commented on HDFS-13637:
Thanks !
> RBF: Router fails when threadIndex (in ConnectionPool) wraps
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498542#comment-16498542
]
Íñigo Goiri commented on HDFS-13637:
The failed unit tests is flaky and tracked already in
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498525#comment-16498525
]
genericqa commented on HDFS-13637:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497432#comment-16497432
]
Íñigo Goiri commented on HDFS-13637:
There are a bunch of checkstyles in the last Yetus report.
Can
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497414#comment-16497414
]
CR Hota commented on HDFS-13637:
[~elgoiri] Let me know if the final patch looks fine. All comments have
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497243#comment-16497243
]
genericqa commented on HDFS-13637:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497061#comment-16497061
]
genericqa commented on HDFS-13637:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497018#comment-16497018
]
Íñigo Goiri commented on HDFS-13637:
OK, let's add a comment at least.
Probably a link to
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496996#comment-16496996
]
CR Hota commented on HDFS-13637:
Thanks for the feedback. For points 1,2 and 4 we can surely do what you
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496984#comment-16496984
]
Íñigo Goiri commented on HDFS-13637:
Thanks [~crh] for [^HDFS-13637.1.patch].
A couple comments:
*
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495865#comment-16495865
]
genericqa commented on HDFS-13637:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495789#comment-16495789
]
Íñigo Goiri commented on HDFS-13637:
I think you could also use the Whitebox approach.
Otherwise,
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495743#comment-16495743
]
CR Hota commented on HDFS-13637:
To add a unit test for this change would mean exposing clientIndex which
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495521#comment-16495521
]
Íñigo Goiri commented on HDFS-13637:
I guess the out of bounds exception comes from:
{code}
conn =
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495477#comment-16495477
]
CR Hota commented on HDFS-13637:
This is a very critical bug that brings down router and should be
[
https://issues.apache.org/jira/browse/HDFS-13637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494537#comment-16494537
]
Íñigo Goiri commented on HDFS-13637:
We already have 3 new JIRAs on the RPC client topic; we may want
19 matches
Mail list logo
