[jira] [Commented] (HDFS-13686) Add overall metrics for FSNamesystemLock
[ https://issues.apache.org/jira/browse/HDFS-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514490#comment-16514490 ] Hudson commented on HDFS-13686: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14440 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14440/]) HDFS-13686. Add overall metrics for FSNamesystemLock. Contributed by (inigoiri: rev d31a3ce767d3bb68bdbb4f36d45600eab9f4f8b7) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystemLock.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystemLock.java > Add overall metrics for FSNamesystemLock > > > Key: HDFS-13686 > URL: https://issues.apache.org/jira/browse/HDFS-13686 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs, namenode >Reporter: Lukas Majercak >Assignee: Lukas Majercak >Priority: Major > Fix For: 3.2.0, 3.1.1, 3.0.4 > > Attachments: HDFS-13686.000.patch > > > Currently, we have R/W FSNamesystemLock metrics per operation. I'd be useful > to have an overall metric too. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13686) Add overall metrics for FSNamesystemLock
[ https://issues.apache.org/jira/browse/HDFS-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514471#comment-16514471 ] Íñigo Goiri commented on HDFS-13686: Thanks for the review [~xkrogen]. The unit tests passed [here|https://builds.apache.org/job/PreCommit-HDFS-Build/24457/testReport/org.apache.hadoop.hdfs.server.namenode/TestFSNamesystemLock/], the failed unit tests are unrelated (the usual suspects), and the shadedclient has been broken for a couple days. +1 on [^HDFS-13686.000.patch]. Committing. > Add overall metrics for FSNamesystemLock > > > Key: HDFS-13686 > URL: https://issues.apache.org/jira/browse/HDFS-13686 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs, namenode >Reporter: Lukas Majercak >Assignee: Lukas Majercak >Priority: Major > Attachments: HDFS-13686.000.patch > > > Currently, we have R/W FSNamesystemLock metrics per operation. I'd be useful > to have an overall metric too. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13686) Add overall metrics for FSNamesystemLock
[ https://issues.apache.org/jira/browse/HDFS-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514468#comment-16514468 ] Lukas Majercak commented on HDFS-13686: --- Thanks [~xkrogen]. HDFS-11021 looks helpful, I thought about it too. I can definitely take a look at it. > Add overall metrics for FSNamesystemLock > > > Key: HDFS-13686 > URL: https://issues.apache.org/jira/browse/HDFS-13686 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs, namenode >Reporter: Lukas Majercak >Assignee: Lukas Majercak >Priority: Major > Attachments: HDFS-13686.000.patch > > > Currently, we have R/W FSNamesystemLock metrics per operation. I'd be useful > to have an overall metric too. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13686) Add overall metrics for FSNamesystemLock
[ https://issues.apache.org/jira/browse/HDFS-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514455#comment-16514455 ] Erik Krogen commented on HDFS-13686: Nice one, thanks for the work [~lukmajercak]! I have thought about this as well. Patch LGTM. If you're interested in improving these metrics further, I think HDFS-11021 will be a big win. The OTHER category can become a very significant contributing factor to NN lock time and having a more detailed breakdown of which operations are causing that would be very helpful. > Add overall metrics for FSNamesystemLock > > > Key: HDFS-13686 > URL: https://issues.apache.org/jira/browse/HDFS-13686 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs, namenode >Reporter: Lukas Majercak >Assignee: Lukas Majercak >Priority: Major > Attachments: HDFS-13686.000.patch > > > Currently, we have R/W FSNamesystemLock metrics per operation. I'd be useful > to have an overall metric too. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13686) Add overall metrics for FSNamesystemLock
[ https://issues.apache.org/jira/browse/HDFS-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514357#comment-16514357 ] Íñigo Goiri commented on HDFS-13686: [~xkrogen], you added the metrics for the locks. Do you mind reviewing? > Add overall metrics for FSNamesystemLock > > > Key: HDFS-13686 > URL: https://issues.apache.org/jira/browse/HDFS-13686 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs, namenode >Reporter: Lukas Majercak >Assignee: Lukas Majercak >Priority: Major > Attachments: HDFS-13686.000.patch > > > Currently, we have R/W FSNamesystemLock metrics per operation. I'd be useful > to have an overall metric too. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13686) Add overall metrics for FSNamesystemLock
[ https://issues.apache.org/jira/browse/HDFS-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514349#comment-16514349 ] genericqa commented on HDFS-13686: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 39s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 32m 56s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 18s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 22s{color} | {color:green} trunk passed {color} | | {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 4m 3s{color} | {color:red} branch has errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 26s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 2m 27s{color} | {color:red} patch has errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}105m 42s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 28s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}160m 11s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.TestReconstructStripedFile | | | hadoop.hdfs.client.impl.TestBlockReaderLocal | | | hadoop.hdfs.server.datanode.TestDirectoryScanner | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd | | JIRA Issue | HDFS-13686 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12928019/HDFS-13686.000.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 617485b2faf0 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 43d994e | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_171 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/24457/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/24457/testReport/ | | Max. process+thread count | 2945 (vs. ulimit of 1) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/24457/console