[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-10-15 Thread Stephen O'Donnell (Jira)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951877#comment-16951877 ] Stephen O'Donnell commented on HDFS-13693: -- I came across a problem that this change introduces.

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893805#comment-16893805 ] Hadoop QA commented on HDFS-13693: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-23 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891110#comment-16891110 ] Ayush Saxena commented on HDFS-13693: - Yes, The protoc version should be 2.5.0. The error isn't

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-23 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890943#comment-16890943 ] Lisheng Sun commented on HDFS-13693:   {code:java} [ERROR] Failed to execute goal

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890677#comment-16890677 ] Hudson commented on HDFS-13693: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16972 (See

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-22 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890643#comment-16890643 ] Ayush Saxena commented on HDFS-13693: - Committed to trunk. Thanx Everyone for the work here!!! >

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-22 Thread Stephen O'Donnell (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890442#comment-16890442 ] Stephen O'Donnell commented on HDFS-13693: -- No objections from me, please go ahead and commit

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-22 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890362#comment-16890362 ] Ayush Saxena commented on HDFS-13693: - Thanx [~sodonnell] for sharing the facts. I still feels it be

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-22 Thread Stephen O'Donnell (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890285#comment-16890285 ] Stephen O'Donnell commented on HDFS-13693: -- I think this performance improvement is a great

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-22 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890228#comment-16890228 ] Lisheng Sun commented on HDFS-13693: hi [~ayushtkn]  If you think this patch no problem, could you

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-21 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889701#comment-16889701 ] Lisheng Sun commented on HDFS-13693: Thank [~ayushtkn] for your suggestion. I must pay attention to

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-21 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889698#comment-16889698 ] Ayush Saxena commented on HDFS-13693: - You shouldn't have deleted that.. It had people's comments

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-21 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889696#comment-16889696 ] Lisheng Sun commented on HDFS-13693: Thank [~ayushtkn] for your review.  I have delete related PR,

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-21 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889692#comment-16889692 ] Ayush Saxena commented on HDFS-13693: - Thanx [~leosun08] for the ping. Had a look on the latest

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-21 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889669#comment-16889669 ] Lisheng Sun commented on HDFS-13693: [~hexiaoqiao] has +1 for patch in Jira  and [~jojochuang] has +1

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888563#comment-16888563 ] Hadoop QA commented on HDFS-13693: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888554#comment-16888554 ] Hadoop QA commented on HDFS-13693: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-18 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888488#comment-16888488 ] He Xiaoqiao commented on HDFS-13693: Thanks [~leosun08] for your contribution.

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-18 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888483#comment-16888483 ] Lisheng Sun commented on HDFS-13693: [~jojochuang] [~hexiaoqiao] I have updated this patch with

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-15 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885124#comment-16885124 ] Lisheng Sun commented on HDFS-13693: Thank [~hexiaoqiao]  for your suggestion. I think we can  add

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-15 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884962#comment-16884962 ] He Xiaoqiao commented on HDFS-13693: Thanks [~leosun08] for your comments. I believe we both talks

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-15 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884911#comment-16884911 ] Lisheng Sun commented on HDFS-13693: [~hexiaoqiao] Thank you for consideraion.  That INodes

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-14 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884688#comment-16884688 ] He Xiaoqiao commented on HDFS-13693: [~leosun08], Thanks for your comments. Maybe my review comments

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-13 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884379#comment-16884379 ] Lisheng Sun commented on HDFS-13693: Thank [~hexiaoqiao] for your suggestion. {quote}  It seems to

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-13 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884365#comment-16884365 ] Lisheng Sun commented on HDFS-13693: I have updated the patch-004 for trunk. Could you have time to

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884357#comment-16884357 ] Hadoop QA commented on HDFS-13693: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-13 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884329#comment-16884329 ] Lisheng Sun commented on HDFS-13693: Thank [~hunhun] for your comments. {quote}If load fsimage in

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-02 Thread hunshenshi (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876776#comment-16876776 ] hunshenshi commented on HDFS-13693: --- If load fsimage in parallel 

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876207#comment-16876207 ] Hadoop QA commented on HDFS-13693: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-01 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876088#comment-16876088 ] He Xiaoqiao commented on HDFS-13693: Thanks [~leosun08],[~sinago] for the interesting work. Some

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876077#comment-16876077 ] Hadoop QA commented on HDFS-13693: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-07-01 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875987#comment-16875987 ] Lisheng Sun commented on HDFS-13693: Thank [~jojochuang] for your comments.   {quote}I am not a

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-06-22 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870264#comment-16870264 ] Wei-Chiu Chuang commented on HDFS-13693: Thanks [~leosun08] [~sinago] this is really good stuff.

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2019-06-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866281#comment-16866281 ] Hadoop QA commented on HDFS-13693: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2018-06-21 Thread zhouyingchao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519897#comment-16519897 ] zhouyingchao commented on HDFS-13693: - Test the patch against a fsimage of a 70PB 2.4 cluster

[jira] [Commented] (HDFS-13693) Remove unnecessary search in INodeDirectory.addChild during image loading

2018-06-21 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519340#comment-16519340 ] genericqa commented on HDFS-13693: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||