[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-30 Thread Rong Tang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705561#comment-16705561 ] Rong Tang commented on HDFS-14075: -- +1 > NPE while Edit Logging > -- > >

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-29 Thread Vinayakumar B (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704271#comment-16704271 ] Vinayakumar B commented on HDFS-14075: -- +1 > NPE while Edit Logging > -- > >

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-27 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700797#comment-16700797 ] Íñigo Goiri commented on HDFS-14075: [^HDFS-14075-07.patch] LGTM. Not sure if QA run on this version

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-27 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700484#comment-16700484 ] Ayush Saxena commented on HDFS-14075: - Thanx [~trjianjianjiao] for the agreement [~elgoiri] I

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-26 Thread Rong Tang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699644#comment-16699644 ] Rong Tang commented on HDFS-14075: -- [~vinayrpet] thanks for explanation, it looks more reasonable to

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699298#comment-16699298 ] Hadoop QA commented on HDFS-14075: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-26 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699060#comment-16699060 ] Ayush Saxena commented on HDFS-14075: - Thanx [~vinayrpet] for the review. I have made the change as

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-25 Thread Vinayakumar B (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698582#comment-16698582 ] Vinayakumar B commented on HDFS-14075: -- {code:java} - throw new IOException("Unable to start

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-21 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695357#comment-16695357 ] Ayush Saxena commented on HDFS-14075: - {quote}Do you know of any other part of the code that does

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-21 Thread Rong Tang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695235#comment-16695235 ] Rong Tang commented on HDFS-14075: -- [~goiri] [~ayushtkn]  Here is my understanding after reading the

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-21 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694965#comment-16694965 ] Íñigo Goiri commented on HDFS-14075: Other than the {{new Exception()}} business,

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-20 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694273#comment-16694273 ] Ayush Saxena commented on HDFS-14075: - Thax [~elgoiri] for the reviews I have handled them all

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694198#comment-16694198 ] Hadoop QA commented on HDFS-14075: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-20 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693775#comment-16693775 ] Íñigo Goiri commented on HDFS-14075: Thanks for the clarification. Why do we do: {code}

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-20 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693662#comment-16693662 ] Ayush Saxena commented on HDFS-14075: - {quote}What's the behavior if we keep: {quote} [~elgoiri] In

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-20 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693630#comment-16693630 ] Íñigo Goiri commented on HDFS-14075: Should we keep testing the old behavior in TestNNWithQJM? What's

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693235#comment-16693235 ] Hadoop QA commented on HDFS-14075: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692428#comment-16692428 ] Hadoop QA commented on HDFS-14075: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-19 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692218#comment-16692218 ] Ayush Saxena commented on HDFS-14075: - Thanx [~elgoiri] for giving it a look. bq. For

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-19 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692076#comment-16692076 ] Íñigo Goiri commented on HDFS-14075: I have to say that Whitebox is pretty convenient, and at the end

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691921#comment-16691921 ] Hadoop QA commented on HDFS-14075: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691807#comment-16691807 ] Hadoop QA commented on HDFS-14075: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-19 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691580#comment-16691580 ] Ayush Saxena commented on HDFS-14075: - Test Failures due to  java.lang.OutOfMemoryError: unable to

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691398#comment-16691398 ] Hadoop QA commented on HDFS-14075: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-18 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691283#comment-16691283 ] Ayush Saxena commented on HDFS-14075: - Thanx [~elgoiri] for the comment. {quote}Can we avoid

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690976#comment-16690976 ] Hadoop QA commented on HDFS-14075: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690911#comment-16690911 ] Hadoop QA commented on HDFS-14075: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-16 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689766#comment-16689766 ] Íñigo Goiri commented on HDFS-14075: Thanks [~ayushtkn] for the details. A couple comments: * I think

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689437#comment-16689437 ] Hadoop QA commented on HDFS-14075: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-16 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689259#comment-16689259 ] Ayush Saxena commented on HDFS-14075: - Thanx [~elgoiri] for giving it a look. I have uploaded v2

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-14 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686927#comment-16686927 ] Íñigo Goiri commented on HDFS-14075: Is there a unit test we can extend to cover this? > NPE while

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-14 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686499#comment-16686499 ] Ayush Saxena commented on HDFS-14075: - Uploaded patch v1 with fix. > NPE while Edit Logging >

[jira] [Commented] (HDFS-14075) NPE while Edit Logging

2018-11-13 Thread Ayush Saxena (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686126#comment-16686126 ] Ayush Saxena commented on HDFS-14075: - Solution :: dfs.namenode.edits.dir.minimum configuration