[jira] [Commented] (HDFS-14125) Use parameterized log format in ECTopologyVerifier
[ https://issues.apache.org/jira/browse/HDFS-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767354#comment-16767354 ] Kitti Nanasi commented on HDFS-14125: - Thanks [~shwetayakkali] for the review and [~jojochuang] for reviewing and committing! > Use parameterized log format in ECTopologyVerifier > -- > > Key: HDFS-14125 > URL: https://issues.apache.org/jira/browse/HDFS-14125 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.3.0 >Reporter: Kitti Nanasi >Assignee: Kitti Nanasi >Priority: Trivial > Fix For: 3.3.0 > > Attachments: HDFS-14125.001.patch > > > ECTopologyVerifier introduced in > [HDFS-12946|https://issues.apache.org/jira/browse/HDFS-12946] should use a > parameterized log format. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14125) Use parameterized log format in ECTopologyVerifier
[ https://issues.apache.org/jira/browse/HDFS-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760302#comment-16760302 ] Hudson commented on HDFS-14125: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15880 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/15880/]) HDFS-14125. Use parameterized log format in ECTopologyVerifier. (weichiu: rev 5f15a60e329b8d0a495a977dc5255126814c5271) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/ECTopologyVerifier.java > Use parameterized log format in ECTopologyVerifier > -- > > Key: HDFS-14125 > URL: https://issues.apache.org/jira/browse/HDFS-14125 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.3.0 >Reporter: Kitti Nanasi >Assignee: Kitti Nanasi >Priority: Trivial > Fix For: 3.3.0 > > Attachments: HDFS-14125.001.patch > > > ECTopologyVerifier introduced in > [HDFS-12946|https://issues.apache.org/jira/browse/HDFS-12946] should use a > parameterized log format. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14125) Use parameterized log format in ECTopologyVerifier
[
https://issues.apache.org/jira/browse/HDFS-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755454#comment-16755454
]
Shweta commented on HDFS-14125:
---
Sure. I was actually referring to using the {} in the String.format() itself,
should have been more clear in my previous comment. Using %s and %d as you
mention seems reasonable as you are dealing with String and digits.
Looks good to me +1 (non-binding).
> Use parameterized log format in ECTopologyVerifier
> --
>
> Key: HDFS-14125
> URL: https://issues.apache.org/jira/browse/HDFS-14125
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
>Affects Versions: 3.3.0
>Reporter: Kitti Nanasi
>Assignee: Kitti Nanasi
>Priority: Trivial
> Attachments: HDFS-14125.001.patch
>
>
> ECTopologyVerifier introduced in
> [HDFS-12946|https://issues.apache.org/jira/browse/HDFS-12946] should use a
> parameterized log format.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14125) Use parameterized log format in ECTopologyVerifier
[ https://issues.apache.org/jira/browse/HDFS-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755384#comment-16755384 ] Kitti Nanasi commented on HDFS-14125: - Thanks for the comment [~shwetayakkali]! I used String.format instead of the logger's standard formatter, which accepts %s and %d. I used that because I pass that same String in the result as well, so I can't use just the logger's formatter. > Use parameterized log format in ECTopologyVerifier > -- > > Key: HDFS-14125 > URL: https://issues.apache.org/jira/browse/HDFS-14125 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.3.0 >Reporter: Kitti Nanasi >Assignee: Kitti Nanasi >Priority: Trivial > Attachments: HDFS-14125.001.patch > > > ECTopologyVerifier introduced in > [HDFS-12946|https://issues.apache.org/jira/browse/HDFS-12946] should use a > parameterized log format. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14125) Use parameterized log format in ECTopologyVerifier
[
https://issues.apache.org/jira/browse/HDFS-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752885#comment-16752885
]
Shweta commented on HDFS-14125:
---
Thanks for the patch [~knanasi].
For parameterized logging I believe using {} would be a good idea since {}
notation accepts any Object or value and a thrown exception making it more
efficient. Is thereby specific reason to choose %s and %d notations?
> Use parameterized log format in ECTopologyVerifier
> --
>
> Key: HDFS-14125
> URL: https://issues.apache.org/jira/browse/HDFS-14125
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
>Affects Versions: 3.3.0
>Reporter: Kitti Nanasi
>Assignee: Kitti Nanasi
>Priority: Trivial
> Attachments: HDFS-14125.001.patch
>
>
> ECTopologyVerifier introduced in
> [HDFS-12946|https://issues.apache.org/jira/browse/HDFS-12946] should use a
> parameterized log format.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14125) Use parameterized log format in ECTopologyVerifier
[ https://issues.apache.org/jira/browse/HDFS-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752442#comment-16752442 ] Wei-Chiu Chuang commented on HDFS-14125: +1 > Use parameterized log format in ECTopologyVerifier > -- > > Key: HDFS-14125 > URL: https://issues.apache.org/jira/browse/HDFS-14125 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.3.0 >Reporter: Kitti Nanasi >Assignee: Kitti Nanasi >Priority: Trivial > Attachments: HDFS-14125.001.patch > > > ECTopologyVerifier introduced in > [HDFS-12946|https://issues.apache.org/jira/browse/HDFS-12946] should use a > parameterized log format. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14125) Use parameterized log format in ECTopologyVerifier
[
https://issues.apache.org/jira/browse/HDFS-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751446#comment-16751446
]
Hadoop QA commented on HDFS-14125:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 40s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 33s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 77m 42s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}133m 3s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.web.TestWebHdfsTimeouts |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDFS-14125 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12956171/HDFS-14125.001.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 6ac2a7a458a4 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 3c7d700 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/26045/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/26045/testReport/ |
| Max. process+thread count | 4139 (vs. ulimit of 1) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
