[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834936#comment-16834936 ] Lukas Majercak commented on HDFS-14134: --- Hi [~John Smith]. I'm not sure if it's that simple. Say

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834323#comment-16834323 ] Yuxuan Wang commented on HDFS-14134: Hi [~lukmajercak]. No. I just figure that {{StandbyException}}

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832730#comment-16832730 ] Lukas Majercak commented on HDFS-14134: --- Hi [~John Smith]. I'm not sure I'm following, what's the

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828887#comment-16828887 ] Hadoop QA commented on HDFS-14134: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828886#comment-16828886 ] Yuxuan Wang commented on HDFS-14134: Hello, anyone is working on this? I find a bug in

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767831#comment-16767831 ] Íñigo Goiri commented on HDFS-14134: As nobody else other than [~knanasi] is taking over the review,

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740810#comment-16740810 ] Lukas Majercak commented on HDFS-14134: --- + more people [~szetszwo], [~jingzhao]. > Idempotent

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740802#comment-16740802 ] Lukas Majercak commented on HDFS-14134: --- Thanks [~knanasi]. [~atm], [~eli], [~sureshms],

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740605#comment-16740605 ] Íñigo Goiri commented on HDFS-14134: [^HDFS-14134.007.patch] LGTM. However, I have limited experience

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740232#comment-16740232 ] Kitti Nanasi commented on HDFS-14134: - Thanks [~lukmajercak] for the work here! {quote}Also note that

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739894#comment-16739894 ] Hadoop QA commented on HDFS-14134: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739821#comment-16739821 ] Lukas Majercak commented on HDFS-14134: --- Patch 007 to fix checkstyle + whitespace warnings. >

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739809#comment-16739809 ] Hadoop QA commented on HDFS-14134: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739719#comment-16739719 ] Lukas Majercak commented on HDFS-14134: --- Added patch006 together with

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739704#comment-16739704 ] Hadoop QA commented on HDFS-14134: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738702#comment-16738702 ] Lukas Majercak commented on HDFS-14134: --- Also note that previously, if a hedging request got

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738700#comment-16738700 ] Lukas Majercak commented on HDFS-14134: --- I see, that makes sense, I'm happy to change

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720572#comment-16720572 ] Kitti Nanasi commented on HDFS-14134: - The relevant part is the following: {quote}in

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720564#comment-16720564 ] Lukas Majercak commented on HDFS-14134: --- I'll go through that discussion. > Idempotent operations

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720563#comment-16720563 ] Kitti Nanasi commented on HDFS-14134: - Yes, this change covers that, I just wanted to understand why

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720506#comment-16720506 ] Lukas Majercak commented on HDFS-14134: --- I agree non-remote IOExceptions could be network related,

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720507#comment-16720507 ] Lukas Majercak commented on HDFS-14134: --- I'd argue that this change is even safer, because

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720204#comment-16720204 ] Kitti Nanasi commented on HDFS-14134: - I totally agree with you that retrying getXAttr on "attr could

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719444#comment-16719444 ] Lukas Majercak commented on HDFS-14134: --- Retrying failed idempotent operations might be safe, but

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718752#comment-16718752 ] Kitti Nanasi commented on HDFS-14134: - [~lukmajercak], you are correct on the definition of

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717754#comment-16717754 ] Lukas Majercak commented on HDFS-14134: --- Why should we retry if the operation is idempotent and the

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716690#comment-16716690 ] Kitti Nanasi commented on HDFS-14134: - Thanks for the new patch [~lukmajercak]! It looks better

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716043#comment-16716043 ] Íñigo Goiri commented on HDFS-14134: I think the change in semantics makes sense and +1 on that.

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716033#comment-16716033 ] Hadoop QA commented on HDFS-14134: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715870#comment-16715870 ] Hadoop QA commented on HDFS-14134: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715863#comment-16715863 ] Lukas Majercak commented on HDFS-14134: --- Patch 005 to fix minor checkstyle issue in

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715862#comment-16715862 ] Hadoop QA commented on HDFS-14134: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715705#comment-16715705 ] Lukas Majercak commented on HDFS-14134: --- Added tests to cover all cases (SocketExc, IOException,

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715682#comment-16715682 ] Lukas Majercak commented on HDFS-14134: --- Fixed TestFailoverProxy as well, still might need to add

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715579#comment-16715579 ] Lukas Majercak commented on HDFS-14134: --- I realized I needed to change the mock expectations to fix

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715566#comment-16715566 ] Hadoop QA commented on HDFS-14134: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715545#comment-16715545 ] Lukas Majercak commented on HDFS-14134: --- Thanks for the review [~knanasi]. I've uploaded patch002

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714464#comment-16714464 ] Kitti Nanasi commented on HDFS-14134: - Thanks [~lukmajercak] for the patch! The proposed solution in

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713440#comment-16713440 ] Lukas Majercak commented on HDFS-14134: --- The unit tests are expected to fail, I can fix them once

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713419#comment-16713419 ] Hadoop QA commented on HDFS-14134: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713398#comment-16713398 ] Hadoop QA commented on HDFS-14134: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713358#comment-16713358 ] Lukas Majercak commented on HDFS-14134: --- For the retry policy changes, maybe it would make sense to

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713326#comment-16713326 ] Lukas Majercak commented on HDFS-14134: --- Reuploaded the patch, because this guy Yetus took my pdf

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713314#comment-16713314 ] Lukas Majercak commented on HDFS-14134: --- Added HDFS-14134_retrypolicy_change_proposal.pdf to

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713319#comment-16713319 ] Hadoop QA commented on HDFS-14134: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713301#comment-16713301 ] Íñigo Goiri commented on HDFS-14134: There are a bunch of related JIRAs: * HADOOP-9792 * HADOOP-7896

[jira] [Commented] (HDFS-14134) Idempotent operations throwing RemoteException should not be retried by the client

[ https://issues.apache.org/jira/browse/HDFS-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713233#comment-16713233 ] Lukas Majercak commented on HDFS-14134: --- Added a patch to demonstrate the issue. > Idempotent