[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763602#comment-16763602
]
Adam Antal commented on HDFS-14172:
---
Thanks [~water] for the contribution, and [~linyiqun] for the
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763571#comment-16763571
]
Hudson commented on HDFS-14172:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15917 (See
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763555#comment-16763555
]
Yiqun Lin commented on HDFS-14172:
--
LGTM, +1. Commit this shortly.
> Avoid NPE when
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763282#comment-16763282
]
Hadoop QA commented on HDFS-14172:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763210#comment-16763210
]
Xiang Li commented on HDFS-14172:
-
Thanks [~linyiqun] for the comments!
bq. Can we reuse sectionName to
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763199#comment-16763199
]
Yiqun Lin commented on HDFS-14172:
--
Almost looks good to me, [~water]. One minor comment;
{code:java}
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762915#comment-16762915
]
Adam Antal commented on HDFS-14172:
---
Great, even the jenkins is ok. +1 (non binding).
> Avoid NPE when
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762901#comment-16762901
]
Hadoop QA commented on HDFS-14172:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762700#comment-16762700
]
Xiang Li commented on HDFS-14172:
-
[~adam.antal] Thanks for the comments! Corrected and patch v005 is
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762583#comment-16762583
]
Adam Antal commented on HDFS-14172:
---
Thanks for the patch, [~water]. This looks quite clear now.
The
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762489#comment-16762489
]
Hadoop QA commented on HDFS-14172:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762398#comment-16762398
]
Xiang Li commented on HDFS-14172:
-
[~adam.antal] Would you please check patch 004 ? I removed the "else"
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760700#comment-16760700
]
Adam Antal commented on HDFS-14172:
---
[~water], the patch is good, though I'd rather not change the
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759264#comment-16759264
]
Xiang Li commented on HDFS-14172:
-
[~linyiqun] [~adam.antal], could you please review the patch v003 when
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759262#comment-16759262
]
Xiang Li commented on HDFS-14172:
-
The UT errors reported are not related. Could get them passed on my
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757504#comment-16757504
]
Hadoop QA commented on HDFS-14172:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757247#comment-16757247
]
Xiang Li commented on HDFS-14172:
-
[~linyiqun] Patch v003 is uploaded to
* Throw an IOException instead
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757155#comment-16757155
]
Hadoop QA commented on HDFS-14172:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757079#comment-16757079
]
Yiqun Lin commented on HDFS-14172:
--
Yes, [~water]. Some unrelated can all be reverted, :).
> Avoid NPE
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757067#comment-16757067
]
Xiang Li commented on HDFS-14172:
-
[~linyiqun]
bq. can we revert additional change and make this JIRA
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757056#comment-16757056
]
Yiqun Lin commented on HDFS-14172:
--
{quote}Regarding the behavior against an unknown section, I would
21 matches
Mail list logo
