[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757034#comment-16757034
]
Xiang Li commented on HDFS-14172:
-
Hi [~linyiqun], [~adam.antal], thanks for your comments!
Regarding the
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756173#comment-16756173
]
Adam Antal commented on HDFS-14172:
---
Thanks for the patch, [~water].
I did not see the comparator is so
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755222#comment-16755222
]
Hadoop QA commented on HDFS-14172:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755160#comment-16755160
]
Yiqun Lin commented on HDFS-14172:
--
[~water], just take a quick look for this , I prefer to use the way
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755122#comment-16755122
]
Xiang Li commented on HDFS-14172:
-
[~linyiqun] Really appreciate it if you could help to take a look at
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755094#comment-16755094
]
Xiang Li commented on HDFS-14172:
-
Upload patch 001 to add a UT for this change. [~xyao] Could you
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752275#comment-16752275
]
Xiang Li commented on HDFS-14172:
-
The UT failures reported are not due to the patch. Tested those on my
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751910#comment-16751910
]
Weiwei Yang commented on HDFS-14172:
Cc [~xyao], it would be nice if you can help to take a look at
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751353#comment-16751353
]
Hadoop QA commented on HDFS-14172:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751190#comment-16751190
]
Xiang Li commented on HDFS-14172:
-
Attached the very first patch (v000) to demonstrate my idea. Working
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747635#comment-16747635
]
Xiang Li commented on HDFS-14172:
-
[~adam.antal] [~dhruba] Could you please review if those make any
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745877#comment-16745877
]
Xiang Li commented on HDFS-14172:
-
[~adam.antal], thanks very much for the comments!
1. I found there is
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740242#comment-16740242
]
Adam Antal commented on HDFS-14172:
---
I support the idea of modifying this part of the code as well to
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728581#comment-16728581
]
Xiang Li commented on HDFS-14172:
-
We met the NPE under the scenario that: we applied the patch of
14 matches
Mail list logo
