[jira] [Commented] (HDFS-14407) Fix mistakenly used of SLF4j or Log4j2 logging in DatasetVolumeChecker#checkAllVolumes

2019-04-04 Thread Akira Ajisaka (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDFS-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809594#comment-16809594
 ] 

Akira Ajisaka commented on HDFS-14407:
--

+1

> Fix mistakenly used of SLF4j or Log4j2 logging in 
> DatasetVolumeChecker#checkAllVolumes
> --
>
> Key: HDFS-14407
> URL: https://issues.apache.org/jira/browse/HDFS-14407
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Wanqiang Ji
>Assignee: Wanqiang Ji
>Priority: Minor
> Attachments: HDFS-14407.001.patch
>
>
>  Wrong:
> {code:java}
> LOG.warn("checkAllVolumes timed out after {} ms" +
> maxAllowedTimeForCheckMs);
> {code}
> Correct:
> {code:java}
> LOG.warn("checkAllVolumes timed out after {} ms",
> maxAllowedTimeForCheckMs);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-14407) Fix mistakenly used of SLF4j or Log4j2 logging in DatasetVolumeChecker#checkAllVolumes

2019-04-03 Thread Wanqiang Ji (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDFS-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809365#comment-16809365
 ] 

Wanqiang Ji commented on HDFS-14407:


Thank [~giovanni.fumarola] for the review.

> Fix mistakenly used of SLF4j or Log4j2 logging in 
> DatasetVolumeChecker#checkAllVolumes
> --
>
> Key: HDFS-14407
> URL: https://issues.apache.org/jira/browse/HDFS-14407
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Wanqiang Ji
>Assignee: Wanqiang Ji
>Priority: Minor
> Attachments: HDFS-14407.001.patch
>
>
>  Wrong:
> {code:java}
> LOG.warn("checkAllVolumes timed out after {} ms" +
> maxAllowedTimeForCheckMs);
> {code}
> Correct:
> {code:java}
> LOG.warn("checkAllVolumes timed out after {} ms",
> maxAllowedTimeForCheckMs);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-14407) Fix mistakenly used of SLF4j or Log4j2 logging in DatasetVolumeChecker#checkAllVolumes

2019-04-03 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDFS-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808977#comment-16808977
 ] 

Hadoop QA commented on HDFS-14407:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m 
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
4s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}  
3m 58s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
54s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 43s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 77m 35s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
35s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}122m 56s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.web.TestWebHdfsTimeouts |
|   | hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDFS-14407 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12964722/HDFS-14407.001.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  |
| uname | Linux f2c4802edada 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 002dcc4 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/26572/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/26572/testReport/ |
| Max. process+thread count | 5322 (vs. ulimit of 1) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:

[jira] [Commented] (HDFS-14407) Fix mistakenly used of SLF4j or Log4j2 logging in DatasetVolumeChecker#checkAllVolumes

2019-04-03 Thread Giovanni Matteo Fumarola (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDFS-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808957#comment-16808957
 ] 

Giovanni Matteo Fumarola commented on HDFS-14407:
-

Thanks [~jiwq] . I will commit it after the Yetus results.

> Fix mistakenly used of SLF4j or Log4j2 logging in 
> DatasetVolumeChecker#checkAllVolumes
> --
>
> Key: HDFS-14407
> URL: https://issues.apache.org/jira/browse/HDFS-14407
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Wanqiang Ji
>Assignee: Wanqiang Ji
>Priority: Minor
> Attachments: HDFS-14407.001.patch
>
>
>  Wrong:
> {code:java}
> LOG.warn("checkAllVolumes timed out after {} ms" +
> maxAllowedTimeForCheckMs);
> {code}
> Correct:
> {code:java}
> LOG.warn("checkAllVolumes timed out after {} ms",
> maxAllowedTimeForCheckMs);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org