[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863603#comment-16863603
]
Hudson commented on HDFS-14560:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16743 (See
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863594#comment-16863594
]
Íñigo Goiri commented on HDFS-14560:
Thanks [~sodonnell] for the patch and [~hexiaoqiao] for the
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862593#comment-16862593
]
Hadoop QA commented on HDFS-14560:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862493#comment-16862493
]
Hadoop QA commented on HDFS-14560:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862486#comment-16862486
]
Stephen O'Donnell commented on HDFS-14560:
--
Deleted it and re-uploaded with the new name. Many
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862483#comment-16862483
]
Íñigo Goiri commented on HDFS-14560:
[^HDFS-14560.005.patch] LGTM.
+1
Do you mind labeling the patch
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862478#comment-16862478
]
Stephen O'Donnell commented on HDFS-14560:
--
When committing this, it would be great if we could
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862385#comment-16862385
]
Stephen O'Donnell commented on HDFS-14560:
--
I just pushed up v005 with the change to static for
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862326#comment-16862326
]
He Xiaoqiao commented on HDFS-14560:
+1 for [^HDFS-14560.004.patch]. Thanks [~sodonnell] for your
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862296#comment-16862296
]
Íñigo Goiri commented on HDFS-14560:
Just a minor comment, let's make {{ensurePositiveInt()}} static.
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862003#comment-16862003
]
Hadoop QA commented on HDFS-14560:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861857#comment-16861857
]
Stephen O'Donnell commented on HDFS-14560:
--
I have tightened up the code around the
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861588#comment-16861588
]
Hadoop QA commented on HDFS-14560:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861577#comment-16861577
]
Íñigo Goiri commented on HDFS-14560:
Thanks [~sodonnell] for tackling the comments.
{quote}
OK, I had
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861447#comment-16861447
]
Stephen O'Donnell commented on HDFS-14560:
--
[~hexiaoqiao] I agree that it would nice for as many
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861362#comment-16861362
]
Hadoop QA commented on HDFS-14560:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861224#comment-16861224
]
He Xiaoqiao commented on HDFS-14560:
another thought based on this issue: there are many parameters
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861206#comment-16861206
]
Íñigo Goiri commented on HDFS-14560:
Thanks [~sodonnell] for the patch.
A few minor comments:
* I
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861186#comment-16861186
]
Stephen O'Donnell commented on HDFS-14560:
--
I don't think the test failures are related. I have
[
https://issues.apache.org/jira/browse/HDFS-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861122#comment-16861122
]
Hadoop QA commented on HDFS-14560:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
20 matches
Mail list logo
