[jira] [Commented] (HDFS-14707) Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2
[ https://issues.apache.org/jira/browse/HDFS-14707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907724#comment-16907724 ] Akira Ajisaka commented on HDFS-14707: -- +1. Thank you, [~iwasakims]. > Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2 > > > Key: HDFS-14707 > URL: https://issues.apache.org/jira/browse/HDFS-14707 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14707-branch-2.001.patch, > HDFS-14707-branch-2.002.patch > > > Currently HTTPFS does not load hadoop native library since java.library.path > is not set on Tomcat startup. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14707) Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2
[ https://issues.apache.org/jira/browse/HDFS-14707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906146#comment-16906146 ] Hadoop QA commented on HDFS-14707: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 9m 14s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m 47s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 50s{color} | {color:green} branch-2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 0s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 12s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s{color} | {color:green} hadoop-hdfs-httpfs in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 26s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 26m 23s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:da67579 | | JIRA Issue | HDFS-14707 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12977479/HDFS-14707-branch-2.002.patch | | Optional Tests | dupname asflicense mvnsite unit shellcheck shelldocs | | uname | Linux e81bb6219086 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-2 / 885b7f4 | | maven | version: Apache Maven 3.3.9 | | shellcheck | v0.4.6 | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/27495/testReport/ | | Max. process+thread count | 105 (vs. ulimit of 1) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/27495/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2 > > > Key: HDFS-14707 > URL: https://issues.apache.org/jira/browse/HDFS-14707 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14707-branch-2.001.patch, > HDFS-14707-branch-2.002.patch > > > Currently HTTPFS does not load hadoop native library since java.library.path > is not set on Tomcat startup. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14707) Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2
[ https://issues.apache.org/jira/browse/HDFS-14707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906121#comment-16906121 ] Masatake Iwasaki commented on HDFS-14707: - I updated the patch based on your comment. Thanks, [~aajisaka]. > Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2 > > > Key: HDFS-14707 > URL: https://issues.apache.org/jira/browse/HDFS-14707 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14707-branch-2.001.patch, > HDFS-14707-branch-2.002.patch > > > Currently HTTPFS does not load hadoop native library since java.library.path > is not set on Tomcat startup. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14707) Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2
[ https://issues.apache.org/jira/browse/HDFS-14707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905881#comment-16905881 ] Akira Ajisaka commented on HDFS-14707: -- Thanks [~iwasakims] for the patch. Mostly looks good to me. One comment: {code} if [ "x$JAVA_LIBRARY_PATH" = "x" ]; then {code} the check can be replaced with -z option: {code} if [[ -z "${JAVA_LIBRARY_PATH}" ]]; then {code} > Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2 > > > Key: HDFS-14707 > URL: https://issues.apache.org/jira/browse/HDFS-14707 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14707-branch-2.001.patch > > > Currently HTTPFS does not load hadoop native library since java.library.path > is not set on Tomcat startup. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14707) Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2
[ https://issues.apache.org/jira/browse/HDFS-14707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901906#comment-16901906 ] Masatake Iwasaki commented on HDFS-14707: - I manually tested the modified httpfs.sh using downloaded hadoop-2.9.2.tar.gz with debug logging enabled in httpfs-log4j.properties. Native library was not loaded without the fix. {noformat} 2019-08-07 17:24:51,001 DEBUG NativeCodeLoader [][:] Trying to load the custom-built native-hadoop library... 2019-08-07 17:24:51,001 DEBUG NativeCodeLoader [][:] Failed to load native-hadoop with error: java.lang.UnsatisfiedLinkError: no hadoop in java.library.path 2019-08-07 17:24:51,001 DEBUG NativeCodeLoader [][:] java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib 2019-08-07 17:24:51,002 WARN NativeCodeLoader [][:] Unable to load native-hadoop library for your platform... using builtin-java classes where applicable {noformat} Native library was loaded with the patch. {noformat} 2019-08-07 17:25:45,622 DEBUG NativeCodeLoader [][:] Trying to load the custom-built native-hadoop library... 2019-08-07 17:25:45,623 DEBUG NativeCodeLoader [][:] Loaded the native-hadoop library {noformat} > Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2 > > > Key: HDFS-14707 > URL: https://issues.apache.org/jira/browse/HDFS-14707 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14707-branch-2.001.patch > > > Currently HTTPFS does not load hadoop native library since java.library.path > is not set on Tomcat startup. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14707) Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2
[ https://issues.apache.org/jira/browse/HDFS-14707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901631#comment-16901631 ] Hadoop QA commented on HDFS-14707: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 9m 41s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 59s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 48s{color} | {color:green} branch-2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 0s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 12s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s{color} | {color:green} hadoop-hdfs-httpfs in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 24s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 57s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:da67579 | | JIRA Issue | HDFS-14707 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12976882/HDFS-14707-branch-2.001.patch | | Optional Tests | dupname asflicense mvnsite unit shellcheck shelldocs | | uname | Linux f2c657c2efba 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-2 / 4a9fc45 | | maven | version: Apache Maven 3.3.9 | | shellcheck | v0.4.6 | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/27426/testReport/ | | Max. process+thread count | 94 (vs. ulimit of 1) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/27426/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2 > > > Key: HDFS-14707 > URL: https://issues.apache.org/jira/browse/HDFS-14707 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14707-branch-2.001.patch > > > Currently HTTPFS does not load hadoop native library since java.library.path > is not set on Tomcat startup. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14707) Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2
[ https://issues.apache.org/jira/browse/HDFS-14707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901616#comment-16901616 ] Masatake Iwasaki commented on HDFS-14707: - Same as done for KMS in HADOOP-11329. > Add JAVA_LIBRARY_PATH to HTTPFS startup options in branch-2 > > > Key: HDFS-14707 > URL: https://issues.apache.org/jira/browse/HDFS-14707 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > > Currently HTTPFS does not load hadoop native library since java.library.path > is not set on Tomcat startup. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org