[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912609#comment-16912609 ] Hudson commented on HDFS-14714: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17161 (See

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912493#comment-16912493 ] Íñigo Goiri commented on HDFS-14714: Thanks [~zhangchen] for the fix. Committed to trunk. > RBF:

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912490#comment-16912490 ] Íñigo Goiri commented on HDFS-14714: [^HDFS-14714.005.patch] LGTM. +1 > RBF: implement

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912255#comment-16912255 ] Hadoop QA commented on HDFS-14714: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912113#comment-16912113 ] Chen Zhang commented on HDFS-14714: --- [~ayushtkn] thanks for your suggestion. Yes, the hardcoded

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911767#comment-16911767 ] Hadoop QA commented on HDFS-14714: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911594#comment-16911594 ] Ayush Saxena commented on HDFS-14714: - Thanx [~zhangchen] for the patch. {code:java} +

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911570#comment-16911570 ] Chen Zhang commented on HDFS-14714: --- Thanks [~elgoiri] for your review and comments, the code in unit

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911503#comment-16911503 ] Íñigo Goiri commented on HDFS-14714: A couple minor comments: * In the assertEquals in line 1412, we

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911459#comment-16911459 ] Chen Zhang commented on HDFS-14714: --- Thanks [~ayushtkn] for your review,

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911425#comment-16911425 ] Ayush Saxena commented on HDFS-14714: - {{mergeReplicatedBlockStats}} can be moved inside

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911108#comment-16911108 ] Chen Zhang commented on HDFS-14714: --- Hi [~ayushtkn], can you help to review the patch? Thanks. > RBF:

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911063#comment-16911063 ] Hadoop QA commented on HDFS-14714: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911018#comment-16911018 ] Chen Zhang commented on HDFS-14714: --- uploaded patch v2 to fix checkstyle and whitespace error > RBF:

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910615#comment-16910615 ] Hadoop QA commented on HDFS-14714: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910546#comment-16910546 ] Chen Zhang commented on HDFS-14714: --- Thanks [~ayushtkn] for your suggestion, uploaded the patch v1 >

[jira] [Commented] (HDFS-14714) RBF: implement getReplicatedBlockStats interface

[ https://issues.apache.org/jira/browse/HDFS-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904331#comment-16904331 ] Ayush Saxena commented on HDFS-14714: - Thanx [~zhangchen], Makes sense to have, We already have