[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937008#comment-16937008
]
Hudson commented on HDFS-14837:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17370 (See
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936985#comment-16936985
]
Íñigo Goiri commented on HDFS-14837:
Thanks [~belugabehr] for the patch.
Committed to trunk.
>
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936804#comment-16936804
]
David Mollitor commented on HDFS-14837:
---
[~elgoiri] Are we good to move forward on this?
> Review
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929357#comment-16929357
]
Íñigo Goiri commented on HDFS-14837:
+1 on [^HDFS-14837.4.patch].
As this is pretty core, I'll give
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929352#comment-16929352
]
Hadoop QA commented on HDFS-14837:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929238#comment-16929238
]
Hadoop QA commented on HDFS-14837:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929186#comment-16929186
]
David Mollitor commented on HDFS-14837:
---
[~elgoiri] When you're right. You're right.
Thanks. Put
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928975#comment-16928975
]
Íñigo Goiri commented on HDFS-14837:
We may want to keep the comment in hashCode().
I think is
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928955#comment-16928955
]
Hadoop QA commented on HDFS-14837:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928937#comment-16928937
]
David Mollitor commented on HDFS-14837:
---
[~elgoiri] Thanks for the feed back!
{{EqualsBuider}} and
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927106#comment-16927106
]
Íñigo Goiri commented on HDFS-14837:
Can we use EqualsBuilder and HashCodeBuilder?
I would also
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926665#comment-16926665
]
David Mollitor commented on HDFS-14837:
---
Yes. :)
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926301#comment-16926301
]
stack commented on HDFS-14837:
--
One question, is Long.hashCode same as (int)(blockId^(blockId>>>32)) (I've
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926218#comment-16926218
]
Hadoop QA commented on HDFS-14837:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926214#comment-16926214
]
stack commented on HDFS-14837:
--
+1
nice cleanup
> Review of Block.java
>
>
>
15 matches
Mail list logo