[jira] [Commented] (HDFS-14853) NPE in DFSNetworkTopology#chooseRandomWithStorageType() when the excludedNode is deleted

2019-09-22 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935268#comment-16935268 ] Hadoop QA commented on HDFS-14853: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14853) NPE in DFSNetworkTopology#chooseRandomWithStorageType() when the excludedNode is deleted

2019-09-22 Thread Ranith Sardar (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935226#comment-16935226 ] Ranith Sardar commented on HDFS-14853: -- Thanks [~ayushtkn], in the new patch, handled the checkstyle

[jira] [Commented] (HDFS-14853) NPE in DFSNetworkTopology#chooseRandomWithStorageType() when the excludedNode is deleted

2019-09-19 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934019#comment-16934019 ] Ayush Saxena commented on HDFS-14853: - Thanx [~RANith] for the patch. there is a checkstyle warning

[jira] [Commented] (HDFS-14853) NPE in DFSNetworkTopology#chooseRandomWithStorageType() when the excludedNode is deleted

2019-09-19 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933896#comment-16933896 ] Hadoop QA commented on HDFS-14853: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-14853) NPE in DFSNetworkTopology#chooseRandomWithStorageType() when the excludedNode is deleted

2019-09-19 Thread Ranith Sardar (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933785#comment-16933785 ] Ranith Sardar commented on HDFS-14853: -- Thankx [~ayushtkn], for reviewing this patch. And yes, this

[jira] [Commented] (HDFS-14853) NPE in DFSNetworkTopology#chooseRandomWithStorageType() when the excludedNode is deleted

2019-09-19 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933463#comment-16933463 ] Yuxuan Wang commented on HDFS-14853: We should import .* in TestDFSNetworkTopology.java ? > NPE in

[jira] [Commented] (HDFS-14853) NPE in DFSNetworkTopology#chooseRandomWithStorageType() when the excludedNode is deleted

2019-09-19 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933212#comment-16933212 ] Hadoop QA commented on HDFS-14853: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14853) NPE in DFSNetworkTopology#chooseRandomWithStorageType() when the excludedNode is deleted

2019-09-19 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933185#comment-16933185 ] Ayush Saxena commented on HDFS-14853: - Thanx [~RANith] for the patch. Fix makes sense to me. For the

[jira] [Commented] (HDFS-14853) NPE in DFSNetworkTopology#chooseRandomWithStorageType() when the excludedNode is deleted

2019-09-19 Thread Ranith Sardar (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933100#comment-16933100 ] Ranith Sardar commented on HDFS-14853: -- Attached the patch. Please review it once. > NPE in