[
https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935268#comment-16935268
]
Hadoop QA commented on HDFS-14853:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935226#comment-16935226
]
Ranith Sardar commented on HDFS-14853:
--
Thanks [~ayushtkn], in the new patch, handled the checkstyle
[
https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934019#comment-16934019
]
Ayush Saxena commented on HDFS-14853:
-
Thanx [~RANith] for the patch. there is a checkstyle warning
[
https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933896#comment-16933896
]
Hadoop QA commented on HDFS-14853:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933785#comment-16933785
]
Ranith Sardar commented on HDFS-14853:
--
Thankx [~ayushtkn], for reviewing this patch. And yes, this
[
https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933463#comment-16933463
]
Yuxuan Wang commented on HDFS-14853:
We should import .* in TestDFSNetworkTopology.java ?
> NPE in
[
https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933212#comment-16933212
]
Hadoop QA commented on HDFS-14853:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933185#comment-16933185
]
Ayush Saxena commented on HDFS-14853:
-
Thanx [~RANith] for the patch. Fix makes sense to me.
For the
[
https://issues.apache.org/jira/browse/HDFS-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933100#comment-16933100
]
Ranith Sardar commented on HDFS-14853:
--
Attached the patch. Please review it once.
> NPE in