[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975421#comment-16975421
]
Íñigo Goiri commented on HDFS-14882:
Thanks [~weichiu] for following up; I had forgotten about this.
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975387#comment-16975387
]
Hudson commented on HDFS-14882:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17647 (See
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975375#comment-16975375
]
Wei-Chiu Chuang commented on HDFS-14882:
Failed tests doesn't appear related. Committing 010
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973364#comment-16973364
]
Xiaoqiao He commented on HDFS-14882:
Ping [~elgoiri],[~ayushtkn] any furthermore comments?
>
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972334#comment-16972334
]
Istvan Fajth commented on HDFS-14882:
-
Hi [~hexiaoqiao], patch-10 looks good to me, sorry for the
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969041#comment-16969041
]
Xiaoqiao He commented on HDFS-14882:
Thanks [~elgoiri] for your feedback. Ping [~pifta], would like
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967040#comment-16967040
]
Íñigo Goiri commented on HDFS-14882:
I have to say that the asserts in TestNetworkTopology are a
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966481#comment-16966481
]
Xiaoqiao He commented on HDFS-14882:
Ping [~pifta],[~elgoiri],[~ayushtkn], any more suggestions or
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965386#comment-16965386
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965381#comment-16965381
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965313#comment-16965313
]
Xiaoqiao He commented on HDFS-14882:
[^HDFS-14882.010.patch] try to fix bug about
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962758#comment-16962758
]
Xiaoqiao He commented on HDFS-14882:
Thanks [~pifta] for your suggestions,
{quote}I would suggest two
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961891#comment-16961891
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961864#comment-16961864
]
Istvan Fajth commented on HDFS-14882:
-
Yes, KeyInputStream is something else I was working on, and
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961746#comment-16961746
]
Xiaoqiao He commented on HDFS-14882:
[^HDFS-14882.009.patch] originate from [~pifta]'s suggestion and
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961280#comment-16961280
]
Íñigo Goiri commented on HDFS-14882:
In the past, we have had many issues with the sorting for blocks
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961271#comment-16961271
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961123#comment-16961123
]
Xiaoqiao He commented on HDFS-14882:
Thanks [~pifta] for your suggestions, [^HDFS-14882.suggestion]
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961023#comment-16961023
]
Istvan Fajth commented on HDFS-14882:
-
Hello [~hexiaoqiao],
I was checking into the patch, and into
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960511#comment-16960511
]
Ayush Saxena commented on HDFS-14882:
-
[~elgoiri] any further comments?
> Consider DataNode load
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958975#comment-16958975
]
Ayush Saxena commented on HDFS-14882:
-
Thanx [~hexiaoqiao] for the patch v008 LGTM +1
> Consider
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957640#comment-16957640
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957592#comment-16957592
]
Xiaoqiao He commented on HDFS-14882:
Thanks [~ayushtkn],[~elgoiri] for your suggestions,
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957258#comment-16957258
]
Íñigo Goiri commented on HDFS-14882:
Correct, my proposal was to just extend the description a
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957025#comment-16957025
]
Ayush Saxena commented on HDFS-14882:
-
I guess by tweaking {{dfs.namenode.redundancy.considerLoad}}
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956745#comment-16956745
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956667#comment-16956667
]
Xiaoqiao He commented on HDFS-14882:
[~elgoiri],[~ayushtkn] Thanks for your nice reviews and
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956330#comment-16956330
]
Íñigo Goiri commented on HDFS-14882:
Given that consider load is already available for writes we
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956239#comment-16956239
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956085#comment-16956085
]
Xiaoqiao He commented on HDFS-14882:
Thanks [~ayushtkn], you are right. [^HDFS-14882.006.patch]
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956083#comment-16956083
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956033#comment-16956033
]
Ayush Saxena commented on HDFS-14882:
-
Thanx [~hexiaoqiao] for the patch.
{code:java}
-
-
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955918#comment-16955918
]
Xiaoqiao He commented on HDFS-14882:
[^HDFS-14882.005.patch] fix checkstyle and try to trigger
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955915#comment-16955915
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955804#comment-16955804
]
Xiaoqiao He commented on HDFS-14882:
Thanks [~ayushtkn] for your comments.
{quote}Though things are
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955517#comment-16955517
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955493#comment-16955493
]
Ayush Saxena commented on HDFS-14882:
-
Thanx [~hexiaoqiao]
IMO we shouldn't use the same
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955487#comment-16955487
]
Xiaoqiao He commented on HDFS-14882:
Thanks [~ayushtkn] for your reviews. I have addressed all the
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955444#comment-16955444
]
Hadoop QA commented on HDFS-14882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955433#comment-16955433
]
Ayush Saxena commented on HDFS-14882:
-
Thanx [~hexiaoqiao] for the patch. The overall idea looks
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955423#comment-16955423
]
Xiaoqiao He commented on HDFS-14882:
[^HDFS-14882.002.patch] fix checkstyle and try to trigger
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941748#comment-16941748
]
Xiaoqiao He commented on HDFS-14882:
[~lukmajercak], Thanks for your comments. This ticket is plan to
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941143#comment-16941143
]
Lukas Majercak commented on HDFS-14882:
---
Overall looks okay to me, seems like an improvement of
[
https://issues.apache.org/jira/browse/HDFS-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940961#comment-16940961
]
Hadoop QA commented on HDFS-14882:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
44 matches
Mail list logo
