[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955284#comment-16955284
]
Hudson commented on HDFS-14887:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17553 (See
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955276#comment-16955276
]
Íñigo Goiri commented on HDFS-14887:
Thanks [~hemanthboyina] for the patch and [~tasanuma] for the
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955268#comment-16955268
]
Íñigo Goiri commented on HDFS-14887:
+1 on [^HDFS-14887.009.patch].
> RBF: In Router Web UI,
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955147#comment-16955147
]
Takanobu Asanuma commented on HDFS-14887:
-
+1 on [^HDFS-14887.009.patch].
[~elgoiri] Could you
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955119#comment-16955119
]
Hadoop QA commented on HDFS-14887:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954734#comment-16954734
]
Hadoop QA commented on HDFS-14887:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953909#comment-16953909
]
Takanobu Asanuma commented on HDFS-14887:
-
Thanks for the discussion and updating the patch,
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953907#comment-16953907
]
Hadoop QA commented on HDFS-14887:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953021#comment-16953021
]
Íñigo Goiri commented on HDFS-14887:
[~tasanuma], do you mind taking a final look to see if
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953018#comment-16953018
]
Íñigo Goiri commented on HDFS-14887:
+1 on [^HDFS-14887.008.patch].
> RBF: In Router Web UI,
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953000#comment-16953000
]
Hadoop QA commented on HDFS-14887:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952292#comment-16952292
]
Íñigo Goiri commented on HDFS-14887:
My bad...
{code}
assertTrue("Cannot find ns0 in map: " + map,
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952142#comment-16952142
]
Hadoop QA commented on HDFS-14887:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951345#comment-16951345
]
Íñigo Goiri commented on HDFS-14887:
Thanks [~hemanthboyina], TestMetricsBase makes much more sense.
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951342#comment-16951342
]
Hadoop QA commented on HDFS-14887:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951259#comment-16951259
]
Íñigo Goiri commented on HDFS-14887:
That sounds good.
> RBF: In Router Web UI, Observer Namenode
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951247#comment-16951247
]
hemanthboyina commented on HDFS-14887:
--
how about having the test of [^HDFS-14887.004.patch] in
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950689#comment-16950689
]
Íñigo Goiri commented on HDFS-14887:
The test in TestStateStoreMembershipState from
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950229#comment-16950229
]
hemanthboyina commented on HDFS-14887:
--
is it okay to keep it in TestStateStoreMembershipState , as
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950150#comment-16950150
]
Íñigo Goiri commented on HDFS-14887:
I don't think TestDisabledNamespaces is the best place for this.
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950130#comment-16950130
]
Hadoop QA commented on HDFS-14887:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950119#comment-16950119
]
Hadoop QA commented on HDFS-14887:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948757#comment-16948757
]
Íñigo Goiri commented on HDFS-14887:
[~tasanuma] thank for catching the java side.
Can we add some
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948678#comment-16948678
]
Hadoop QA commented on HDFS-14887:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948316#comment-16948316
]
Takanobu Asanuma commented on HDFS-14887:
-
{quote}BTW, can you share your experience with RBF and
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948311#comment-16948311
]
Takanobu Asanuma commented on HDFS-14887:
-
Sorry, I'd like to cancel my +1. We also need to fix
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948274#comment-16948274
]
Takanobu Asanuma commented on HDFS-14887:
-
+1. Will commit it.
> RBF: In Router Web UI,
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943756#comment-16943756
]
Íñigo Goiri commented on HDFS-14887:
[^HDFS-14887.001.patch] LGTM.
+1
> RBF: In Router Web UI,
[
https://issues.apache.org/jira/browse/HDFS-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943346#comment-16943346
]
Hadoop QA commented on HDFS-14887:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
29 matches
Mail list logo