[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967269#comment-16967269
]
Hudson commented on HDFS-14891:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17607 (See
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967267#comment-16967267
]
Xieming Li commented on HDFS-14891:
---
Thank you for your review.
> RBF: namenode links in
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967259#comment-16967259
]
Takanobu Asanuma commented on HDFS-14891:
-
Thanks for fixing the checkstyle issue. Will commit it
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967258#comment-16967258
]
Hadoop QA commented on HDFS-14891:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967236#comment-16967236
]
Xieming Li commented on HDFS-14891:
---
[~elgoiri]
Thank you for your comment,
I have fixed the error in
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967189#comment-16967189
]
Íñigo Goiri commented on HDFS-14891:
Other than the checkstyle, LGTM.
Let's fix that one.
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967170#comment-16967170
]
Hadoop QA commented on HDFS-14891:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967157#comment-16967157
]
Takanobu Asanuma commented on HDFS-14891:
-
+1 on [^HDFS-14891.007.patch] from me.
[~elgoiri]
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964200#comment-16964200
]
Íñigo Goiri commented on HDFS-14891:
[~risyomei], I am referring to:
{code}
52 /**
53 *
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963882#comment-16963882
]
Takanobu Asanuma commented on HDFS-14891:
-
Thanks for update the patch, [~risyomei]. Almost
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963656#comment-16963656
]
Xieming Li commented on HDFS-14891:
---
[~elgoiri] , thank you for your comment.
{quote}Maybe fix the
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963252#comment-16963252
]
Íñigo Goiri commented on HDFS-14891:
The unit test looks good.
It takes around 6 seconds to run, not
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962732#comment-16962732
]
Xieming Li commented on HDFS-14891:
---
I was not able to recreate the unit test error on my environment
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962714#comment-16962714
]
Hadoop QA commented on HDFS-14891:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962666#comment-16962666
]
Xieming Li commented on HDFS-14891:
---
[~elgoiri][~tasanuma]
I have updated patch:
- Added test for
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958085#comment-16958085
]
Íñigo Goiri commented on HDFS-14891:
BTW, we should have a unit test specific to the JIRA
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958083#comment-16958083
]
Íñigo Goiri commented on HDFS-14891:
Thanks [~risyomei] for the update.
Maybe we want to suppress the
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957514#comment-16957514
]
Hadoop QA commented on HDFS-14891:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956940#comment-16956940
]
Hadoop QA commented on HDFS-14891:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956807#comment-16956807
]
Hadoop QA commented on HDFS-14891:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956796#comment-16956796
]
Hadoop QA commented on HDFS-14891:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956766#comment-16956766
]
Xieming Li commented on HDFS-14891:
---
[~tasanuma], [~elgoiri]
I apologize for not updating this ticker
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948764#comment-16948764
]
Íñigo Goiri commented on HDFS-14891:
I think for now we can live with this assumption and open a
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948358#comment-16948358
]
Takanobu Asanuma commented on HDFS-14891:
-
Thanks for your detailed explanation, [~risyomei].
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948270#comment-16948270
]
Xieming Li commented on HDFS-14891:
---
[~tasanuma] [~elgoiri]
I found a potential problem and I want to
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947323#comment-16947323
]
Xieming Li commented on HDFS-14891:
---
[~tasanuma], [~elgoiri]
Thank you for your review.
I will fix
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947056#comment-16947056
]
Íñigo Goiri commented on HDFS-14891:
I'm not sure if we need to qualify scheme to make it webScheme
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946618#comment-16946618
]
Hadoop QA commented on HDFS-14891:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946613#comment-16946613
]
Takanobu Asanuma commented on HDFS-14891:
-
Thanks for finding the issue and submitting the patch,
[
https://issues.apache.org/jira/browse/HDFS-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946515#comment-16946515
]
Hadoop QA commented on HDFS-14891:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
30 matches
Mail list logo