[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997820#comment-16997820
]
Hudson commented on HDFS-14908:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17770 (See
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997802#comment-16997802
]
Íñigo Goiri commented on HDFS-14908:
Thanks [~LiJinglun] for the patch and [~weichiu] and
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996306#comment-16996306
]
Jinglun commented on HDFS-14908:
Hi [~elgoiri], shall we commit v10 :) ?
> LeaseManager should check
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993976#comment-16993976
]
Íñigo Goiri commented on HDFS-14908:
The findbug is being tracked in another JIRA and the tests are
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993630#comment-16993630
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993489#comment-16993489
]
Jinglun commented on HDFS-14908:
Upload v10 fixing checkstyle.
> LeaseManager should check parent-child
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992765#comment-16992765
]
Íñigo Goiri commented on HDFS-14908:
The improvement in performance is not too crazy but I guess
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992735#comment-16992735
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992586#comment-16992586
]
Jinglun commented on HDFS-14908:
Thanks [~elgoiri] [~hemanthboyina] your comments ! Sorry for my late
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990076#comment-16990076
]
hemanthboyina commented on HDFS-14908:
--
thanks for the ping [~elgoiri] , either unifying the
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989038#comment-16989038
]
Íñigo Goiri commented on HDFS-14908:
Thanks [~LiJinglun] for the update, what does the performance
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988855#comment-16988855
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988720#comment-16988720
]
Jinglun commented on HDFS-14908:
Upload v08 using DFSUtil.isParentEntry().
> LeaseManager should check
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988062#comment-16988062
]
Íñigo Goiri commented on HDFS-14908:
Having two methods that are so similar is not very good...
I
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987890#comment-16987890
]
Jinglun commented on HDFS-14908:
This Jira is very similar with HDFS-15009. Only difference is in DFSck
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987194#comment-16987194
]
Íñigo Goiri commented on HDFS-14908:
Thanks for rebasing and checking the issue.
HDFS-15009 seems to
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986653#comment-16986653
]
Jinglun commented on HDFS-14908:
The failed unit test is unrelated. It runs well on my local pc.
>
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986622#comment-16986622
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986558#comment-16986558
]
Jinglun commented on HDFS-14908:
Rebase and upload v07. I notice the isParentEntry() is moved to DFSUtil,
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986289#comment-16986289
]
Íñigo Goiri commented on HDFS-14908:
I'm having issues applying to DFSUtil, do you mind rebasing?
>
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985746#comment-16985746
]
Jinglun commented on HDFS-14908:
Hi [~elgoiri], shall we commit this :) ?
> LeaseManager should check
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982719#comment-16982719
]
Íñigo Goiri commented on HDFS-14908:
+1 on [^HDFS-14908.006.patch].
> LeaseManager should check
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982130#comment-16982130
]
Hadoop QA commented on HDFS-14908:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982073#comment-16982073
]
Jinglun commented on HDFS-14908:
Rebase and upload v06.
> LeaseManager should check parent-child
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981911#comment-16981911
]
Wei-Chiu Chuang commented on HDFS-14908:
Sounds good to me. Thanks doing the extra check
>
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981902#comment-16981902
]
Íñigo Goiri commented on HDFS-14908:
It looks like [^HDFS-14908.005.patch] is better.
Unless
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981409#comment-16981409
]
Jinglun commented on HDFS-14908:
Hi [~elgoiri] [~weichiu], based on the result DFSUtil.isParent() is much
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980745#comment-16980745
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980720#comment-16980720
]
Jinglun commented on HDFS-14908:
Hi [~elgoiri], yes we should have a test on INodesInPath. I use a test
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979652#comment-16979652
]
Íñigo Goiri commented on HDFS-14908:
[~LiJinglun], regarding [~weichiu] question, have we tried
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979641#comment-16979641
]
Wei-Chiu Chuang commented on HDFS-14908:
Sure. By no means do I intend to stall this patch from
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979244#comment-16979244
]
Jinglun commented on HDFS-14908:
Hi [~weichiu] , thanks your comments ! Agree your way would be much
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978649#comment-16978649
]
Wei-Chiu Chuang commented on HDFS-14908:
{code}
* Check if the given path is the child of parent
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976378#comment-16976378
]
Jinglun commented on HDFS-14908:
Would anybody like to give v05 a double check ? :)
> LeaseManager
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969756#comment-16969756
]
Íñigo Goiri commented on HDFS-14908:
It would be nice to have somebody else to double check.
We can
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969752#comment-16969752
]
Jinglun commented on HDFS-14908:
Hi [~elgoiri], would you help to commit v05 ? Do we need another review
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967042#comment-16967042
]
Íñigo Goiri commented on HDFS-14908:
+1 on [^HDFS-14908.005.patch].
> LeaseManager should check
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965572#comment-16965572
]
Jinglun commented on HDFS-14908:
Hi [~elgoiri], I reran all the failed tests on my pc and they all
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964994#comment-16964994
]
Íñigo Goiri commented on HDFS-14908:
I think that the unit test failures are unrelated.
Do you mind
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964985#comment-16964985
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964858#comment-16964858
]
Jinglun commented on HDFS-14908:
Hi [~elgoiri], thanks your nice suggestion ! Upload v05 with javadoc for
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964209#comment-16964209
]
Íñigo Goiri commented on HDFS-14908:
Let's go with v03 then.
We should add a javadoc to startsWith
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963836#comment-16963836
]
Jinglun commented on HDFS-14908:
Hi [~elgoiri], would your like to have a look at the v03 and the v04 ? I
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960312#comment-16960312
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960284#comment-16960284
]
Jinglun commented on HDFS-14908:
Hi [~hexiaoqiao], v01 is not the final version using
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960015#comment-16960015
]
Íñigo Goiri commented on HDFS-14908:
Just to clarify, which one is [^HDFS-14908.001.patch]
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959520#comment-16959520
]
Xiaoqiao He commented on HDFS-14908:
Thanks [~LiJinglun] for your works and strict benchmark. IMO, we
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959390#comment-16959390
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959388#comment-16959388
]
Jinglun commented on HDFS-14908:
Hi [~hexiaoqiao], thanks your nice comments ! And sorry for my late
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958331#comment-16958331
]
Wei-Chiu Chuang commented on HDFS-14908:
Thanks. Looks really impressive. I just skimmed through
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957619#comment-16957619
]
Xiaoqiao He commented on HDFS-14908:
Thanks [~LiJinglun] for your feedback. What I mean that it could
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957493#comment-16957493
]
Jinglun commented on HDFS-14908:
Hi [~hexiaoqiao], thanks your nice comments ! Using random strings is a
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956922#comment-16956922
]
Xiaoqiao He commented on HDFS-14908:
Thanks [~LiJinglun] for your catch and works, IIUC this issue
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956700#comment-16956700
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956621#comment-16956621
]
Jinglun commented on HDFS-14908:
Introduce a new method startsWith(String str, int sStart, int sLen,
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954817#comment-16954817
]
Íñigo Goiri commented on HDFS-14908:
Thanks [~LiJinglun] for checking, I think we can live with case
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954499#comment-16954499
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953314#comment-16953314
]
Jinglun commented on HDFS-14908:
Hi [~elgoiri], thanks your nice comments ! One place is
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953029#comment-16953029
]
Íñigo Goiri commented on HDFS-14908:
At this point, I think we are replicating a lot of what
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952984#comment-16952984
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952838#comment-16952838
]
Jinglun commented on HDFS-14908:
Thanks [~elgoiri] your nice comments ! I make the DFSUtil.isParent()
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952141#comment-16952141
]
Íñigo Goiri commented on HDFS-14908:
Thanks [~LiJinglun] for the patch.
{{DFSUtil#isParent()}} is a
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952094#comment-16952094
]
Wei-Chiu Chuang commented on HDFS-14908:
[~linyiqun] wanna take a look?
> LeaseManager should
[
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952088#comment-16952088
]
Hadoop QA commented on HDFS-14908:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
64 matches
Mail list logo
