[jira] [Commented] (HDFS-14984) HDFS setQuota: Error message should be added for invalid input max range value to hdfs dfsadmin -setQuota command
[
https://issues.apache.org/jira/browse/HDFS-14984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118413#comment-17118413
]
Zhao Yi Ming commented on HDFS-14984:
-
After some deeply investigation, I found DFSClient.java code did NOT have the
problem, because the set quota and clear quota need to call this method, the
Long.MAX_VALUE is internal used for the quota default value and not set the
quota( keep the old values), so just add more details for the judgement and
separate it, one for ns, another for ss. Following is the test results:
{code:java}
$ hdfs dfsadmin -setQuota 0 /quota
setQuota: Invalid values for namespace quota : 0
Usage: hdfs dfsadmin [-setQuota ...]
$ hdfs dfsadmin -setQuota 9223372036854775807 /quota
WARN: "9223372036854775807" means QUOTA_DONT_SET, quota will not be set, it
keep the old values.
$ hdfs dfsadmin -setQuota 9223372036854775808 /quota
setQuota: "9223372036854775808" is not a valid value for a quota.
Usage: hdfs dfsadmin [-setQuota ...]
$ hdfs dfsadmin -setSpaceQuota 9223372036854775808 /quota
setSpaceQuota: "9223372036854775808" is not a valid value for a quota.
Usage: hdfs dfsadmin [-setSpaceQuota [-storageType ]
...]
$ hdfs dfsadmin -setSpaceQuota 9223372036854775807 /quota
WARN: "9223372036854775807" means QUOTA_DONT_SET, quota will not be set, it
keep the old values.
$
{code}
[~hemanthboyina] [~SouryakantaDwivedy] Please help review. Thanks!
> HDFS setQuota: Error message should be added for invalid input max range
> value to hdfs dfsadmin -setQuota command
> -
>
> Key: HDFS-14984
> URL: https://issues.apache.org/jira/browse/HDFS-14984
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
>Affects Versions: 3.1.2
>Reporter: Souryakanta Dwivedy
>Assignee: Zhao Yi Ming
>Priority: Minor
> Attachments: image-2019-11-13-14-05-19-603.png,
> image-2019-11-13-14-07-04-536.png
>
>
> An error message should be added for invalid input max range value
> "9223372036854775807" to hdfs dfsadmin -setQuota command
> * set quota for a directory with invalid input vlaue as
> "9223372036854775807"- set quota for a directory with invalid input vlaue as
> "9223372036854775807" the command will be successful without displaying any
> result.Quota value will not be set for the directory internally,but it
> will be better from user usage point of view if an error message will
> display for the invalid max range value "9223372036854775807" as it is
> displaying while setting the input value as "0" For example "hdfs
> dfsadmin -setQuota 9223372036854775807 /quota"
> !image-2019-11-13-14-05-19-603.png!
>
> * - Try to set quota for a directory with invalid input value as "0" It
> will throw an error message as "setQuota: Invalid values for quota : 0 and
> 9223372036854775807" For example "hdfs dfsadmin -setQuota 0 /quota"
> !image-2019-11-13-14-07-04-536.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14984) HDFS setQuota: Error message should be added for invalid input max range value to hdfs dfsadmin -setQuota command
[ https://issues.apache.org/jira/browse/HDFS-14984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116519#comment-17116519 ] Zhao Yi Ming commented on HDFS-14984: - Thanks [~hemanthboyina] ! Assign to me to work on. > HDFS setQuota: Error message should be added for invalid input max range > value to hdfs dfsadmin -setQuota command > - > > Key: HDFS-14984 > URL: https://issues.apache.org/jira/browse/HDFS-14984 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Affects Versions: 3.1.2 >Reporter: Souryakanta Dwivedy >Assignee: Zhao Yi Ming >Priority: Minor > Attachments: image-2019-11-13-14-05-19-603.png, > image-2019-11-13-14-07-04-536.png > > > An error message should be added for invalid input max range value > "9223372036854775807" to hdfs dfsadmin -setQuota command > * set quota for a directory with invalid input vlaue as > "9223372036854775807"- set quota for a directory with invalid input vlaue as > "9223372036854775807" the command will be successful without displaying any > result.Quota value will not be set for the directory internally,but it > will be better from user usage point of view if an error message will > display for the invalid max range value "9223372036854775807" as it is > displaying while setting the input value as "0" For example "hdfs > dfsadmin -setQuota 9223372036854775807 /quota" > !image-2019-11-13-14-05-19-603.png! > > * - Try to set quota for a directory with invalid input value as "0" It > will throw an error message as "setQuota: Invalid values for quota : 0 and > 9223372036854775807" For example "hdfs dfsadmin -setQuota 0 /quota" > !image-2019-11-13-14-07-04-536.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14984) HDFS setQuota: Error message should be added for invalid input max range value to hdfs dfsadmin -setQuota command
[ https://issues.apache.org/jira/browse/HDFS-14984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116475#comment-17116475 ] hemanthboyina commented on HDFS-14984: -- thanks for the interest [~zhaoyim] you can work on this issue and assign this issue to yourself > HDFS setQuota: Error message should be added for invalid input max range > value to hdfs dfsadmin -setQuota command > - > > Key: HDFS-14984 > URL: https://issues.apache.org/jira/browse/HDFS-14984 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Affects Versions: 3.1.2 >Reporter: Souryakanta Dwivedy >Priority: Minor > Attachments: image-2019-11-13-14-05-19-603.png, > image-2019-11-13-14-07-04-536.png > > > An error message should be added for invalid input max range value > "9223372036854775807" to hdfs dfsadmin -setQuota command > * set quota for a directory with invalid input vlaue as > "9223372036854775807"- set quota for a directory with invalid input vlaue as > "9223372036854775807" the command will be successful without displaying any > result.Quota value will not be set for the directory internally,but it > will be better from user usage point of view if an error message will > display for the invalid max range value "9223372036854775807" as it is > displaying while setting the input value as "0" For example "hdfs > dfsadmin -setQuota 9223372036854775807 /quota" > !image-2019-11-13-14-05-19-603.png! > > * - Try to set quota for a directory with invalid input value as "0" It > will throw an error message as "setQuota: Invalid values for quota : 0 and > 9223372036854775807" For example "hdfs dfsadmin -setQuota 0 /quota" > !image-2019-11-13-14-07-04-536.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14984) HDFS setQuota: Error message should be added for invalid input max range value to hdfs dfsadmin -setQuota command
[
https://issues.apache.org/jira/browse/HDFS-14984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116383#comment-17116383
]
Zhao Yi Ming commented on HDFS-14984:
-
[~hemanthboyina] I think [~SouryakantaDwivedy] means the when set the quota to
9223372036854775807, it should throw a message, because when set quota to 0 the
error message said *setQuota: Invalid values for quota : 0 and
9223372036854775807*
{code:java}
$ hdfs dfsadmin -setQuota 0 /quota
setQuota: Invalid values for quota : 0 and 9223372036854775807
Usage: hdfs dfsadmin [-setQuota ...]
$ hdfs dfsadmin -setQuota 9223372036854775807 /quota
$
{code}
Also I think the logic in DFSClient.java has some problem.
{code:java}
DFSClient.java
if ((namespaceQuota <= 0 &&
namespaceQuota != HdfsConstants.QUOTA_DONT_SET && ===> seems we do
NOT need to judge the namespaceQuota != HdfsConstants.QUOTA_DONT_SET because
first judge is namespaceQuota <= 0 which means if namespaceQuota <= 0 it
already != HdfsConstants.QUOTA_DONT_SET
namespaceQuota != HdfsConstants.QUOTA_RESET) ||
(storagespaceQuota < 0 &&
storagespaceQuota != HdfsConstants.QUOTA_DONT_SET &&
storagespaceQuota != HdfsConstants.QUOTA_RESET)) {
throw new IllegalArgumentException("Invalid values for quota : " +
namespaceQuota + " and " +
storagespaceQuota);} {code}
and if nsQuota equals Long.MAX_VALUE , we are setting with Old NS Quota, maybe
a warning throw in the client(will not call the rpc), or we can change the
error message *setQuota: Invalid values for quota : 0 and 9223372036854775807*
to ** *setQuota: Invalid values for quota : 0 and _9223372036854775806_***
So I want to assign this issue to me. Any ideas? Thanks!
> HDFS setQuota: Error message should be added for invalid input max range
> value to hdfs dfsadmin -setQuota command
> -
>
> Key: HDFS-14984
> URL: https://issues.apache.org/jira/browse/HDFS-14984
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
>Affects Versions: 3.1.2
>Reporter: Souryakanta Dwivedy
>Priority: Minor
> Attachments: image-2019-11-13-14-05-19-603.png,
> image-2019-11-13-14-07-04-536.png
>
>
> An error message should be added for invalid input max range value
> "9223372036854775807" to hdfs dfsadmin -setQuota command
> * set quota for a directory with invalid input vlaue as
> "9223372036854775807"- set quota for a directory with invalid input vlaue as
> "9223372036854775807" the command will be successful without displaying any
> result.Quota value will not be set for the directory internally,but it
> will be better from user usage point of view if an error message will
> display for the invalid max range value "9223372036854775807" as it is
> displaying while setting the input value as "0" For example "hdfs
> dfsadmin -setQuota 9223372036854775807 /quota"
> !image-2019-11-13-14-05-19-603.png!
>
> * - Try to set quota for a directory with invalid input value as "0" It
> will throw an error message as "setQuota: Invalid values for quota : 0 and
> 9223372036854775807" For example "hdfs dfsadmin -setQuota 0 /quota"
> !image-2019-11-13-14-07-04-536.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14984) HDFS setQuota: Error message should be added for invalid input max range value to hdfs dfsadmin -setQuota command
[
https://issues.apache.org/jira/browse/HDFS-14984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984589#comment-16984589
]
hemanthboyina commented on HDFS-14984:
--
if we set an invalid input 9223372036854775807(which is Long.MAX_VALUE) . it
should go through the if condition and throw exception (based on error thrown
for invalid input)
{code:java}
DFSClient.java
if ((namespaceQuota <= 0 &&
namespaceQuota != HdfsConstants.QUOTA_DONT_SET &&
namespaceQuota != HdfsConstants.QUOTA_RESET) ||
(storagespaceQuota < 0 &&
storagespaceQuota != HdfsConstants.QUOTA_DONT_SET &&
storagespaceQuota != HdfsConstants.QUOTA_RESET)) {
throw new IllegalArgumentException("Invalid values for quota : " +
namespaceQuota + " and " +
storagespaceQuota);} {code}
but in FSDirAttrOp.java , we have an else if check , if nsQuota equals
Long.MAX_VALUE , we are setting with Old NS Quota.
{code:java}
final QuotaCounts oldQuota = dirNode.getQuotaCounts();
final long oldNsQuota = oldQuota.getNameSpace();
final long oldSsQuota = oldQuota.getStorageSpace();
if (dirNode.isRoot() && nsQuota == HdfsConstants.QUOTA_RESET) {
nsQuota = HdfsConstants.QUOTA_DONT_SET;
} else if (nsQuota == HdfsConstants.QUOTA_DONT_SET) {
nsQuota = oldNsQuota;
}
// unchanged space/namespace quota
if (type == null && oldNsQuota == nsQuota && oldSsQuota == ssQuota) {
return null;
} {code}
Either the exception message was not proper or the if condition was not
correct in DFSClient .
please correct me if am wrong .
> HDFS setQuota: Error message should be added for invalid input max range
> value to hdfs dfsadmin -setQuota command
> -
>
> Key: HDFS-14984
> URL: https://issues.apache.org/jira/browse/HDFS-14984
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
>Affects Versions: 3.1.2
>Reporter: Souryakanta Dwivedy
>Priority: Minor
> Attachments: image-2019-11-13-14-05-19-603.png,
> image-2019-11-13-14-07-04-536.png
>
>
> An error message should be added for invalid input max range value
> "9223372036854775807" to hdfs dfsadmin -setQuota command
> * set quota for a directory with invalid input vlaue as
> "9223372036854775807"- set quota for a directory with invalid input vlaue as
> "9223372036854775807" the command will be successful without displaying any
> result.Quota value will not be set for the directory internally,but it
> will be better from user usage point of view if an error message will
> display for the invalid max range value "9223372036854775807" as it is
> displaying while setting the input value as "0" For example "hdfs
> dfsadmin -setQuota 9223372036854775807 /quota"
> !image-2019-11-13-14-05-19-603.png!
>
> * - Try to set quota for a directory with invalid input value as "0" It
> will throw an error message as "setQuota: Invalid values for quota : 0 and
> 9223372036854775807" For example "hdfs dfsadmin -setQuota 0 /quota"
> !image-2019-11-13-14-07-04-536.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
