[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340787#comment-17340787
]
lei w commented on HDFS-14986:
--
hi [~Aiphag0] , Could you explain how you solve the deadlock problem in
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340751#comment-17340751
]
lei w commented on HDFS-14986:
--
hi [~Aiphag0] ，Will hadoop 3.1.2 also appear deadlock as you said above ?
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340750#comment-17340750
]
lei w commented on HDFS-14986:
--
hi [~Aiphag0] ， Will hadoop 3.1.2 also appear deadlock as you said above
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340749#comment-17340749
]
lei w commented on HDFS-14986:
--
hi [~Aiphag0] ， hadoop 3.1.2 also appear deadlock as you said above
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340727#comment-17340727
]
lei w commented on HDFS-14986:
--
hi Aiphag0 , deadlock will appear in hadoop3.x ?
>
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991911#comment-16991911
]
Jonathan Hung commented on HDFS-14986:
--
Removing 2.11.0 fix version after branch-2 -> branch-2.10
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984766#comment-16984766
]
fanghanyun commented on HDFS-14986:
---
hadoop version 2.6.0-cdh5.13.1
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984170#comment-16984170
]
Aiphago commented on HDFS-14986:
Thanks a lot for the review [~linyiqun].
> ReplicaCachingGetSpaceUsed
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984102#comment-16984102
]
Hudson commented on HDFS-14986:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17705 (See
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984096#comment-16984096
]
Yiqun Lin commented on HDFS-14986:
--
LGTM, +1. Committing this.
> ReplicaCachingGetSpaceUsed throws
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983808#comment-16983808
]
Hadoop QA commented on HDFS-14986:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983513#comment-16983513
]
Aiphago commented on HDFS-14986:
Good advice,I change the retrytimes to 10 and close the stream in while
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983466#comment-16983466
]
Hadoop QA commented on HDFS-14986:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983455#comment-16983455
]
Yiqun Lin commented on HDFS-14986:
--
[~Aiphag0], the change looks good to me. I rerun the unit test in my
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983213#comment-16983213
]
Aiphago commented on HDFS-14986:
Hi [~linyiqun],Thank you for your valuable advice.I improve the patch as
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983153#comment-16983153
]
Yiqun Lin commented on HDFS-14986:
--
Comment makes sense to me. I have minor suggestion for
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980042#comment-16980042
]
Aiphago commented on HDFS-14986:
Hi
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980017#comment-16980017
]
Yiqun Lin commented on HDFS-14986:
--
Hi [~Aiphag0], the latest patch can still be simplified. Actually we
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979994#comment-16979994
]
Hadoop QA commented on HDFS-14986:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979853#comment-16979853
]
Aiphago commented on HDFS-14986:
Hi [~linyiqun],Thank you for your valuable advice.And now
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979036#comment-16979036
]
Hadoop QA commented on HDFS-14986:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979006#comment-16979006
]
Yiqun Lin commented on HDFS-14986:
--
Hi [~Aiphag0],
{code:java}
+ // Prevent
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978976#comment-16978976
]
Ryan Wu commented on HDFS-14986:
Hi Aiphago, thanks for providing the patch that fix me too. I will
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978951#comment-16978951
]
Aiphago commented on HDFS-14986:
hi [~jianliang.wu], I just assign this Jira to myself, please feel free
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978950#comment-16978950
]
Aiphago commented on HDFS-14986:
Hi [~linyiqun],Thank you for your valuable advice.In previous patch I
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978509#comment-16978509
]
Yiqun Lin commented on HDFS-14986:
--
Hi [~Aiphag0], the patch almost looks good to me. Only some minor
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977804#comment-16977804
]
Hadoop QA commented on HDFS-14986:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977328#comment-16977328
]
Aiphago commented on HDFS-14986:
Hi [~linyiqun],I updata the patch.Can you review this
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976301#comment-16976301
]
Aiphago commented on HDFS-14986:
Thanks for your advice, I'll fix later.
> ReplicaCachingGetSpaceUsed
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975680#comment-16975680
]
Yiqun Lin commented on HDFS-14986:
--
Thanks for providing the patch, [~Aiphag0]. I like the fix way. Only
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974888#comment-16974888
]
Aiphago commented on HDFS-14986:
Here is the patch for the trunk can [~leosun08] [~hexiaoqiao]
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973916#comment-16973916
]
Aiphago commented on HDFS-14986:
I means I can fix the dead lock problem with add dataset lock,my first
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973910#comment-16973910
]
Lisheng Sun commented on HDFS-14986:
[~Aiphag0]
if add dataset lock at FsDatasetImpl#deepCopyReplica
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973906#comment-16973906
]
Aiphago commented on HDFS-14986:
We use the branch before 2.8 with the synchronized,and we fix the
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973449#comment-16973449
]
Lisheng Sun commented on HDFS-14986:
[~Aiphag0] which branch could you use?
>
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973446#comment-16973446
]
Lisheng Sun commented on HDFS-14986:
FsDatasetImpl#deepCopyReplica should be synchronized before
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973339#comment-16973339
]
Xiaoqiao He commented on HDFS-14986:
[~linyiqun], we did some modify when backport HDFS-14313 since
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973321#comment-16973321
]
Aiphago commented on HDFS-14986:
"DataNode: [... #283 daemon prio=5 os_prio=0 tid=0x7fd9826a7800
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973317#comment-16973317
]
Aiphago commented on HDFS-14986:
I would like to submit a patch to try to fix this bug later.
>
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973314#comment-16973314
]
Aiphago commented on HDFS-14986:
In -HDFS-14313- we found same concurrent problem before base our hadoop
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973312#comment-16973312
]
Yiqun Lin commented on HDFS-14986:
--
+[~leosun08] to have a look for this as well.
{quote}we meet very
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973305#comment-16973305
]
Xiaoqiao He commented on HDFS-14986:
we meet very similar case (ConcurrentModificationException or
[
https://issues.apache.org/jira/browse/HDFS-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973288#comment-16973288
]
Ryan Wu commented on HDFS-14986:
The DeepCopyReplica method gets FoldedTreeSet from ReplicaMap，at
the
43 matches
Mail list logo
