[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2020-01-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007632#comment-17007632 ] Hudson commented on HDFS-15068: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17810 (See

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2020-01-03 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007626#comment-17007626 ] Masatake Iwasaki commented on HDFS-15068: - +1. committing this. > DataNode could meet deadlock

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2020-01-01 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006581#comment-17006581 ] Xiaoqiao He commented on HDFS-15068: v005 LGTM, Run the failed unit test on local, it seems most of

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002216#comment-17002216 ] Hadoop QA commented on HDFS-15068: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-23 Thread Aiphago (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002146#comment-17002146 ] Aiphago commented on HDFS-15068: Renew the patch,change log.debug to 

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-20 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001050#comment-17001050 ] Íñigo Goiri commented on HDFS-15068: We probably should just let surface the exception in the thread

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000778#comment-17000778 ] Hadoop QA commented on HDFS-15068: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-19 Thread Aiphago (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000679#comment-17000679 ] Aiphago commented on HDFS-15068: Hi [~elgoiri] ,thanks for valuable suggestions.Have test the unit

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-19 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000259#comment-17000259 ] Íñigo Goiri commented on HDFS-15068: * Let's fix the checkstyle too. * Add a javadoc for

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-19 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000129#comment-17000129 ] Masatake Iwasaki commented on HDFS-15068: - Thanks for working on this, [~Aiphag0] and

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-19 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999834#comment-16999834 ] Hadoop QA commented on HDFS-15068: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-18 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999783#comment-16999783 ] Xiaoqiao He commented on HDFS-15068: Thanks [~Aiphag0] for your works, v003 LGTM, Let's wait what

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-18 Thread Aiphago (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999736#comment-16999736 ] Aiphago commented on HDFS-15068: Hi [~hexiaoqiao],thanks for valuable advice,renew the

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-18 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999318#comment-16999318 ] Xiaoqiao He commented on HDFS-15068: Hi [~Aiphag0], v002 is better than previous one. Some minor

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-18 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998990#comment-16998990 ] Hadoop QA commented on HDFS-15068: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-17 Thread Aiphago (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998860#comment-16998860 ] Aiphago commented on HDFS-15068: Thansk [~hexiaoqiao] for the review,I Release the patch with unit test 

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-17 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998162#comment-16998162 ] Hadoop QA commented on HDFS-15068: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-16 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997936#comment-16997936 ] Xiaoqiao He commented on HDFS-15068: Thanks [~Aiphag0] for your contribution. I agree that it is safe

[jira] [Commented] (HDFS-15068) DataNode could meet deadlock if invoke refreshVolumes when register

2019-12-16 Thread Aiphago (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997922#comment-16997922 ] Aiphago commented on HDFS-15068: I change the lock order of refreshVolumes()  and here is the