[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-05-11 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104503#comment-17104503 ] Ayush Saxena commented on HDFS-15243: - Thanx [~rain_lyy] for the update. v006 LGTM +1 Test failures

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-05-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104110#comment-17104110 ] Hadoop QA commented on HDFS-15243: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-05-10 Thread liuyanyu (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104004#comment-17104004 ] liuyanyu commented on HDFS-15243: - Thanks [~ayushtkn] for reviewing, has updated the patch according to

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-05-09 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103306#comment-17103306 ] Ayush Saxena commented on HDFS-15243: - Thanx [~rain_lyy] for the update, had a quick look. Some minor

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-05-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103241#comment-17103241 ] Hadoop QA commented on HDFS-15243: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-04-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083991#comment-17083991 ] Hadoop QA commented on HDFS-15243: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-04-15 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083986#comment-17083986 ] Ayush Saxena commented on HDFS-15243: - If I remember correct, there was a discussion that {{

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-04-15 Thread liuyanyu (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083976#comment-17083976 ] liuyanyu commented on HDFS-15243: - thanks [~ayushtkn] for reviewing, I ignored the compatibility issue. 

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-04-15 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083942#comment-17083942 ] Ayush Saxena commented on HDFS-15243: - Thanx [~rain_lyy] for the patch. Seems you have moved

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-04-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083834#comment-17083834 ] Hadoop QA commented on HDFS-15243: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-04-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083301#comment-17083301 ] Hadoop QA commented on HDFS-15243: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-04-12 Thread liuyanyu (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081955#comment-17081955 ] liuyanyu commented on HDFS-15243: - [~ayushtkn]  Thanks for reviewing, will upload the patch again  >

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-04-11 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081344#comment-17081344 ] Ayush Saxena commented on HDFS-15243: - Thanx [~rain_lyy] for the patch. * Please include a UT

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-04-10 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081145#comment-17081145 ] Hadoop QA commented on HDFS-15243: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-03-28 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069405#comment-17069405 ] Ayush Saxena commented on HDFS-15243: - [~rain_lyy] Have added you to HDFS Contributors and Assigned

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-03-28 Thread liuyanyu (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069355#comment-17069355 ] liuyanyu commented on HDFS-15243: - thanks [~ayushtkn], will consider rename with this logic too, pls 

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-03-28 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069353#comment-17069353 ] Ayush Saxena commented on HDFS-15243: - Thanx [~rain_lyy] should be fine, but you need to make this

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-03-27 Thread liuyanyu (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069165#comment-17069165 ] liuyanyu commented on HDFS-15243: - Yes, we tend to allow read/write but just prevent delete 

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-03-27 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068513#comment-17068513 ] Ayush Saxena commented on HDFS-15243: - You tend to allow read/write but just prevent delete? prevent

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-03-27 Thread liuyanyu (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068387#comment-17068387 ] liuyanyu commented on HDFS-15243: - Thanks [~ayushtkn] for reviewing this. In our production cluster,

[jira] [Commented] (HDFS-15243) Child directory should not be deleted or renamed if parent directory is a protected directory

2020-03-27 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068361#comment-17068361 ] Ayush Saxena commented on HDFS-15243: - Thanx [~rain_lyy] for putting this up. Protected directories