[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2015-02-07 Thread Abhishek Rai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310628#comment-14310628 ] Abhishek Rai commented on HDFS-6908: Thanks Harsh, that sounds reasonable. It gives us

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2015-02-06 Thread Harsh J (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310489#comment-14310489 ] Harsh J commented on HDFS-6908: --- bq. and since it doesn't fix the corrupt fsimage on disk,

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2015-02-06 Thread Abhishek Rai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310377#comment-14310377 ] Abhishek Rai commented on HDFS-6908: We have an HDFS installation in production where

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-26 Thread Juan Yu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110927#comment-14110927 ] Juan Yu commented on HDFS-6908: --- [~jingzhao]] Thanks for reviewing patch and the discussion.

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-25 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109386#comment-14109386 ] Jing Zhao commented on HDFS-6908: - +1 for the latest patch. Thanks for the fix,

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108592#comment-14108592 ] Hadoop QA commented on HDFS-6908: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-24 Thread Juan Yu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108735#comment-14108735 ] Juan Yu commented on HDFS-6908: --- I don't think the failed tests are related to this patch.

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14107908#comment-14107908 ] Hadoop QA commented on HDFS-6908: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-23 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108096#comment-14108096 ] Jing Zhao commented on HDFS-6908: - Actually when deleting a directory from the current

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-22 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106516#comment-14106516 ] Jing Zhao commented on HDFS-6908: - Yeah, I think that is necessary when deleting a

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14107809#comment-14107809 ] Hadoop QA commented on HDFS-6908: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-21 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106127#comment-14106127 ] Jing Zhao commented on HDFS-6908: - Thanks for working on this, [~j...@cloudera.com]!

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-21 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106133#comment-14106133 ] Jing Zhao commented on HDFS-6908: - For the current patch, another comment is that we can

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-21 Thread Juan Yu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106231#comment-14106231 ] Juan Yu commented on HDFS-6908: --- Thanks [~jingzhao]. because the directory is deleted, it

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-21 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106272#comment-14106272 ] Jing Zhao commented on HDFS-6908: - Thanks for the response, [~j...@cloudera.com]. bq. so

[jira] [Commented] (HDFS-6908) incorrect snapshot directory diff generated by snapshot deletion

2014-08-21 Thread Juan Yu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106507#comment-14106507 ] Juan Yu commented on HDFS-6908: --- [~jingzhao]] Thanks for the new unit test and explain the