[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166377#comment-15166377 ] Zhe Zhang commented on HDFS-7955: - [~rakeshr] Yes I think it's a good idea to handle BlockManager code

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160203#comment-15160203 ] Rakesh R commented on HDFS-7955: Thanks [~zhz]. bq. The getUnderReplicatedBlocksCount API is used by upper

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159765#comment-15159765 ] Zhe Zhang commented on HDFS-7955: - bq. Yeah, will start with BlockManager entities, UnderReplicatedBlocks

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154524#comment-15154524 ] Rakesh R commented on HDFS-7955: Thanks a lot [~zhz] and [~andrew.wang] for the suggestions and advice. I

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152916#comment-15152916 ] Andrew Wang commented on HDFS-7955: --- SGTM. We can also do these changes incrementally if that helps;

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151311#comment-15151311 ] Zhe Zhang commented on HDFS-7955: - Good points Andrew. I took a closer look at related class and variable

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151094#comment-15151094 ] Andrew Wang commented on HDFS-7955: --- Yea, I think we should avoid renaming public APIs, though we do have

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149406#comment-15149406 ] Zhe Zhang commented on HDFS-7955: - Thanks Rakesh for taking the lead. I took a look at the {{Replication}}

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146935#comment-15146935 ] Rakesh R commented on HDFS-7955: Thanks [~umamaheswararao] for the reminder. Hi [~zhz], could you please

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139998#comment-15139998 ] Uma Maheswara Rao G commented on HDFS-7955: --- Thanks [~rakeshr] for the work. I think we can close

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126657#comment-15126657 ] Zhe Zhang commented on HDFS-7955: - Thanks Rakesh for updating the patch. +1 on v05 patch. Moving this JIRA

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126752#comment-15126752 ] Zhe Zhang commented on HDFS-7955: - Thanks for taking care of this! > Improve naming of classes, methods,

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126733#comment-15126733 ] Rakesh R commented on HDFS-7955: Thank you [~zhz] for the feedback. I've promoted this jira as an umbrella

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124851#comment-15124851 ] Hadoop QA commented on HDFS-7955: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124615#comment-15124615 ] Zhe Zhang commented on HDFS-7955: - Thanks Rakesh for the patch. All the renames LGTM except for

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124783#comment-15124783 ] Rakesh R commented on HDFS-7955: Thank you [~zhz] for the reviews. Attached another patch addressing the

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122035#comment-15122035 ] Rakesh R commented on HDFS-7955: Thanks [~drankye]. bq. I guess we don't need to worry about this as the

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122382#comment-15122382 ] Hadoop QA commented on HDFS-7955: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121287#comment-15121287 ] Rakesh R commented on HDFS-7955: Thanks [~drankye] for the interest and comments. With this jira, the idea

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121313#comment-15121313 ] Kai Zheng commented on HDFS-7955: - Thanks Rakesh. bq. I could see changing the entire block recovery will

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120837#comment-15120837 ] Rakesh R commented on HDFS-7955: oops, my previous patch was wrong. I've attached another one. Due to

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120875#comment-15120875 ] Kai Zheng commented on HDFS-7955: - Thanks for the discussions. I have two questions. * Considering in most

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120935#comment-15120935 ] Hadoop QA commented on HDFS-7955: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119989#comment-15119989 ] Rakesh R commented on HDFS-7955: Thank you [~zhz], [~andrew.wang], [~szetszwo] for the review comments so

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120069#comment-15120069 ] Hadoop QA commented on HDFS-7955: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120164#comment-15120164 ] Zhe Zhang commented on HDFS-7955: - Thanks Rakesh! Not sure why Jenkins couldn't apply the patch on trunk, I

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120180#comment-15120180 ] Hadoop QA commented on HDFS-7955: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903030#comment-14903030 ] Zhe Zhang commented on HDFS-7955: - [~rakeshr] I think Andrew's suggestion above is consistent with your

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903144#comment-14903144 ] Rakesh R commented on HDFS-7955: OK, thank [~zhz] for the reply. As the jira is marked for second phase,

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804298#comment-14804298 ] Andrew Wang commented on HDFS-7955: --- I noticed with HDFS-8899 the datanode config keys need some

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804957#comment-14804957 ] Rakesh R commented on HDFS-7955: Thanks [~andrew.wang] for the advice. As this jira is under follow-on

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499267#comment-14499267 ] Rakesh R commented on HDFS-7955: +1 moving under HDFS-8031 umbrella jira Improve naming

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498942#comment-14498942 ] Zhe Zhang commented on HDFS-7955: - Thanks for the work Rakesh and I apologize for not

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482683#comment-14482683 ] Rakesh R commented on HDFS-7955: reconstruction makes sense to me. Improve naming of

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483481#comment-14483481 ] Zhe Zhang commented on HDFS-7955: - [~rakeshr] Great! Do you want to write a patch based on

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484628#comment-14484628 ] Rakesh R commented on HDFS-7955: [~zhz] attached an initial draft patch to show the

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482200#comment-14482200 ] Zhe Zhang commented on HDFS-7955: - [~rakeshr] Thanks for the question. Yes I will create a

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481085#comment-14481085 ] Rakesh R commented on HDFS-7955: bq. It sounds good to use Redundancy to replace

[jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery

[ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389363#comment-14389363 ] Zhe Zhang commented on HDFS-7955: - 2nd task will be converted to a trunk JIRA. Improve