[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946418#comment-14946418
]
Rakesh R commented on HDFS-8632:
HDFS-9182 has modified some of the files. Again attaching new re-based
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947907#comment-14947907
]
Andrew Wang commented on HDFS-8632:
---
+1 LGTM will commit shortly, thanks Rakesh!
> Erasure Coding: Add
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944598#comment-14944598
]
Rakesh R commented on HDFS-8632:
Note: Please ignore test case failures, those are not related to the
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944533#comment-14944533
]
Hadoop QA commented on HDFS-8632:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944074#comment-14944074
]
Andrew Wang commented on HDFS-8632:
---
There've been some refactors that moved things to hdfs-client, mind
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944430#comment-14944430
]
Rakesh R commented on HDFS-8632:
Thank you, I've re-based the patch on latest trunk code and attached the
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937443#comment-14937443
]
Zhe Zhang commented on HDFS-8632:
-
Sorry missed the message. The patch LGTM. [~andrew.wang] kindly offered
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934693#comment-14934693
]
Rakesh R commented on HDFS-8632:
[~zhz], any more comments, would you please review the latest patch
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903242#comment-14903242
]
Rakesh R commented on HDFS-8632:
Thanks again [~zhz]. Attached another patch addressing the above comment.
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903167#comment-14903167
]
Zhe Zhang commented on HDFS-8632:
-
Thanks Andrew for the input. Per the above discussion I think we should
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903165#comment-14903165
]
Rakesh R commented on HDFS-8632:
Thank you [~zhz], [~andrew.wang] for the reviews.
Hi [~zhz], is there
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903615#comment-14903615
]
Hadoop QA commented on HDFS-8632:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901250#comment-14901250
]
Andrew Wang commented on HDFS-8632:
---
Private APIs don't need stability annotations, we're free to change
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901153#comment-14901153
]
Zhe Zhang commented on HDFS-8632:
-
Thanks Rakesh for the work! Most annotations in the patch look good. The
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14805253#comment-14805253
]
Hadoop QA commented on HDFS-8632:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803173#comment-14803173
]
Rakesh R commented on HDFS-8632:
It seems there are few [findbug warnings on LocatedStripedBlock
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14802949#comment-14802949
]
Hadoop QA commented on HDFS-8632:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803375#comment-14803375
]
Hadoop QA commented on HDFS-8632:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746691#comment-14746691
]
Rakesh R commented on HDFS-8632:
Thanks [~zhz]. I've rebased the patch in the latest branch. Please take a
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744180#comment-14744180
]
Zhe Zhang commented on HDFS-8632:
-
[~rakeshr] [~walter.k.su] After HDFS-8833 I think the semantics should
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728551#comment-14728551
]
Rakesh R commented on HDFS-8632:
Agreed, will do together with HDFS-7351
> Erasure Coding: Add
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720873#comment-14720873
]
Walter Su commented on HDFS-8632:
-
Thanks [~rakeshr]. And sorry for late review. Semantics
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594785#comment-14594785
]
Hadoop QA commented on HDFS-8632:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594208#comment-14594208
]
Hadoop QA commented on HDFS-8632:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593251#comment-14593251
]
Rakesh R commented on HDFS-8632:
Attached patch based on the initial analysis. Please
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591828#comment-14591828
]
Rakesh R commented on HDFS-8632:
Following are some of the classes which doesn't have the
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592833#comment-14592833
]
Walter Su commented on HDFS-8632:
-
@InterfaceAudience.Private
@InterfaceStability.Evolving
[
https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592883#comment-14592883
]
Rakesh R commented on HDFS-8632:
Thanks [~walter.k.su] for pointing out this. I will take
28 matches
Mail list logo
