[jira] [Commented] (HDFS-9674) The HTrace span for OpWriteBlock should record the maxWriteToDisk time
[ https://issues.apache.org/jira/browse/HDFS-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112873#comment-15112873 ] Colin Patrick McCabe commented on HDFS-9674: Thanks, [~zhz]. > The HTrace span for OpWriteBlock should record the maxWriteToDisk time > -- > > Key: HDFS-9674 > URL: https://issues.apache.org/jira/browse/HDFS-9674 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode, tracing >Affects Versions: 2.4.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 2.9.0 > > Attachments: HTRACE-9674.001.patch > > > The HTrace span for OpWriteBlock should record the maxWriteToDisk time. That > way, if the trace span is long, we can figure out whether it is because of a > hard disk or I/O issue, or something else. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9674) The HTrace span for OpWriteBlock should record the maxWriteToDisk time
[ https://issues.apache.org/jira/browse/HDFS-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111371#comment-15111371 ] Hudson commented on HDFS-9674: -- FAILURE: Integrated in Hadoop-trunk-Commit #9156 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9156/]) HDFS-9674. The HTrace span for OpWriteBlock should record the (zhz: rev b4a05c1fd5ae98e28cf2b15f5b068e6c2d12f2a8) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java > The HTrace span for OpWriteBlock should record the maxWriteToDisk time > -- > > Key: HDFS-9674 > URL: https://issues.apache.org/jira/browse/HDFS-9674 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode, tracing >Affects Versions: 2.4.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 2.9.0 > > Attachments: HTRACE-9674.001.patch > > > The HTrace span for OpWriteBlock should record the maxWriteToDisk time. That > way, if the trace span is long, we can figure out whether it is because of a > hard disk or I/O issue, or something else. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9674) The HTrace span for OpWriteBlock should record the maxWriteToDisk time
[ https://issues.apache.org/jira/browse/HDFS-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111325#comment-15111325 ] Zhe Zhang commented on HDFS-9674: - Thanks Colin. +1 on the patch. The failed tests are not related to the change and pass locally. I just committed the patch to trunk and branch-2. > The HTrace span for OpWriteBlock should record the maxWriteToDisk time > -- > > Key: HDFS-9674 > URL: https://issues.apache.org/jira/browse/HDFS-9674 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode, tracing >Affects Versions: 2.4.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 2.9.0 > > Attachments: HTRACE-9674.001.patch > > > The HTrace span for OpWriteBlock should record the maxWriteToDisk time. That > way, if the trace span is long, we can figure out whether it is because of a > hard disk or I/O issue, or something else. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9674) The HTrace span for OpWriteBlock should record the maxWriteToDisk time
[
https://issues.apache.org/jira/browse/HDFS-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110073#comment-15110073
]
Hadoop QA commented on HDFS-9674:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
33s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 51s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
50s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 45s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 15s
{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new +
57 unchanged - 1 fixed = 58 total (was 58) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 4s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 47s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 52m 24s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_66. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 49m 2s
{color} | {color:green} hadoop-hdfs in the patch passed with JDK v1.7.0_91.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 127m 3s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests |
hadoop.hdfs.shortcircuit.TestShortCircuitCache |
| | hadoop.hdfs.server.namenode.TestNNThroughputBenchmark |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12783504/HTRACE-9674.001.patch
|
| JIRA Issue | HDFS-9674 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
|
