[jira] [Updated] (HDFS-12218) Rename split EC / replicated block metrics in BlockManager
[ https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12218: --- Resolution: Fixed Fix Version/s: 3.0.0-beta1 Status: Resolved (was: Patch Available) Thanks again for the reviews Eddy! I fixed the extra import at commit time, and committed the two-patch series to trunk and branch-3.0 for beta1. This nicely preserved the rename :) > Rename split EC / replicated block metrics in BlockManager > -- > > Key: HDFS-12218 > URL: https://issues.apache.org/jira/browse/HDFS-12218 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding, metrics >Affects Versions: 3.0.0-beta1 >Reporter: Andrew Wang >Assignee: Andrew Wang >Priority: Blocker > Labels: hdfs-ec-3.0-must-do > Fix For: 3.0.0-beta1 > > Attachments: > 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch, > 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch, > 0003-Rename-the-metric-name-in-FSNamesystem-as-well.patch, > HDFS-12218.consolidated.001.patch, HDFS-12218.consolidated.002.patch, > HDFS-12218.consolidated.003.patch > > > Noted in HDFS-12206, we should propagate the naming changes made in > HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an > opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12218) Rename split EC / replicated block metrics in BlockManager
[ https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12218: --- Attachment: HDFS-12218.consolidated.003.patch Thanks for the review Eddy, new consolidated patch attached addressing your nit and rebasing so we can get a precommit run.. > Rename split EC / replicated block metrics in BlockManager > -- > > Key: HDFS-12218 > URL: https://issues.apache.org/jira/browse/HDFS-12218 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding, metrics >Affects Versions: 3.0.0-beta1 >Reporter: Andrew Wang >Assignee: Andrew Wang >Priority: Blocker > Labels: hdfs-ec-3.0-must-do > Attachments: > 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch, > 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch, > 0003-Rename-the-metric-name-in-FSNamesystem-as-well.patch, > HDFS-12218.consolidated.001.patch, HDFS-12218.consolidated.002.patch, > HDFS-12218.consolidated.003.patch > > > Noted in HDFS-12206, we should propagate the naming changes made in > HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an > opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12218) Rename split EC / replicated block metrics in BlockManager
[ https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12218: --- Status: Patch Available (was: Open) > Rename split EC / replicated block metrics in BlockManager > -- > > Key: HDFS-12218 > URL: https://issues.apache.org/jira/browse/HDFS-12218 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding, metrics >Affects Versions: 3.0.0-beta1 >Reporter: Andrew Wang >Assignee: Andrew Wang >Priority: Blocker > Labels: hdfs-ec-3.0-must-do > Attachments: > 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch, > 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch, > 0003-Rename-the-metric-name-in-FSNamesystem-as-well.patch, > HDFS-12218.consolidated.001.patch, HDFS-12218.consolidated.002.patch > > > Noted in HDFS-12206, we should propagate the naming changes made in > HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an > opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12218) Rename split EC / replicated block metrics in BlockManager
[ https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12218: --- Priority: Blocker (was: Major) > Rename split EC / replicated block metrics in BlockManager > -- > > Key: HDFS-12218 > URL: https://issues.apache.org/jira/browse/HDFS-12218 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding, metrics >Affects Versions: 3.0.0-beta1 >Reporter: Andrew Wang >Assignee: Andrew Wang >Priority: Blocker > Labels: hdfs-ec-3.0-must-do > Attachments: > 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch, > 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch, > 0003-Rename-the-metric-name-in-FSNamesystem-as-well.patch, > HDFS-12218.consolidated.001.patch, HDFS-12218.consolidated.002.patch > > > Noted in HDFS-12206, we should propagate the naming changes made in > HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an > opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12218) Rename split EC / replicated block metrics in BlockManager
[ https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12218: --- Labels: hdfs-ec-3.0-must-do (was: ) > Rename split EC / replicated block metrics in BlockManager > -- > > Key: HDFS-12218 > URL: https://issues.apache.org/jira/browse/HDFS-12218 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding, metrics >Affects Versions: 3.0.0-beta1 >Reporter: Andrew Wang >Assignee: Andrew Wang > Labels: hdfs-ec-3.0-must-do > Attachments: > 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch, > 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch, > 0003-Rename-the-metric-name-in-FSNamesystem-as-well.patch, > HDFS-12218.consolidated.001.patch, HDFS-12218.consolidated.002.patch > > > Noted in HDFS-12206, we should propagate the naming changes made in > HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an > opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12218) Rename split EC / replicated block metrics in BlockManager
[ https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12218: --- Attachment: HDFS-12218.consolidated.002.patch > Rename split EC / replicated block metrics in BlockManager > -- > > Key: HDFS-12218 > URL: https://issues.apache.org/jira/browse/HDFS-12218 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding, metrics >Affects Versions: 3.0.0-beta1 >Reporter: Andrew Wang > Labels: hdfs-ec-3.0-must-do > Attachments: > 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch, > 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch, > 0003-Rename-the-metric-name-in-FSNamesystem-as-well.patch, > HDFS-12218.consolidated.001.patch, HDFS-12218.consolidated.002.patch > > > Noted in HDFS-12206, we should propagate the naming changes made in > HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an > opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12218) Rename split EC / replicated block metrics in BlockManager
[ https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12218: --- Attachment: 0003-Rename-the-metric-name-in-FSNamesystem-as-well.patch Missed renaming the metric, will post up a new consolidated patch too. I'll squash the #2 and #3 patches when committing for real. > Rename split EC / replicated block metrics in BlockManager > -- > > Key: HDFS-12218 > URL: https://issues.apache.org/jira/browse/HDFS-12218 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding, metrics >Affects Versions: 3.0.0-beta1 >Reporter: Andrew Wang > Attachments: > 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch, > 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch, > 0003-Rename-the-metric-name-in-FSNamesystem-as-well.patch, > HDFS-12218.consolidated.001.patch > > > Noted in HDFS-12206, we should propagate the naming changes made in > HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an > opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12218) Rename split EC / replicated block metrics in BlockManager
[ https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12218: --- Hadoop Flags: Incompatible change Release Note: This renames ClientProtocol#getECBlockGroupsStats to ClientProtocol#getEcBlockGroupStats and ClientProtocol#getBlockStats to ClientProtocol#getReplicatedBlockStats. The return-type classes have also been similarly renamed. Their fields have also been renamed to drop the "stats" suffix. Additionally, ECBlockGroupStats#pendingDeletionBlockGroups has been renamed to ECBlockGroupStats#pendingDeletionBlocks, to clarify that this is the number of blocks, not block groups, pending deletion. The corresponding NameNode metric has also been renamed to PendingDeletionECBlocks. > Rename split EC / replicated block metrics in BlockManager > -- > > Key: HDFS-12218 > URL: https://issues.apache.org/jira/browse/HDFS-12218 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding, metrics >Affects Versions: 3.0.0-beta1 >Reporter: Andrew Wang > Attachments: > 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch, > 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch, > HDFS-12218.consolidated.001.patch > > > Noted in HDFS-12206, we should propagate the naming changes made in > HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an > opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12218) Rename split EC / replicated block metrics in BlockManager
[ https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12218: --- Attachment: HDFS-12218.consolidated.001.patch Here's a consolidated patch. I found some more places that need renaming to remove the "Stats" suffix within BlockManager and also the getFsBlocksStats API which required a lot of movement. Looking at InvalidateBlocks, it's counting the number of blocks, not block groups, so I updated that as well everywhere. The split patches are easier to review, since it does the rename separate from the rest of the changes. [~manojg] / [~eddyxu] could you review? > Rename split EC / replicated block metrics in BlockManager > -- > > Key: HDFS-12218 > URL: https://issues.apache.org/jira/browse/HDFS-12218 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding, metrics >Affects Versions: 3.0.0-beta1 >Reporter: Andrew Wang > Attachments: > 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch, > 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch, > HDFS-12218.consolidated.001.patch > > > Noted in HDFS-12206, we should propagate the naming changes made in > HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an > opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12218) Rename split EC / replicated block metrics in BlockManager
[ https://issues.apache.org/jira/browse/HDFS-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12218: --- Attachment: 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch Here are some split patches that preserve the rename. Will attach a consolidated patch for Jenkins. > Rename split EC / replicated block metrics in BlockManager > -- > > Key: HDFS-12218 > URL: https://issues.apache.org/jira/browse/HDFS-12218 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding, metrics >Affects Versions: 3.0.0-beta1 >Reporter: Andrew Wang > Attachments: > 0001-Rename-ECBlockGroupsStats-to-ECBlockGroupStats-and-B.patch, > 0002-Deeper-rename-of-BlocksStats-to-BlockStats-and-ECBlo.patch > > > Noted in HDFS-12206, we should propagate the naming changes made in > HDFS-12206 for FSNamesystem into BlockManager and related classes. Also an > opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
