[jira] [Updated] (HDFS-12377) Refactor TestReadStripedFileWithDecoding to avoid test timeouts
[ https://issues.apache.org/jira/browse/HDFS-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12377: --- Resolution: Fixed Fix Version/s: 3.0.0-beta1 Status: Resolved (was: Patch Available) Thanks again for the review Xiao, committed to trunk and branch-3.0. > Refactor TestReadStripedFileWithDecoding to avoid test timeouts > --- > > Key: HDFS-12377 > URL: https://issues.apache.org/jira/browse/HDFS-12377 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha3 >Reporter: Andrew Wang >Assignee: Andrew Wang > Fix For: 3.0.0-beta1 > > Attachments: HDFS-12377.001.patch, HDFS-12377.002.patch, > HDFS-12377.003.patch, HDFS-12377.004.patch > > > This test times out since the nested for loops means it runs 12 > configurations inside each test method. > Let's refactor this to use JUnit parameters instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12377) Refactor TestReadStripedFileWithDecoding to avoid test timeouts
[ https://issues.apache.org/jira/browse/HDFS-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12377: --- Attachment: HDFS-12377.004.patch Thanks again for reviewing Xiao, new patch to cleanup the timeout settings and also remove extra imports. > Refactor TestReadStripedFileWithDecoding to avoid test timeouts > --- > > Key: HDFS-12377 > URL: https://issues.apache.org/jira/browse/HDFS-12377 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha3 >Reporter: Andrew Wang >Assignee: Andrew Wang > Attachments: HDFS-12377.001.patch, HDFS-12377.002.patch, > HDFS-12377.003.patch, HDFS-12377.004.patch > > > This test times out since the nested for loops means it runs 12 > configurations inside each test method. > Let's refactor this to use JUnit parameters instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12377) Refactor TestReadStripedFileWithDecoding to avoid test timeouts
[ https://issues.apache.org/jira/browse/HDFS-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12377: --- Attachment: HDFS-12377.003.patch Thanks Xiao, new patch attached parameterizing that additional test. Fixed the checkstyles and some other small improvements too along the way. I think the testBlockTokenExpired failures are new, and they seem to fail quite reproducibly. I haven't had time to bisect it, but agree that it seems recent. The EC tests in general seem very flaky, we need a push to stabilize these (particularly before GA). > Refactor TestReadStripedFileWithDecoding to avoid test timeouts > --- > > Key: HDFS-12377 > URL: https://issues.apache.org/jira/browse/HDFS-12377 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha3 >Reporter: Andrew Wang >Assignee: Andrew Wang > Attachments: HDFS-12377.001.patch, HDFS-12377.002.patch, > HDFS-12377.003.patch > > > This test times out since the nested for loops means it runs 12 > configurations inside each test method. > Let's refactor this to use JUnit parameters instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12377) Refactor TestReadStripedFileWithDecoding to avoid test timeouts
[ https://issues.apache.org/jira/browse/HDFS-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12377: --- Attachment: HDFS-12377.002.patch I refactored these again to use composition, and split the long-running test in half. Now runs in 4mins each on my laptop, which should slide in under the surefire timeout. > Refactor TestReadStripedFileWithDecoding to avoid test timeouts > --- > > Key: HDFS-12377 > URL: https://issues.apache.org/jira/browse/HDFS-12377 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha3 >Reporter: Andrew Wang >Assignee: Andrew Wang > Attachments: HDFS-12377.001.patch, HDFS-12377.002.patch > > > This test times out since the nested for loops means it runs 12 > configurations inside each test method. > Let's refactor this to use JUnit parameters instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12377) Refactor TestReadStripedFileWithDecoding to avoid test timeouts
[ https://issues.apache.org/jira/browse/HDFS-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12377: --- Attachment: HDFS-12377.001.patch Patch attached. > Refactor TestReadStripedFileWithDecoding to avoid test timeouts > --- > > Key: HDFS-12377 > URL: https://issues.apache.org/jira/browse/HDFS-12377 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha3 >Reporter: Andrew Wang >Assignee: Andrew Wang > Attachments: HDFS-12377.001.patch > > > This test times out since the nested for loops means it runs 12 > configurations inside each test method. > Let's refactor this to use JUnit parameters instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12377) Refactor TestReadStripedFileWithDecoding to avoid test timeouts
[ https://issues.apache.org/jira/browse/HDFS-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-12377: --- Status: Patch Available (was: Open) > Refactor TestReadStripedFileWithDecoding to avoid test timeouts > --- > > Key: HDFS-12377 > URL: https://issues.apache.org/jira/browse/HDFS-12377 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha3 >Reporter: Andrew Wang >Assignee: Andrew Wang > Attachments: HDFS-12377.001.patch > > > This test times out since the nested for loops means it runs 12 > configurations inside each test method. > Let's refactor this to use JUnit parameters instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
