[jira] [Updated] (HDFS-7756) DatanodeInfoWithStorage should be tagged Private

2015-02-09 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HDFS-7756:
-
Attachment: hdfs-7756-002.patch

Alternative patch which restores method signature for 
LocatedBlock#getLocations()

 DatanodeInfoWithStorage should be tagged Private
 

 Key: HDFS-7756
 URL: https://issues.apache.org/jira/browse/HDFS-7756
 Project: Hadoop HDFS
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: hdfs-7756-001.patch, hdfs-7756-002.patch


 This is related to HDFS-7647
 DatanodeInfoWithStorage was introduced in 
 org.apache.hadoop.hdfs.server.protocol package whereas its base class, 
 DatanodeInfo, is in org.apache.hadoop.hdfs.protocol
 DatanodeInfo is tagged @InterfaceAudience.Private
 DatanodeInfoWithStorage should have the same tag.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7756) DatanodeInfoWithStorage should be tagged Private

2015-02-09 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HDFS-7756:
-
Status: Patch Available  (was: Open)

 DatanodeInfoWithStorage should be tagged Private
 

 Key: HDFS-7756
 URL: https://issues.apache.org/jira/browse/HDFS-7756
 Project: Hadoop HDFS
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: hdfs-7756-001.patch


 This is related to HDFS-7647
 DatanodeInfoWithStorage was introduced in 
 org.apache.hadoop.hdfs.server.protocol package whereas its base class, 
 DatanodeInfo, is in org.apache.hadoop.hdfs.protocol
 DatanodeInfo is tagged @InterfaceAudience.Private
 DatanodeInfoWithStorage should have the same tag.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-7756) DatanodeInfoWithStorage should be tagged Private

2015-02-09 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HDFS-7756:
-
Attachment: hdfs-7756-001.patch

Proposed patch.

In order not to break downstream projects which reorder DatanodeInfo's (such as 
HBase), I was thinking keeping the method signature for 
LocatedBlock#getLocations().

The caller to LocatedBlock#getLocations() can do instanceof check on the first 
element to see if DatanodeInfoWithStorage is returned.

Comment / suggestion is welcome.

 DatanodeInfoWithStorage should be tagged Private
 

 Key: HDFS-7756
 URL: https://issues.apache.org/jira/browse/HDFS-7756
 Project: Hadoop HDFS
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: hdfs-7756-001.patch


 This is related to HDFS-7647
 DatanodeInfoWithStorage was introduced in 
 org.apache.hadoop.hdfs.server.protocol package whereas its base class, 
 DatanodeInfo, is in org.apache.hadoop.hdfs.protocol
 DatanodeInfo is tagged @InterfaceAudience.Private
 DatanodeInfoWithStorage should have the same tag.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)