[
https://issues.apache.org/jira/browse/HDDS-2373?focusedWorklogId=335081=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-335081
]
ASF GitHub Bot logged work on HDDS-2373:
Author: ASF GitHub Bot
Created on: 28/Oct/19 18:11
Start Date: 28/Oct/19 18:11
Worklog Time Spent: 10m
Work Description: fapifta commented on pull request #95: HDDS-2373 Move
isUseRatis getFactor and getType from XCeiverClientManager
URL: https://github.com/apache/hadoop-ozone/pull/95
## What changes were proposed in this pull request?
The PR aims to remove the isUseRatis(), getType(), and getFactor methods
from the XCeiverClientManager class, as the return values of these methods are
dependent on a single configuration value
(ScmConfigKeys.DFS_CONTAINER_RATIS_ENABLED_KEY).
The proposed solution moves the setup of the ContainerOperationClient setup
to its constructor, with that the ContainerOperationClient class will be
responsible to set up its internally used SCMClient, and XCeiverClientManager
based on the configuration.
It also gets responsible to set up the container size limit based on the
configuration, and it is not being set anymore via a static method.
To deal with the change, and to provide an easy way to get the values in
JUnit tests, SCMTestUtil gets two new pubic static utility methods to get the
ReplicationType, and ReplicationFactor based on the configuration. All accesses
of the old methods on XCeiverClientManager are mapped to the new static utility
methods.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2373 - Move isUseRatis getFactor
and getType from XCeiverClientManager
## How was this patch tested?
As this is a refactoring without changing any outer logic, no new JUnit
tests are needed, but all existent tests has to pass as before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 335081)
Remaining Estimate: 0h
Time Spent: 10m
> Move isUseRatis getFactor and getType from XCeiverClientManager
> ---
>
> Key: HDDS-2373
> URL: https://issues.apache.org/jira/browse/HDDS-2373
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Istvan Fajth
>Assignee: Istvan Fajth
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The given methods in XCeiverClientManager are working based on the
> configuration supplied in the constructor of XCeiverClientManager class.
> The only real code usage of this is in ContainerOperationsClient.
> Refactor the ContainerOperationsClient constructor to work based on the
> configuration, and then move these values there directly and set the values
> of them at the constructor. Clean up all test references to the methods, and
> remove the methods from the XCeiverClientManager.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
