[ https://issues.apache.org/jira/browse/HDFS-13278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398061#comment-16398061 ]
Íñigo Goiri edited comment on HDFS-13278 at 3/14/18 3:58 AM: ------------------------------------------------------------- I'm not sure if it should go here, but I have a couple nits for {{MountTableResolver}}: * Line 243 should have a space after the if * Line 309 should have {{srcPath}} as parameter. * Line 518 should be {{if (!newPath.endsWith(Path.SEPARATOR) && !remainingPath.isEmpty()) {}}; this will imply removing / from {{TestMountTableResolver#testLocationCache()}}. I can also open a JIRA for those. was (Author: elgoiri): I'm not sure if it should go here, but I have a couple nits for {{MountTableResolver}}: * Line 243 should have a space after the if * Line 309 should have {{srcPath}} as parameter. * Line 518 should be {{if (!newPath.endsWith(Path.SEPARATOR) && !remainingPath.isEmpty()) {}}; this will imply removing / from {{TestMountTableResolver#testLocationCache()}}. I can also open a JIRA for those. > RBF: Correct the logic of mount validate to avoid the bad mountPoint > -------------------------------------------------------------------- > > Key: HDFS-13278 > URL: https://issues.apache.org/jira/browse/HDFS-13278 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs > Affects Versions: 3.2.0 > Reporter: maobaolong > Priority: Major > Labels: RBF > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org