[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-31 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564698#comment-16564698 ] Hudson commented on HDDS-226: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14683 (See

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-31 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564680#comment-16564680 ] Mukul Kumar Singh commented on HDDS-226: Thanks for the contribution [~shashikant] and [~szetszwo],

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-31 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564375#comment-16564375 ] Tsz Wo Nicholas Sze commented on HDDS-226: -- +1 the 09 patch looks good. > Client should update

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-31 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564187#comment-16564187 ] Shashikant Banerjee commented on HDDS-226: -- Test failures are not related. > Client should update

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-31 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564181#comment-16564181 ] genericqa commented on HDDS-226: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-31 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563272#comment-16563272 ] genericqa commented on HDDS-226: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-31 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563239#comment-16563239 ] genericqa commented on HDDS-226: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-31 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563177#comment-16563177 ] Shashikant Banerjee commented on HDDS-226: -- Thanks [~szetszwo] for the review comments. patch v8

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-30 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562502#comment-16562502 ] Tsz Wo Nicholas Sze commented on HDDS-226: -- Thanks for the update. Just some minor comments: -

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-30 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562309#comment-16562309 ] genericqa commented on HDDS-226: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-30 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562170#comment-16562170 ] Shashikant Banerjee commented on HDDS-226: -- Patch v7 addresses the unit test failures. > Client

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-30 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562151#comment-16562151 ] genericqa commented on HDDS-226: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-30 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562045#comment-16562045 ] Shashikant Banerjee commented on HDDS-226: -- Thanks [~msingh], [~szetszwo], [~nandakumar131] for

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-30 Thread Nanda kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561786#comment-16561786 ] Nanda kumar commented on HDDS-226: -- Instead of adding a new class like BlockInfo or modifying BlockID, as

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-30 Thread Nanda kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561702#comment-16561702 ] Nanda kumar commented on HDDS-226: -- I agree with [~szetszwo] on this and to add to that, BlockID is a

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-27 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559991#comment-16559991 ] Tsz Wo Nicholas Sze commented on HDDS-226: -- Currently, BlockID, by its name, contains just IDs.

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-27 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559642#comment-16559642 ] Mukul Kumar Singh commented on HDDS-226: [~szetszwo], Thanks for the review. I feel that block

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-26 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559179#comment-16559179 ] Mukul Kumar Singh commented on HDDS-226: Thanks for working on this [~shashikant]. Apart from Ni

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-26 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558923#comment-16558923 ] Tsz Wo Nicholas Sze commented on HDDS-226: -- Hi [~shashikant], it seems not a good idea to add

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-26 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556960#comment-16556960 ] genericqa commented on HDDS-226: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-25 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556854#comment-16556854 ] Shashikant Banerjee commented on HDDS-226: -- Thanks [~msingh], for having a look at the patch.

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-25 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555382#comment-16555382 ] Mukul Kumar Singh commented on HDDS-226: Thanks for working on this [~shashikant]. The latest patch

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-12 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542477#comment-16542477 ] Shashikant Banerjee commented on HDDS-226: -- Failed tests are not related. > Client should update

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-12 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542319#comment-16542319 ] genericqa commented on HDDS-226: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-12 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542312#comment-16542312 ] genericqa commented on HDDS-226: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-12 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542182#comment-16542182 ] Shashikant Banerjee commented on HDDS-226: -- As per offline discussion with [~anu], removed the

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-12 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541953#comment-16541953 ] genericqa commented on HDDS-226: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-12 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541728#comment-16541728 ] Shashikant Banerjee commented on HDDS-226: -- patch v3 fixes the related test case failure with

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-12 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541698#comment-16541698 ] genericqa commented on HDDS-226: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-12 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541502#comment-16541502 ] Shashikant Banerjee commented on HDDS-226: -- Thanks [~anu], for the review comments. {quote}

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-11 Thread Anu Engineer (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540887#comment-16540887 ] Anu Engineer commented on HDDS-226: --- Looks good overall. Some very minor comments. *

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540340#comment-16540340 ] genericqa commented on HDDS-226: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-11 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540041#comment-16540041 ] Shashikant Banerjee commented on HDDS-226: -- Patch v1 fixes the test failures. > Client should

[jira] [Commented] (HDDS-226) Client should update block length in OM while committing the key

2018-07-10 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538439#comment-16538439 ] genericqa commented on HDDS-226: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||